From: andrew-sh.cheng <andrew-sh.cheng@mediatek.com>
To: Viresh Kumar <viresh.kumar@linaro.org>
Cc: MyungJoo Ham <myungjoo.ham@samsung.com>,
Kyungmin Park <kyungmin.park@samsung.com>,
Chanwoo Choi <cw00.choi@samsung.com>,
"Rob Herring" <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>,
"Matthias Brugger" <matthias.bgg@gmail.com>,
"Rafael J. Wysocki" <rjw@rjwysocki.net>,
Nishanth Menon <nm@ti.com>, Stephen Boyd <sboyd@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>,
<linux-kernel@vger.kernel.org>, <srv_heupstream@mediatek.com>
Subject: Re: [PATCH V8 2/8] cpufreq: mediatek: Enable clock and regulator
Date: Wed, 31 Mar 2021 13:21:39 +0800 [thread overview]
Message-ID: <1617168099.18405.8.camel@mtksdaap41> (raw)
In-Reply-To: <20210330043629.x62j2apv2nv4mw67@vireshk-i7>
On Tue, 2021-03-30 at 10:06 +0530, Viresh Kumar wrote:
> On 23-03-21, 19:33, Andrew-sh.Cheng wrote:
> > From: "Andrew-sh.Cheng" <andrew-sh.cheng@mediatek.com>
> >
> > Need to enable regulator,
> > so that the max/min requested value will be recorded
> > even it is not applied right away.
> >
> > Intermediate clock is not always enabled by ccf in different projects,
> > so cpufreq should enable it by itself.
> >
> > Signed-off-by: Andrew-sh.Cheng <andrew-sh.cheng@mediatek.com>
> > ---
> > drivers/cpufreq/mediatek-cpufreq.c | 33 +++++++++++++++++++++++++++++----
> > 1 file changed, 29 insertions(+), 4 deletions(-)
> >
> > diff --git a/drivers/cpufreq/mediatek-cpufreq.c b/drivers/cpufreq/mediatek-cpufreq.c
> > index f2e491b25b07..432368707ea6 100644
> > --- a/drivers/cpufreq/mediatek-cpufreq.c
> > +++ b/drivers/cpufreq/mediatek-cpufreq.c
> > @@ -350,6 +350,11 @@ static int mtk_cpu_dvfs_info_init(struct mtk_cpu_dvfs_info *info, int cpu)
> > ret = PTR_ERR(proc_reg);
> > goto out_free_resources;
> > }
> > + ret = regulator_enable(proc_reg);
> > + if (ret) {
> > + pr_warn("enable vproc for cpu%d fail\n", cpu);
> > + goto out_free_resources;
> > + }
>
> Regulators are enabled by OPP core as well now, you sure this is
> required ?
>
Hi Viresh,
Yes.
As you mentioned, it will be enable by OPP core.
Per discuss with hotplug owner and regulator owner,
they suggest that "users should not suppose other module, will enable
regulators for them".
They suggest to add enable_regulator here.
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-03-31 5:24 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-23 11:33 [PATCH V8 0/8] Add cpufreq and cci devfreq for mt8183, and SVS support Andrew-sh.Cheng
2021-03-23 11:33 ` [PATCH V8 1/8] PM / devfreq: Add cpu based scaling support to passive_governor Andrew-sh.Cheng
2021-03-25 7:42 ` Chanwoo Choi
2021-03-25 8:14 ` Chanwoo Choi
2021-03-31 8:03 ` andrew-sh.cheng
2021-03-31 8:27 ` Chanwoo Choi
2021-03-31 8:35 ` Chanwoo Choi
2021-03-31 13:03 ` andrew-sh.cheng
2021-04-01 0:16 ` Chanwoo Choi
2021-04-08 2:47 ` Chanwoo Choi
2021-04-22 13:34 ` andrew-sh.cheng
2021-05-26 2:22 ` andrew-sh.cheng
2021-05-26 3:08 ` Chanwoo Choi
2021-05-31 3:22 ` andrew-sh.cheng
2021-05-31 7:56 ` Chanwoo Choi
[not found] ` <CACb=7PUkpMkDOJ6dDHXhJ5ep4e9u8ZVYM8M2iC-iwHXn13t3DQ@mail.gmail.com>
2021-05-31 8:13 ` Chanwoo Choi
2021-03-31 10:46 ` Hsin-Yi Wang
2021-03-23 11:33 ` [PATCH V8 2/8] cpufreq: mediatek: Enable clock and regulator Andrew-sh.Cheng
2021-03-30 4:36 ` Viresh Kumar
2021-03-31 5:21 ` andrew-sh.cheng [this message]
2021-03-31 6:17 ` Viresh Kumar
2021-03-23 11:33 ` [PATCH V8 3/8] dt-bindings: devfreq: add compatible for mt8183 cci devfreq Andrew-sh.Cheng
2021-03-23 11:33 ` [PATCH V8 4/8] devfreq: add mediatek " Andrew-sh.Cheng
2021-03-25 8:04 ` Chanwoo Choi
2021-03-31 6:21 ` andrew-sh.cheng
2021-03-23 11:33 ` [PATCH V8 5/8] cpufreq: mediatek: Add record of previous desired vproc value Andrew-sh.Cheng
2021-03-23 11:33 ` [PATCH V8 6/8] cpufreq: mediatek: add opp notification for SVS support Andrew-sh.Cheng
2021-03-23 11:34 ` [PATCH V8 7/8] devfreq: mediatek: cci devfreq register " Andrew-sh.Cheng
2021-03-25 8:11 ` Chanwoo Choi
2021-03-31 7:53 ` andrew-sh.cheng
2021-03-23 11:34 ` [PATCH V8 8/8] arm64: dts: mediatek: add cpufreq and cci devfreq nodes for mt8183 Andrew-sh.Cheng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1617168099.18405.8.camel@mtksdaap41 \
--to=andrew-sh.cheng@mediatek.com \
--cc=broonie@kernel.org \
--cc=cw00.choi@samsung.com \
--cc=devicetree@vger.kernel.org \
--cc=kyungmin.park@samsung.com \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=linux-pm@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=matthias.bgg@gmail.com \
--cc=myungjoo.ham@samsung.com \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=srv_heupstream@mediatek.com \
--cc=viresh.kumar@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox