From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B57CAC46467 for ; Tue, 10 Jan 2023 12:50:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:Cc:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mi4fAf6ZKW6RgkKtFStAvkAz2LwXn6oLtwpt+KmZ8kM=; b=leJ5yq7JJuCsm0 CAORrsL2/HqP1hZ3cQwjOmtowo+CWD21/nHxBNL0rHClJgQC8PoTducEQ8yxykALYKQCX52RZroVb CLp20S8f9WCidbJXE3JtkL0TxBkMonBVOH7QHyBr/We46Uxu5roMMmRx+Dfp4G+1eLc+s4s1a3oeg 7SVSpdHwVIIDxdp/SbWA7KgblspoegW3NtC4ZETj3UVU5db1ZO5d8eQEsVF9coxMFq3XXK1oC9hNv as+vyNBjXD1z4C+JYrPUhxxwNL8vMoiM2KH//9aicEgDCj9MBgQRyZ3V3zmhnMClNX/clxytybey/ Mjo6S7sOrujYlSdWGTqw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFE4V-006wNp-6b; Tue, 10 Jan 2023 12:49:43 +0000 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pFE4Q-006wMc-TM for linux-arm-kernel@lists.infradead.org; Tue, 10 Jan 2023 12:49:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1673354978; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LtmIDGWw27oWIDOH8I1+LwSysyCQMzRcxJv1yEQeQLc=; b=ObPBiE4IsmNCHMrGb7ZD03iBsfgY9sYRCNbG0Xdzhbu+FmpoS5zRhEl+ss1cqaJJuSH+Fa xN2E7Lw4icpDHN4I7zpEV7GOpXj6bBvFGHj7/xModSGNnJyJqVhGPyCX8VdfqK/Yccm830 4rPS/sLD0ZAaEl5/ThzsqFMwsesl0Lo= Received: from mail-qk1-f198.google.com (mail-qk1-f198.google.com [209.85.222.198]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-116-n9jqsuWENY6olCICFpTRXQ-1; Tue, 10 Jan 2023 07:49:34 -0500 X-MC-Unique: n9jqsuWENY6olCICFpTRXQ-1 Received: by mail-qk1-f198.google.com with SMTP id i4-20020a05620a248400b006febc1651bbso8625418qkn.4 for ; Tue, 10 Jan 2023 04:49:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:mime-version:user-agent:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=LtmIDGWw27oWIDOH8I1+LwSysyCQMzRcxJv1yEQeQLc=; b=Vp5S4VmczN687eD7WwMARqY9DfdtEvYJJmyDu2tsG6Kl4mZwa7L0w7Qw4Ru8Zf9GQe 6d9C/EL4v0AyJvTWqC4ZSTRJ25Fma8pJnMxWHdeecyRAvWHIVZqBGLnOH6cFmzgWtZEP Rd5bTRBlda0Lmsmd1eNUBe3mtHyCPVFH8jaf/Sq9M1SmQ91bW0b+O7e9P0MzL6UBxI+F yodktfb4eiOcdue0bDRmwkC4eJpVquw/9g0HilcFRthJJPEs3zVPOTHtTtW/UpVTHUaY GGJhysSc5YS+QSYkmKFqd5lv4iRndIC/HhnUFiPw0YVSeIxOKpmTE+wlFeYDRMa6lY6Z gBbA== X-Gm-Message-State: AFqh2krqx6xIv13ZeXnblNAjL+coNeyXT9Gl2PCgybUg5+B2cCzxGrAs sHOVKeOKkGR0yJosKqLyvp0vXHvrfvds0QF5kR/27KE3wzzktlZ34vAXlIJHbjh/sYUr4JIlDwX a5JMAZ/6JdcDH2SWvUDwAM2WjhoYWt6elNFk= X-Received: by 2002:ac8:5ed4:0:b0:39c:efc8:b2a8 with SMTP id s20-20020ac85ed4000000b0039cefc8b2a8mr3571963qtx.27.1673354974185; Tue, 10 Jan 2023 04:49:34 -0800 (PST) X-Google-Smtp-Source: AMrXdXuapLeanbK2mF2tkISFRRR7kbnBi3E797VRZF+bY3EPqOw88qp4xilDlE2/BCG9bCjL8KEtBw== X-Received: by 2002:ac8:5ed4:0:b0:39c:efc8:b2a8 with SMTP id s20-20020ac85ed4000000b0039cefc8b2a8mr3571931qtx.27.1673354973900; Tue, 10 Jan 2023 04:49:33 -0800 (PST) Received: from gerbillo.redhat.com (146-241-120-128.dyn.eolo.it. [146.241.120.128]) by smtp.gmail.com with ESMTPSA id g19-20020a05620a40d300b006cec8001bf4sm7232697qko.26.2023.01.10.04.49.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 10 Jan 2023 04:49:33 -0800 (PST) Message-ID: <161fdffccb78fca2f16f1f5c78390420f60817b3.camel@redhat.com> Subject: Re: [PATCH net-next v3 01/11] net: mdio: Add dedicated C45 API to MDIO bus drivers From: Paolo Abeni To: Michael Walle , Heiner Kallweit , Russell King , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jose Abreu , Sergey Shtylyov , Wei Fang , Shenwei Wang , Clark Wang , NXP Linux Team , Sean Wang , Landen Chao , DENG Qingfang , Florian Fainelli , Vladimir Oltean , Matthias Brugger Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-renesas-soc@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mediatek@lists.infradead.org, Andrew Lunn , Geert Uytterhoeven , Vladimir Oltean Date: Tue, 10 Jan 2023 13:49:28 +0100 In-Reply-To: <5bd7ee34ead313785951defbf3069b64d4338a45.camel@redhat.com> References: <20221227-v6-2-rc1-c45-seperation-v3-0-ade1deb438da@walle.cc> <20221227-v6-2-rc1-c45-seperation-v3-1-ade1deb438da@walle.cc> <5bd7ee34ead313785951defbf3069b64d4338a45.camel@redhat.com> User-Agent: Evolution 3.42.4 (3.42.4-2.fc35) MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230110_044939_027339_07AB3FB8 X-CRM114-Status: GOOD ( 15.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2023-01-10 at 12:16 +0100, Paolo Abeni wrote: > On Mon, 2023-01-09 at 16:30 +0100, Michael Walle wrote: > > diff --git a/include/linux/phy.h b/include/linux/phy.h > > index 6378c997ded5..65844f0a7fb3 100644 > > --- a/include/linux/phy.h > > +++ b/include/linux/phy.h > > @@ -364,6 +364,11 @@ struct mii_bus { > > int (*read)(struct mii_bus *bus, int addr, int regnum); > > /** @write: Perform a write transfer on the bus */ > > int (*write)(struct mii_bus *bus, int addr, int regnum, u16 val); > > + /** @read: Perform a C45 read transfer on the bus */ > > Minor nit: s/@read/@read_c45/ > > > + int (*read_c45)(struct mii_bus *bus, int addr, int devnum, int regnum); > > + /** @write: Perform a C45 write transfer on the bus */ > > Mutatis mutandis, same thing here. Otherwise the series LGTM. I think it would be preferable avoiding reposting a largish series like this for such a minor change. I think the series can be merged as-is and the above can be addressed with a follow-up patch. Cheers, Paolo _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel