From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.9 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, USER_AGENT_SANE_2 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2AF02C433B4 for ; Wed, 12 May 2021 02:05:51 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C1478610EA for ; Wed, 12 May 2021 02:05:50 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C1478610EA Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Date:CC:To:From: Subject:Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=4JYtWkXjph4Foz601uPOz5WXlRtryE9LMz2glUTStvo=; b=ZOS9OcL3G00y1kSR1gDY4qAmT nsT043UH/gtMAc882SwO4ajmfG40JKj0PrEAAHtXOun9pNikYTBUAMEcYmDrPAFLXfPzIgD6q3LXE NB0Y7PN/mcbgUg8YSgVHLBzMbf8WpFcHH+0+L3VDBS94l6ELaKSAJ3lsukH0IOjBuzzQJ3VDBPuuM CKeHoDxaqXQ1sdpZg3tceOQbZ4UZU4UdUtHcp3SLPnAQfx2veMTaWQ9QGW6+7QREFWmC8tW7HGwwF z2cbyMIiLYGbBC5sFhgEEMZt76KBRfNcB1Vhlymo57YMI8NwiKda79QbAVnCBQEWlUm2eOdhCkcSs HDPFcUZag==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgeDY-001kVC-7I; Wed, 12 May 2021 02:03:20 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgeDT-001kUv-Jt; Wed, 12 May 2021 02:03:15 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Transfer-Encoding: MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject: Message-ID:Sender:Reply-To:Content-ID:Content-Description; bh=T8K9jXRssUMgZPyRniiOWW1kVzpxyI3Fg5ZYopeSdmA=; b=xsO7/h0sxi8bfWL91wGQc/y+3y xvbkq19iqUIwhTLOhhPlo5ts5q+7pGvzZfVaSJPE91pPWdxRBWB0AiwLaMhwpjbZj7TXvagjG3SM1 QEOg5jaGjbcOLCmoaC0wz1ms6TQjbTnlI9QH76E2FmHBBiMi/VhEoKRfWgyw1d5THYyZohWXXTtcv wRaD79jsoWcLoffTMeckkOhN3woWbsKs5T4vOJS9Laq9d5UTex0aW+3dVLlMQ8oBc+RvDRPRINQGP FkRbLEZH4jhFTF6ZDBd+vI+YseW4B6FiXvZCAmJ4QUBr9BdeJMfftXyZ50O1IyPD/t1pl/l5QE90O LEDoV1Ng==; Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgeDQ-00A2sF-9d; Wed, 12 May 2021 02:03:13 +0000 X-UUID: f7aa69e12e0141648ca9f5ff19f4026f-20210511 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=T8K9jXRssUMgZPyRniiOWW1kVzpxyI3Fg5ZYopeSdmA=; b=Nb33roV1WaFkIZNt5b1qAlZN1TPrti7gyGaF+EsEdiqKwXIGrkMGCuNBTuhRCf4kYaohpx9SZmP8s08RREHruGqIyIgFJLTdRj4dKcctbPLdEGFJYmSy+53eaUdNdj/+evZGscg035PSiPaRVS0riBnlCgPWQT4nc/cFZFm9nSg=; X-UUID: f7aa69e12e0141648ca9f5ff19f4026f-20210511 Received: from mtkcas67.mediatek.inc [(172.29.193.45)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 850390920; Tue, 11 May 2021 19:03:09 -0700 Received: from MTKMBS31N2.mediatek.inc (172.27.4.87) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Tue, 11 May 2021 19:03:07 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS31N2.mediatek.inc (172.27.4.87) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Wed, 12 May 2021 10:02:59 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Wed, 12 May 2021 10:02:58 +0800 Message-ID: <1620784978.25159.4.camel@mhfsdcap03> Subject: Re: [PATCH] usb: core: hub: fix race condition about TRSMRCY of resume From: Chunfeng Yun To: Greg Kroah-Hartman CC: Alan Stern , Matthias Brugger , Thinh Nguyen , "Gustavo A . R . Silva" , Bixuan Cui , Eugeniu Rosca , Oliver Neukum , , , , , Tianping Fang , Eddie Hung , Ikjoon Jang Date: Wed, 12 May 2021 10:02:58 +0800 In-Reply-To: References: <20210511101522.34193-1-chunfeng.yun@mediatek.com> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: BB3D69465F189431B6CB5B8CFC24F1B67DD4789539F36897903386BFD931EB7C2000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210511_190312_362400_848B790F X-CRM114-Status: GOOD ( 15.22 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 2021-05-11 at 13:27 +0200, Greg Kroah-Hartman wrote: > On Tue, May 11, 2021 at 06:15:22PM +0800, Chunfeng Yun wrote: > > This may happen if the port becomes resume status exactly > > when usb_port_resume() gets port status, it still need provide > > a TRSMCRY time before access the device. > > > > Reported-by: Tianping Fang > > Signed-off-by: Chunfeng Yun > > --- > > drivers/usb/core/hub.c | 6 +++--- > > 1 file changed, 3 insertions(+), 3 deletions(-) > > Does this need to go to any older/stable kernels? If so, how far back? The flow is changed by "b01b03f3ad82 USB: add new routine for checking port-resume type", but it will cause conflict with "ad493e5e5805 usb: add usb port auto power off mechanism" > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel