From: Rocco.Yue <rocco.yue@mediatek.com>
To: Frank Wunderlich <frank-w@public-files.de>
Cc: "David S . Miller" <davem@davemloft.net>,
Jakub Kicinski <kuba@kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Masahiro Yamada <masahiroy@kernel.org>,
"Nick Desaulniers" <ndesaulniers@google.com>,
Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
<peterz@infradead.org>,
Tetsuo Handa <penguin-kernel@I-love.SAKURA.ne.jp>,
Peter Enderborg <peter.enderborg@sony.com>,
Thomas Gleixner <tglx@linutronix.de>,
"Anshuman Khandual" <anshuman.khandual@arm.com>,
Vitor Massaru Iha <vitor@massaru.org>,
Sedat Dilek <sedat.dilek@gmail.com>,
Wei Yang <richard.weiyang@gmail.com>,
Cong Wang <cong.wang@bytedance.com>, Di Zhu <zhudi21@huawei.com>,
"Stephen Hemminger" <stephen@networkplumber.org>,
Francis Laniel <laniel_francis@privacyrequired.com>,
Roopa Prabhu <roopa@cumulusnetworks.com>,
Andrii Nakryiko <andrii@kernel.org>,
<linux-kernel@vger.kernel.org>, <netdev@vger.kernel.org>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>, <wsd_upsream@mediatek.com>
Subject: Re: Aw: [PATCH][v2] rtnetlink: add rtnl_lock debug log
Date: Wed, 12 May 2021 16:48:12 +0800 [thread overview]
Message-ID: <1620809292.29442.7.camel@mbjsdccf07> (raw)
In-Reply-To: <trinity-da507ec7-f0ec-4d64-b7fe-1c9d13dbead8-1620759241263@3c-app-gmx-bs62>
On Tue, 2021-05-11 at 20:54 +0200, Frank Wunderlich wrote:
> > Gesendet: Samstag, 08. Mai 2021 um 10:57 Uhr
> > Von: "Rocco Yue" <rocco.yue@mediatek.com>
> > Betreff: [PATCH][v2] rtnetlink: add rtnl_lock debug log
>
> > <6>[ 40.191481][ C6] rtnetlink: -- rtnl_print_btrace start --
> > <6>[ 40.191494][ C6] rtnetlink: RfxSender_4[2206][R] hold rtnl_lock
> > more than 2 sec, start time: 38181400013
> it would be good to have same time-format (seconds.nanosec)
>
> > <6>[ 42.181879][ T2206] rtnetlink: rtnl_lock is held by [2206] from
> > [38181400013] to [42181875177]
> same as above
>
Thanks for your review.
I have also thought about whether it needs to be modified here, and the
intuitive reading here will be a little troubled. It is ok for me to
modify :-)
> > +static void rtnl_relase_btrace(void)
> should this be release_btrace?
>
will fix.
Best Regards
Rocco
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
prev parent reply other threads:[~2021-05-12 9:13 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-08 8:57 [PATCH][v2] rtnetlink: add rtnl_lock debug log Rocco Yue
2021-05-09 9:42 ` Andy Shevchenko
2021-05-10 7:23 ` Rocco.Yue
2021-05-10 12:19 ` Andy Shevchenko
2021-05-11 18:54 ` Aw: " Frank Wunderlich
2021-05-12 8:48 ` Rocco.Yue [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1620809292.29442.7.camel@mbjsdccf07 \
--to=rocco.yue@mediatek.com \
--cc=akpm@linux-foundation.org \
--cc=andrii@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=anshuman.khandual@arm.com \
--cc=cong.wang@bytedance.com \
--cc=davem@davemloft.net \
--cc=frank-w@public-files.de \
--cc=kuba@kernel.org \
--cc=laniel_francis@privacyrequired.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=masahiroy@kernel.org \
--cc=matthias.bgg@gmail.com \
--cc=ndesaulniers@google.com \
--cc=netdev@vger.kernel.org \
--cc=penguin-kernel@I-love.SAKURA.ne.jp \
--cc=peter.enderborg@sony.com \
--cc=peterz@infradead.org \
--cc=richard.weiyang@gmail.com \
--cc=roopa@cumulusnetworks.com \
--cc=sedat.dilek@gmail.com \
--cc=stephen@networkplumber.org \
--cc=tglx@linutronix.de \
--cc=vitor@massaru.org \
--cc=wsd_upsream@mediatek.com \
--cc=zhudi21@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).