From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-14.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,INCLUDES_CR_TRAILER,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7CFC0C43460 for ; Wed, 12 May 2021 20:09:50 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id E732661408 for ; Wed, 12 May 2021 20:09:49 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E732661408 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:Message-Id:Date:Subject:References:In-Reply-To:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=xhFRaLuG6lurZxN7LrZ59VLzqu8xPpokCFKpNHUrO8g=; b=lDo7Og7u8ZTqa0PQfVRgU4wd0i nW8bmFaVrWczf1w2KbNRLInICin7u2M5WikCHjHsP7naAbv2GhEiBBWsvcjR84AZkGU9dYmTDeSbg WKbPgdHdiBBsznPd8EDAo4Zg4hA/p918tW2Lh/kTvq3fdXv/qc212gX4nfA5/BRPSlqrkUoYeR5Wj Ab7YAA2H/YVS05aTEvJu71451h1g0f6avsGZgte4mrFQxBT0nCrfTdVlkZxbeO5FEVWHbUcYgrp6o ofrz3OFLejReglTv186FZLhZ/v+G6fbreXZKGdQMEu+HOqF/Q3ZLN4JjgaUn9VxxWH0LL2NCwkHqP ZzzAQgWg==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1lgv8g-003r30-8h; Wed, 12 May 2021 20:07:27 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7o-003qqf-Vt for linux-arm-kernel@desiato.infradead.org; Wed, 12 May 2021 20:06:35 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Message-Id:Date:Subject:References: In-Reply-To:Cc:To:From:Sender:Reply-To:MIME-Version:Content-Type: Content-Transfer-Encoding:Content-ID:Content-Description; bh=ZT4JNzSVA4XzKpARhAEfHQrvscUrf/xbLw82kFR8CgM=; b=A03Ibuv9X803KiyS13qrmeS1Jb /bJzQqylFwuHfADDjj4ksjWxHejfYiANM4rCyN42LrJdZAYN/Za5HymZAt96/x/VaQlc3g1YX/3NQ Qd2Bs9k/XKay5nhJvWaW0XqW8TWsZhN7bs7rnx61GcY89pxwNIzMNMbnQHKzXDvmHytrubRanJRFi bdJy4Ql5zsaVDrRp7Izh2LCo9kShJMLtR67Adw2n9R/hM0dq+MtcwzH9UwlmNACFup/cudLSpdrOW bH6L1XZmzQI3cbKeLsz0vM/TBKp8vXlpYNV6/IfyNWNDbRkrslXUaoj+E9u6yCMpKQkjn0vRyWhjX s7m8+ZKA==; Received: from mail-oi1-f175.google.com ([209.85.167.175]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1lgv7m-00Aml9-Ai for linux-arm-kernel@lists.infradead.org; Wed, 12 May 2021 20:06:31 +0000 Received: by mail-oi1-f175.google.com with SMTP id n184so23343063oia.12 for ; Wed, 12 May 2021 13:06:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=ZT4JNzSVA4XzKpARhAEfHQrvscUrf/xbLw82kFR8CgM=; b=UVliy0SbK26w9X2ONveuabcjS2rJqCIl2l4RSt5Hy7XQDU6sRJyhzPiAsBahLc4+KM iocohMGYQYGtye9pDDkMvt60WBS8m5doHfRVWNVooZZhwBZ8uN/K7QO4MoydHRM4T7rt K2fxb/pbpWs36JgybRgK+cGK+QyaGI0ErZtvd6x2ToFn2cj/ZxZGpfS/wWZAwpVi+M73 jBZl3QBj86j2HHVvBEZGsPcoVvBD83ghsV2NoE2Yh3OTJlwTMYDAac44EKKT7LKZlRHI dF7rkSH75imX2Ch9gkDoTBBNYUkS1LTYFeD6p/XuoMXPv0bFnSn0mwTtUoaIoRSyCMW7 kh3Q== X-Gm-Message-State: AOAM5312OAWc1r0sB7DBdBvHiW/D/WyhgMQHpz/wjxjK6Txqf7td8Ey7 43zKvWCWfsyoiwX7+j5XqwiKEkIitw== X-Google-Smtp-Source: ABdhPJyx3BiGpIeRJ3UIVk48+wQi6XdGs6DMxX1QJJ+UbedL6x3vdBzMYF8skTJgNZgJb8r3EWzcbQ== X-Received: by 2002:aca:1a05:: with SMTP id a5mr182147oia.26.1620849989353; Wed, 12 May 2021 13:06:29 -0700 (PDT) Received: from robh.at.kernel.org (24-155-109-49.dyn.grandenetworks.net. [24.155.109.49]) by smtp.gmail.com with ESMTPSA id h184sm191133oia.1.2021.05.12.13.06.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 May 2021 13:06:28 -0700 (PDT) Received: (nullmailer pid 204078 invoked by uid 1000); Wed, 12 May 2021 18:35:16 -0000 From: Rob Herring To: Sean Anderson Cc: michal.simek@xilinx.com, linux-pwm@vger.kernel.org, Alvaro Gamez , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20210511191239.774570-1-sean.anderson@seco.com> References: <20210511191239.774570-1-sean.anderson@seco.com> Subject: Re: [PATCH v3 1/2] dt-bindings: pwm: Add Xilinx AXI Timer Date: Wed, 12 May 2021 13:35:16 -0500 Message-Id: <1620844516.484369.204077.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210512_130630_394987_D1D6F284 X-CRM114-Status: GOOD ( 24.30 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 11 May 2021 15:12:37 -0400, Sean Anderson wrote: > This adds a binding for the Xilinx LogiCORE IP AXI Timer. This device is > a "soft" block, so it has many parameters which would not be > configurable in most hardware. This binding is usually automatically > generated by Xilinx's tools, so the names and values of some properties > must be kept as they are. Replacement properties have been provided for > new device trees. > > Because we need to init timer devices so early in boot, the easiest way > to configure things is to use a device tree property. For the moment > this is 'xlnx,pwm', but this could be extended/renamed/etc. in the > future if these is a need for a generic property. > > Signed-off-by: Sean Anderson > --- > How should the clocking situation be documented? For the moment I have > just left clock as optional, but should clock-frequency be documented? > > Changes in v3: > - Mark all boolean-as-int properties as deprecated > - Add xlnx,pwm and xlnx,gen?-active-low properties. > - Make newer replacement properties mutually-exclusive with what they > replace > - Add an example with non-deprecated properties only. > > Changes in v2: > - Use 32-bit addresses for example binding > > .../bindings/pwm/xlnx,axi-timer.yaml | 142 ++++++++++++++++++ > 1 file changed, 142 insertions(+) > create mode 100644 Documentation/devicetree/bindings/pwm/xlnx,axi-timer.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: ./Documentation/devicetree/bindings/pwm/xlnx,axi-timer.yaml:16:9: [warning] wrong indentation: expected 10 but found 8 (indentation) dtschema/dtc warnings/errors: Documentation/devicetree/bindings/pwm/xlnx,axi-timer.example.dts:49.37-57.11: ERROR (duplicate_label): /example-1/timer@800e0000: Duplicate label 'axi_timer_0' on /example-1/timer@800e0000 and /example-0/timer@800e0000 ERROR: Input tree has errors, aborting (use -f to force output) make[1]: *** [scripts/Makefile.lib:380: Documentation/devicetree/bindings/pwm/xlnx,axi-timer.example.dt.yaml] Error 2 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1416: dt_binding_check] Error 2 See https://patchwork.ozlabs.org/patch/1477288 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel