From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY,URIBL_BLOCKED, USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 57A31C47093 for ; Mon, 31 May 2021 03:25:02 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 0C739610C8 for ; Mon, 31 May 2021 03:25:02 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0C739610C8 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=dkdecQJ9m1aytCq0OPT7dynsObAe+PvMspVdDLnvl8Y=; b=xjeTXd5phSTbLO cdtZxSGQCvJIipFWKqT8q1S4rbx4SUDlk4w2vkDqYbdpI9ECXH3KXYTZGZI9AxhqQ1a5zqZrk41W6 Dz81iDgYJ6ERsUyy4UT1bZwTgSNPLWirh8Zdom6gtiG4iy1QwBkvrD6LPvK5bIuBuwxvqkFpvWPox G4JzQ873WZvCqP1SRBI2eO+79A3HpNSvYLOzgAByWl3SRdlATw0RO3GggxGLVqKSCN3c7Y1PRaDHL ueP6O+Dr+1Om7fTfJyfLXxIEieLvia1FKHGrxxFefie91aSsu920PUwAdPwdCHNT69Pmu2OZ1lSDa U/KHUGXseG78AFviCJ1Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnYWC-00AZy4-9Q; Mon, 31 May 2021 03:23:08 +0000 Received: from mailgw01.mediatek.com ([216.200.240.184]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1lnYW8-00AZxO-Mo; Mon, 31 May 2021 03:23:06 +0000 X-UUID: 8ab77a1a93774c7082aa70b3ec67983d-20210530 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=f67WQhmb+df3I9kPJMGHkjRiDrgZqd9/FKeodOjihUg=; b=pUVekmk9GrMcMLiICeDukQeS1+zgPrlk24rn4e8tHd4iF788zOisCWe5Z+yTt859onvO2bZoLDFMStx5C9lZ9O34wZSw1k1fBdLWhrgzryhDcua/edfmKmFuwxIbmLl3l5pAO1vqkKh7YVC15FW2TLe6h25Rpkvn3vcscimTowM=; X-UUID: 8ab77a1a93774c7082aa70b3ec67983d-20210530 Received: from mtkcas68.mediatek.inc [(172.29.94.19)] by mailgw01.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1992632562; Sun, 30 May 2021 20:22:59 -0700 Received: from mtkmbs07n1.mediatek.inc (172.21.101.16) by MTKMBS62N2.mediatek.inc (172.29.193.42) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Sun, 30 May 2021 20:22:57 -0700 Received: from MTKCAS06.mediatek.inc (172.21.101.30) by mtkmbs07n1.mediatek.inc (172.21.101.16) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Mon, 31 May 2021 11:22:56 +0800 Received: from [172.21.77.4] (172.21.77.4) by MTKCAS06.mediatek.inc (172.21.101.73) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Mon, 31 May 2021 11:22:56 +0800 Message-ID: <1622431376.14423.5.camel@mtksdaap41> Subject: Re: [PATCH V8 1/8] PM / devfreq: Add cpu based scaling support to passive_governor From: andrew-sh.cheng To: Chanwoo Choi , Hsin-Yi Wang CC: MyungJoo Ham , Kyungmin Park , Rob Herring , Mark Rutland , Matthias Brugger , "Rafael J. Wysocki" , Viresh Kumar , Nishanth Menon , Stephen Boyd , Liam Girdwood , Mark Brown , , , , , , , Sibi Sankar Date: Mon, 31 May 2021 11:22:56 +0800 In-Reply-To: References: <1616499241-4906-1-git-send-email-andrew-sh.cheng@mediatek.com> <1616499241-4906-2-git-send-email-andrew-sh.cheng@mediatek.com> <233a3bd6-7ab1-5da2-9184-a745eb253d86@samsung.com> <1617177820.15067.1.camel@mtksdaap41> <2ae8604d-0da6-4243-1b92-81b3917d7d48@samsung.com> <1617195800.18432.3.camel@mtksdaap41> <1621995727.29827.1.camel@mtksdaap41> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210530_202304_780565_BC340A25 X-CRM114-Status: GOOD ( 41.56 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 2021-05-26 at 12:08 +0900, Chanwoo Choi wrote: > Hi, > On 5/26/21 11:22 AM, andrew-sh.cheng wrote: > > On Thu, 2021-04-08 at 11:47 +0900, Chanwoo Choi wrote: > >> On 4/1/21 9:16 AM, Chanwoo Choi wrote: > >>> On 3/31/21 10:03 PM, andrew-sh.cheng wrote: > >>>> On Wed, 2021-03-31 at 17:35 +0900, Chanwoo Choi wrote: > >>>>> On 3/31/21 5:27 PM, Chanwoo Choi wrote: > >>>>>> Hi, > >>>>>> > >>>>>> On 3/31/21 5:03 PM, andrew-sh.cheng wrote: > >>>>>>> On Thu, 2021-03-25 at 17:14 +0900, Chanwoo Choi wrote: > >>>>>>>> Hi, > >>>>>>>> > >>>>>>>> You are missing to add these patches to linux-pm mailing list. > >>>>>>>> Need to send them to linu-pm ML. > >>>>>>>> > >>>>>>>> Also, before received this series, I tried to clean-up these patches > >>>>>>>> on testing branch[1]. So that I add my comment with my clean-up case. > >>>>>>>> [1] https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing-passive-gov__;!!CTRNKA9wMg0ARbw!zIrzeDp9vPnm1_SDzVPuzqdHn3zWie9DnfBXaA-j9-CSrVc6aR9_rJQQiw81_CgAPh9XRRs$ > >>>>>>>> > >>>>>>>> And 'Saravana Kannan ' is wrong email address. > >>>>>>>> Please update the email or drop this email. > >>>>>>> > >>>>>>> Hi Chanwoo, > >>>>>>> > >>>>>>> Thank you for the advices. > >>>>>>> I will resend patch v9 (add to linux-pm ML), remove this patch, and note > >>>>>>> that my patch set base on > >>>>>>> https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing-passive-gov__;!!CTRNKA9wMg0ARbw!yUlsuxrL5PcbF7o6A9DlCfvoA6w8V8VXKjYIybYyiJg3D0HM-lI2xRuxLUV6b3UJ8WFhg_g$ > >>>>>> > >>>>>> I has not yet test this patch[1] on devfreq-testing-passive-gov branch. > >>>>>> So that if possible, I'd like you to test your patches with this patch[1] > >>>>>> and then if there is no problem, could you send the next patches with patch[1]? > >>>>>> > >>>>>> [1]https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/commit/?h=devfreq-testing-passive-gov&id=39c80d11a8f42dd63ecea1e0df595a0ceb83b454__;!!CTRNKA9wMg0ARbw!yUlsuxrL5PcbF7o6A9DlCfvoA6w8V8VXKjYIybYyiJg3D0HM-lI2xRuxLUV6b3UJR2cQqZs$ > >>>>> > >>>>> > >>>>> Sorry for the confusion. I make the devfreq-testing-passive-gov[1] > >>>>> branch based on latest devfreq-next branch. > >>>>> [1] https://urldefense.com/v3/__https://git.kernel.org/pub/scm/linux/kernel/git/chanwoo/linux.git/log/?h=devfreq-testing-passive-gov__;!!CTRNKA9wMg0ARbw!yUlsuxrL5PcbF7o6A9DlCfvoA6w8V8VXKjYIybYyiJg3D0HM-lI2xRuxLUV6b3UJ8WFhg_g$ > >>>>> > >>>>> First of all, if possible, I want to test them[1] with your patches in this series. > >>>>> And then if there are no any problem, please let me know. After confirmed from you, > >>>>> I'll send the patches of devfreq-testing-passive-gov[1] branch. > >>>>> How about that? > >>>>> > >>>> Hi Chanwoo~ > >>>> > >>>> We will use this on Google Chrome project. > >>>> Google Hsin-Yi has test your patch + my patch set v8 [2~8] > >>>> > >>>> make sure cci devfreqs runs with cpufreq. > >>>> suspend resume > >>>> speedometer2 benchmark > >>>> It is okay. > >>>> > >>>> Please send the patches of devfreq-testing-passive-gov[1] branch. > >>>> > >>>> I will send patch v9 base on yours latter. > >>> > >>> Thanks for your test. I'll send the patches today. > >> > >> I'm sorry for delay because when I tested the patches > >> for devfreq parent type on Odroid-xu3, there are some problem > >> related to lazy linking of OPP. So I'm trying to analyze them. > >> Unfortunately, we need to postpone these patches to next linux > >> version. > >> > > Hi Chanwoo Choi~ > > > > It is said that you are busy on another task recently. > > May I know your plan on this patch? > > Thank you. > > Sorry for late work. I have a question. > When I tested exynos-bus.c with adding the 'required-opp' property > on odroid-xu3 board. I got some fail about > > When calling _set_required_opps(), always _set_required_opp() returns > -EBUSY error because of following lazy linking case[1]. > > [1] https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.13-rc3/source/drivers/opp/core.c*L896__;Iw!!CTRNKA9wMg0ARbw!3eNxwDZRy-Ev5BHGxT-BxCz4qrNy0NZohQuBGW36krkwOkl_WX8yBmxlqSk9hxp_kxspMJI$ > > /* required-opps not fully initialized yet */ > if (lazy_linking_pending(opp_table)) > return -EBUSY; > > > For calling dev_pm_opp_of_add_table(), lazy_link_required_opp_table() function > will be called. But, there is constraint[2]. If is_genpd of opp_table is false, > driver/opp/of.c cannot resolve the lazy linking issue. > > [2] https://urldefense.com/v3/__https://elixir.bootlin.com/linux/v5.13-rc3/source/drivers/opp/of.c*L386__;Iw!!CTRNKA9wMg0ARbw!3eNxwDZRy-Ev5BHGxT-BxCz4qrNy0NZohQuBGW36krkwOkl_WX8yBmxlqSk9hxp_QFUVY9E$ > > /* Link required OPPs for all OPPs of the newly added OPP table */ > static void lazy_link_required_opp_table(struct opp_table *new_table) > { > struct opp_table *opp_table, *temp, **required_opp_tables; > struct device_node *required_np, *opp_np, *required_table_np; > struct dev_pm_opp *opp; > int i, ret; > > /* > * We only support genpd's OPPs in the "required-opps" for now, > * as we don't know much about other cases. > */ > if (!new_table->is_genpd) > return; > > Even if this case, there are no problem on your test case? > Hi Chanwoo~ Sorry for late reply. Yes, we meet similar issue. Google member Hsin-Yi had helped deal with this issue on Chrome project. Patch segment: @ /drivers/opp/of.c /* Link required OPPs for all OPPs of the newly added OPP table */ static void lazy_link_required_opp_table(struct opp_table *new_table) { struct opp_table *opp_table, *temp, **required_opp_tables; struct device_node *required_np, *opp_np, *required_table_np; struct dev_pm_opp *opp; int i, ret; + /* + * We only support genpd's OPPs in the "required-opps" for now, + * as we don't know much about other cases. + */ + if (!new_table->is_genpd) + return; Hsin-Yi replied this issue in the discussion list in the original lazy link thread: https://patchwork.kernel.org/project/linux-pm/patch/20190717222340.137578-4-saravanak@google.com/#23932203 Loop Hsin-YI here. You can discuss with her if needing more detail. Thank you both. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel