Re: [PATCH V3 2/3] dt-bindings: i2c: add attribute default-timing-adjust

Rob Herring
2021-07-12T20:55:36Z

On Mon, Jun 21, 2021 at 06:39:44PM +0800, kewei.xu@mediatek.com wrote:
> From: Kewei Xu <kewei.xu@mediatek.com>
>
> Add attribute default-timing-adjust for DT-binding document.
>
> Fixes: be5ce0e97cc7 ("i2c: mediatek: Add i2c ac-timing adjust support")

You want to fix a kernel change with a DT change? That's not a
compatible change (and I guess neither was the kernel change). Sounds
like the above commit should be reverted and rethink how to add a new
feature...

> Signed-off-by: Kewei Xu <kewei.xu@mediatek.com>
> ---
> Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> index 7c4915bc..7b80a11 100644
> --- a/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> +++ b/Documentation/devicetree/bindings/i2c/i2c-mt65xx.txt
> @@ -33,6 +33,8 @@ Optional properties:
> - mediatek,have-pmic: platform can control i2c form special pmic side.
> Only mt6589 and mt8135 support this feature.
> - mediatek,use-push-pull: IO config use push-pull mode.
> + - mediatek,default-timing-adjust: use default timing calculation, no timing
> + adjustment.
>
> Example:
>
> --
> 1.9.1
>
>