From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.7 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY, URIBL_BLOCKED,USER_AGENT_SANE_2 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 48E07C63793 for ; Thu, 22 Jul 2021 12:57:32 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 07D176137D for ; Thu, 22 Jul 2021 12:57:32 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 07D176137D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mediatek.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Date:CC:To:From:Subject:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=v41glqZ1+P0pSM75YzqX7uYK+cjhqmKIjYXtg6m51QE=; b=yPVFNllo14Wo0V NpyLrZ1O6tBpbiotfwKqTEnXduWWlJiYjKCGP2jR5JqIvnDQAoUSVKRWy83jBz6TYqtf+w54gUFnP egTJX+znx+cm8v/nrso79fuBsmY7RVk1QaQV/1fYBpUZlY1wgG0vc8ja0Dc1boxo2vpDJDYtCH4Be CMSskbc/M/qWvLHsH+nirw5L+RacoMVUM7SiBbf1WarP/iHhZyjRW59w58rPyaM/Dyfxrm2TSzSq4 /v7U+d4qA9i9AiXIfgNxSsKHIK7J9C8C+tINUUfWDLswQaGXF1f8DYkVmOp4pM1VO3PrXIJypYt7F YkDR0f/nGEHHjBzdqaXQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6YDF-001YIm-7u; Thu, 22 Jul 2021 12:54:08 +0000 Received: from mailgw02.mediatek.com ([216.200.240.185]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1m6XGB-001PY4-4H; Thu, 22 Jul 2021 11:53:05 +0000 X-UUID: 77b2cedc863845e78efca3e798f3ee9c-20210722 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=mediatek.com; s=dk; h=Content-Transfer-Encoding:MIME-Version:Content-Type:References:In-Reply-To:Date:CC:To:From:Subject:Message-ID; bh=HI+e/xvoUOH4i2trhO8dcOHc+LQTOalKpiniQMNVN5I=; b=jB2RGs9DabERlVdkoje6zFj040j2iY7Xjhrw91klEjI9h3I+neZxnAVdRE9QecDFv0i7oD+wvac41HTeba9p5V5hpcFy6itdDIKv3p1DGobWh4KEDOtvFjYmtUxGXNQGPA4SVDph8hKC9hwoudRv8LqYw39sfNKA+fZnJoxz7YQ=; X-UUID: 77b2cedc863845e78efca3e798f3ee9c-20210722 Received: from mtkcas66.mediatek.inc [(172.29.193.44)] by mailgw02.mediatek.com (envelope-from ) (musrelay.mediatek.com ESMTP with TLSv1.2 ECDHE-RSA-AES256-SHA384 256/256) with ESMTP id 1783484179; Thu, 22 Jul 2021 04:52:59 -0700 Received: from MTKMBS32N1.mediatek.inc (172.27.4.71) by MTKMBS62N1.mediatek.inc (172.29.193.41) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 22 Jul 2021 04:52:58 -0700 Received: from MTKCAS36.mediatek.inc (172.27.4.186) by MTKMBS32N1.mediatek.inc (172.27.4.71) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 22 Jul 2021 19:52:51 +0800 Received: from [10.17.3.153] (10.17.3.153) by MTKCAS36.mediatek.inc (172.27.4.170) with Microsoft SMTP Server id 15.0.1497.2 via Frontend Transport; Thu, 22 Jul 2021 19:52:50 +0800 Message-ID: <1626954770.29611.55.camel@mhfsdcap03> Subject: Re: [PATCH] uart: mediatek: fix memory corruption issue From: zhiyong tao To: Greg KH CC: , , , , , , , , , , , , , , , Date: Thu, 22 Jul 2021 19:52:50 +0800 In-Reply-To: References: <20210710090103.2643-1-zhiyong.tao@mediatek.com> <20210710090103.2643-2-zhiyong.tao@mediatek.com> <1626948212.29611.47.camel@mhfsdcap03> X-Mailer: Evolution 3.10.4-0ubuntu2 MIME-Version: 1.0 X-TM-SNTS-SMTP: EA5696D511CFA7729DB6F188DE337549E8F4B85D9D40B97435D180AAF18AFE812000:8 X-MTK: N X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210722_045303_380569_716C9B6C X-CRM114-Status: GOOD ( 45.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 2021-07-22 at 12:12 +0200, Greg KH wrote: > On Thu, Jul 22, 2021 at 06:03:32PM +0800, zhiyong tao wrote: > > On Wed, 2021-07-21 at 12:46 +0200, Greg KH wrote: > > > On Sat, Jul 10, 2021 at 05:01:03PM +0800, Zhiyong Tao wrote: > > > > This patch is used to fix memory corruption issue when rx power off. > > > > 1. add spin lock in mtk8250_dma_rx_complete function in APDMA mode. > > > > > > What does a lock protect from? Please be explicit and detailed. > > > > ==> Hi Gregkh, > > > > when uart is used as a communication port with external device(GPS). > > when external device(GPS) power off, the power of rx pin is also from > > 1.8v to 0v. Even if there is not any data in rx. But uart rx pin can > > capture the data "0". > > That sounds like a broken hardware design. > > > If uart don't receive any data in specified cycle, uart will generates > > BI(Break interrupt) interrupt. > > If external device(GPS) power off, we found that BI interrupt appeared > > continuously and very frequently. > > When uart interrupt type is BI, uart IRQ handler(8250 framwork > > API:serial8250_handle_irq) will push data to tty buffer. > > The code path: > > https://elixir.bootlin.com/linux/latest/source/drivers/tty/serial/8250/8250_port.c#L1917 > > > > mtk8250_dma_rx_complete is a task of mtk_uart_apdma_rx_handler. > > mtk8250_dma_rx_complete priority is lower than uart irq > > handler(serial8250_handle_irq). > > if we are in process of mtk8250_dma_rx_complete, uart appear BI > > interrupt:1)serial8250_handle_irq will priority execution.2)it may cause > > write tty buffer conflict in mtk8250_dma_rx_complete. > > So the spin lock protect the rx receive data process is not break. > > Then put something like this in the changelog text, as it is, it is not > descriptive at all. ==> Thanks for your suggestion. we will add it in changelog text([PATCH 0/1] Mediatek uart patch) in v1. > > > > > 2. add processing mechanism which count value is 0 > > > > > > What does this do? And why is it needed? > > > > ==> when count value is 0, we don't need push data to tty buffer. > > so we add it. > > But that does not actually do anything different from what it does > today. And it has nothing to do with the lock, so this should be 2 > different patches, right? ==> yes, it has nothing to do with the lock. we will separate it in v1. > > > > > Signed-off-by: Zhiyong Tao > > > > > > What commit does this fix? Does this need to go to stable kernel trees? > > > If so, how far back? > > > > > > > --- > > > > drivers/tty/serial/8250/8250_mtk.c | 15 +++++++++++---- > > > > 1 file changed, 11 insertions(+), 4 deletions(-) > > > > > > > > diff --git a/drivers/tty/serial/8250/8250_mtk.c b/drivers/tty/serial/8250/8250_mtk.c > > > > index f7d3023f860f..09f7d2166315 100644 > > > > --- a/drivers/tty/serial/8250/8250_mtk.c > > > > +++ b/drivers/tty/serial/8250/8250_mtk.c > > > > @@ -91,12 +91,15 @@ static void mtk8250_dma_rx_complete(void *param) > > > > struct mtk8250_data *data = up->port.private_data; > > > > struct tty_port *tty_port = &up->port.state->port; > > > > struct dma_tx_state state; > > > > - int copied, total, cnt; > > > > + unsigned int copied, total, cnt; > > > > unsigned char *ptr; > > > > + unsigned long flags; > > > > > > > > if (data->rx_status == DMA_RX_SHUTDOWN) > > > > return; > > > > > > > > + spin_lock_irqsave(&up->port.lock, flags); > > > > + > > > > dmaengine_tx_status(dma->rxchan, dma->rx_cookie, &state); > > > > total = dma->rx_size - state.residue; > > > > cnt = total; > > > > @@ -104,9 +107,11 @@ static void mtk8250_dma_rx_complete(void *param) > > > > if ((data->rx_pos + cnt) > dma->rx_size) > > > > cnt = dma->rx_size - data->rx_pos; > > > > > > > > - ptr = (unsigned char *)(data->rx_pos + dma->rx_buf); > > > > - copied = tty_insert_flip_string(tty_port, ptr, cnt); > > > > - data->rx_pos += cnt; > > > > + if (cnt != 0) { > > > > > > Why does cnt matter here? If cnt is 0, the code above should not do > > > anything at all, right? > > > > ==> yes, if the counter value is 0, we don't need push data to the tty > > buffer. > > But this does not change the logic as if cnt is 0, nothing gets pushed > with the current code either, right? ==> yes, it is. > > > > Or if it does, should we change tty_insert_flip_string() to always check > > > for cnt != 0 before it does the first loop? Hm, it looks like it will > > > abort if cnt is 0, so what is this change really doing? Why do you need > > > it? What is it "fixing"? > > > > > ==> It is not fix anything, we just think if count value is 0, we don't > > need do anything. > > Then make it a separate patch, independant from the lock patch, and we > can discuss it there. Do NOT have patches do multiple things. ==> I will make it a separate patch in v1. Thanks. > > thanks, > > greg k-h _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel