From: Qii Wang <qii.wang@mediatek.com>
To: Wolfram Sang <wsa@kernel.org>
Cc: Sergey Shtylyov <s.shtylyov@omp.ru>, <linux-i2c@vger.kernel.org>,
Matthias Brugger <matthias.bgg@gmail.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-mediatek@lists.infradead.org>
Subject: Re: [PATCH v2 2/5] i2c: mt65xx: fix IRQ check
Date: Fri, 20 Aug 2021 09:46:21 +0800 [thread overview]
Message-ID: <1629423981.19334.3.camel@mhfsdcap03> (raw)
In-Reply-To: <YRwXZVxORTpddj2k@kunai>
On Tue, 2021-08-17 at 22:09 +0200, Wolfram Sang wrote:
> On Sun, Jul 04, 2021 at 05:38:45PM +0300, Sergey Shtylyov wrote:
> > Iff platform_get_irq() returns 0, the driver's probe() method will return 0
> > early (as if the method's call was successful). Let's consider IRQ0 valid
> > for simplicity -- devm_request_irq() can always override that decision...
> >
> > Fixes: ce38815d39ea ("I2C: mediatek: Add driver for MediaTek I2C controller")
> > Signed-off-by: Sergey Shtylyov <s.shtylyov@omprussia.ru>
>
> Qii Wang, do you like this patch?
>
It is ok.
Reviewed-by: Qii Wang <qii.wang@mediatek.com>
Thanks
> >
> > ---
> > drivers/i2c/busses/i2c-mt65xx.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > Index: linux/drivers/i2c/busses/i2c-mt65xx.c
> > ===================================================================
> > --- linux.orig/drivers/i2c/busses/i2c-mt65xx.c
> > +++ linux/drivers/i2c/busses/i2c-mt65xx.c
> > @@ -1211,7 +1211,7 @@ static int mtk_i2c_probe(struct platform
> > return PTR_ERR(i2c->pdmabase);
> >
> > irq = platform_get_irq(pdev, 0);
> > - if (irq <= 0)
> > + if (irq < 0)
> > return irq;
> >
> > init_completion(&i2c->msg_complete);
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2021-08-20 1:50 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-04 14:32 [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
2021-07-04 14:38 ` [PATCH v2 2/5] i2c: mt65xx: fix IRQ check Sergey Shtylyov
2021-08-17 20:09 ` Wolfram Sang
2021-08-20 1:46 ` Qii Wang [this message]
2021-08-25 21:00 ` Wolfram Sang
2021-07-04 14:45 ` [PATCH v2 4/5] i2c: s3c2410: " Sergey Shtylyov
2021-07-05 7:46 ` Krzysztof Kozlowski
2021-08-17 20:08 ` Wolfram Sang
2021-08-11 20:12 ` [PATCH v2 0/5] Correctly handle plaform_get_irq()'s result in the i2C drivers Sergey Shtylyov
2021-08-11 20:14 ` Sergey Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1629423981.19334.3.camel@mhfsdcap03 \
--to=qii.wang@mediatek.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-mediatek@lists.infradead.org \
--cc=matthias.bgg@gmail.com \
--cc=s.shtylyov@omp.ru \
--cc=wsa@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).