[PATCH] tty: serial: msm_serial: Use DT aliases

Stephen Boyd
2014-10-23T00:33:01Z

We rely on probe order of this driver to determine the line number for
the uart port. This makes it impossible to know the line number
when these devices are populated via DT. Use the DT alias
mechanism to assign the line based on the aliases node.

Signed-off-by: Stephen Boyd <sboyd@codeaurora.org>
---
drivers/tty/serial/msm_serial.c | 13 +++++++++----
1 file changed, 9 insertions(+), 4 deletions(-)

diff --git a/drivers/tty/serial/msm_serial.c b/drivers/tty/serial/msm_serial.c
index 0da0b5474e98..4aba62d00a3f 100644
--- a/drivers/tty/serial/msm_serial.c
+++ b/drivers/tty/serial/msm_serial.c
@@ -1005,17 +1005,22 @@ static int msm_serial_probe(struct platform_device *pdev)
struct resource *resource;
struct uart_port *port;
const struct of_device_id *id;
- int irq;
+ int irq, line;

if (pdev->id == -1)
pdev->id = atomic_inc_return(&msm_uart_next_id) - 1;

- if (unlikely(pdev->id < 0 || pdev->id >= UART_NR))
+ if (pdev->dev.of_node)
+ line = of_alias_get_id(pdev->dev.of_node, "serial");
+ else
+ line = pdev->id;
+
+ if (unlikely(line < 0 || line >= UART_NR))
return -ENXIO;

- printk(KERN_INFO "msm_serial: detected port #%d\n", pdev->id);
+ printk(KERN_INFO "msm_serial: detected port #%d\n", line);

- port = get_port_from_line(pdev->id);
+ port = get_port_from_line(line);
port->dev = &pdev->dev;
msm_port = UART_TO_MSM(port);

--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project