From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4D43DC433EF for ; Wed, 29 Sep 2021 13:32:41 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 1B80E6137A for ; Wed, 29 Sep 2021 13:32:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 1B80E6137A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=163.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject:Cc:To :From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=WP1ybS/Uui9P0z3iY2lIuGQD+wY1RKdnzhF+0q5SqHQ=; b=3YN1eiBrOLFV0q 56xWeVpNuy53AyFTnPvZ2JEOo64inP6QvQ+9l61oz8YdsV8Hwu33ZUOj2RuU/q6UFXX7XNNAuOmR1 YPySBIyAtblYTDMdxSHm96FiXwKYVUSbI7h5i5NggtO5de4aenQKH+lOFs9Zip5Uuc1r4xrf08EeW DbIMtH8gQvOqftyJ2kLLl5+DL5Cv+L4iS71iqe/k8op9JR5HWz+M9u+Hl7urSSKDd9hxtxBzC+puR MwSDy2W8R4muxB4SH+lARMGjLOvuTRcX6BhgKCr5zK8uM5VD+ErX0XyhX+Qu9oVfn5eW1jIIxgoOr 3krD7JeAjn6n3hg9nKig==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVZfn-00B8ye-2M; Wed, 29 Sep 2021 13:30:59 +0000 Received: from m12-11.163.com ([220.181.12.11]) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mVZfj-00B8xK-On for linux-arm-kernel@lists.infradead.org; Wed, 29 Sep 2021 13:30:57 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=163.com; s=s110527; h=From:Subject:Date:Message-Id; bh=SEa26DOreuk50DuLo7 /JXFySenvdL7ez8pgadwWmGF4=; b=anhrGf5OrD1tRtp+tJeZXcVRcYZV+RmSNW MWqzbEXgcl5uHqwQ+38+HX8I/9WiCyD0wVoF2xd4g2EqVF4TdcFSxn+9dBnbonLz TbcBLMABajtVMdG3FaG8rO+ZgroDOsflmRmOs0PlTip6cYcs7o286RHVJYHEO1E6 2LGF/keFc= Received: from localhost.localdomain (unknown [171.221.149.2]) by smtp7 (Coremail) with SMTP id C8CowACHfeJ9alRhZSVNzQ--.55562S2; Wed, 29 Sep 2021 21:30:44 +0800 (CST) From: Chen Lin To: catalin.marinas@arm.com Cc: will@kernel.org, mark.rutland@arm.com, joey.gouly@arm.com, maz@kernel.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, Chen Lin Subject: [PATCH] arm64: traps: add dump instr before BUG in kernel Date: Wed, 29 Sep 2021 21:29:46 +0800 Message-Id: <1632922186-3116-1-git-send-email-chen45464546@163.com> X-Mailer: git-send-email 1.7.9.5 X-CM-TRANSID: C8CowACHfeJ9alRhZSVNzQ--.55562S2 X-Coremail-Antispam: 1Uf129KBjvdXoWrurWfur4DGrW5tFyxGr1xKrg_yoWfXrX_KF yS9r48ur1FyF1IvFyjk3yvvFyIkrW8JFW09w10vFZ5Gas8Xrs8Aw45JF909rn5WryrKrnx XrnrArnIv3W3JjkaLaAFLSUrUUUUUb8apTn2vfkv8UJUUUU8Yxn0WfASr-VFAUDa7-sFnT 9fnUUvcSsGvfC2KfnxnUUI43ZEXa7IUeJrc7UUUUU== X-Originating-IP: [171.221.149.2] X-CM-SenderInfo: hfkh0kqvuwkkiuw6il2tof0z/1tbiXQQdnlWBk5vf8wAAsq X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210929_063056_245629_FDA496F2 X-CRM114-Status: GOOD ( 10.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Chen Lin we should dump the real instructions before BUG in kernel mode, and compare this to the instructions from objdump. Signed-off-by: Chen Lin --- arch/arm64/kernel/traps.c | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/arch/arm64/kernel/traps.c b/arch/arm64/kernel/traps.c index b03e383..621a9dd 100644 --- a/arch/arm64/kernel/traps.c +++ b/arch/arm64/kernel/traps.c @@ -495,7 +495,12 @@ void do_undefinstr(struct pt_regs *regs) if (call_undef_hook(regs) == 0) return; - BUG_ON(!user_mode(regs)); + if (!user_mode(regs)) { + pr_emerg("Undef instruction in kernel, dump instr:"); + dump_kernel_instr(KERN_EMERG, regs); + BUG(); + } + force_signal_inject(SIGILL, ILL_ILLOPC, regs->pc, 0); } NOKPROBE_SYMBOL(do_undefinstr); -- 1.7.9.5 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel