From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 36B55C433EF for ; Fri, 8 Oct 2021 19:51:10 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id F0B2061037 for ; Fri, 8 Oct 2021 19:51:09 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org F0B2061037 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:Message-Id:Date:Subject:References:In-Reply-To:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=+ieV4Xyx74zVTVkCkuaLm61X7U1kVY5m33MxpjBCmYE=; b=bg/7Hc7CK5Oo/u/RhPQFFusuk7 4UN3kmLG16tPpY1v8Tn6/tQF8Shq2m6hNDpE8l0Wa5K1ZNvsXiS+PTS2IWU4nCA880OuGi25cCabj kfmKf04bJzlT85GVfuEGELjaTLIdo4yKyg/OXsafHQUY71nWxTcFwgIV5XJbP3aouNQ0n6esbfcHP O6sLnTSKQoD7224wMyMDEDIDCx9N3p1QoTeyK0+i6j0ZlnOLtGNF91epNo44A0LQ0whVJvvYvVHLK DGP2G4AE8yxo5kRV3vCklICvaAVLQ7ZKjRBhQZ6z01Rd+dZP/kSM72FZpMLXPB/P8Qued7bRnVoc0 OZPU8FKw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYvre-0040XS-LH; Fri, 08 Oct 2021 19:49:06 +0000 Received: from mail-oi1-f181.google.com ([209.85.167.181]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mYvra-0040Wp-VF for linux-arm-kernel@lists.infradead.org; Fri, 08 Oct 2021 19:49:04 +0000 Received: by mail-oi1-f181.google.com with SMTP id a3so15119216oid.6 for ; Fri, 08 Oct 2021 12:49:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=iYW5a/WfjqZkA3dxEOCsXG2hPPwjpbSd/NNDb4AaYG8=; b=eEPWa1Z34B5xL9b93ZKvNPVQThWLry2Q8oQxOk251R4ZASO9p8lXVjaCz3i9qa3w7Z A0qv0K53CwrQdQN1GwI821ohPAVbx1qXIy4tqq1qByq8oqWTrRBIbRkg5yzt3sARNuyw 5tvmSMXGb4lVMWPxgCVAErfIJwD7nyIxZOd6taXIG8OkyF1kY4kPCpV7+Z9Z42u7Sfpc R3b23XsYP9kA5bgyER0oMr9/26C+nIz+qBmUi9EoHcliyjnNDuI1Dm87WdWimM/yGbqL 6IaTuJmtijjmV7wcU4GEIQqfeTL9aOrR7jZnwNpu9eUQ7dVAzlN06GqfnrTEUBrHnlLa KHlQ== X-Gm-Message-State: AOAM530Pf3BGcbQGj7e72QlJEKkN8sfcytvC0ZWMeV4LbuXgchVOBQ+C NcGSMyMwmlPmyiULic+4PA== X-Google-Smtp-Source: ABdhPJzKLAI3g8h5KEzLDKuLq5LOxSjmRGXYrXDykrvA9wcW8RE4moFjl93x90z7RbyZz6FBFLQ5fA== X-Received: by 2002:aca:aa42:: with SMTP id t63mr769693oie.118.1633722542073; Fri, 08 Oct 2021 12:49:02 -0700 (PDT) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id i24sm67851oie.42.2021.10.08.12.49.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 Oct 2021 12:49:01 -0700 (PDT) Received: (nullmailer pid 3211953 invoked by uid 1000); Fri, 08 Oct 2021 19:48:56 -0000 From: Rob Herring To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: Linus Walleij , devicetree@vger.kernel.org, Ray Jui , bcm-kernel-feedback-list@broadcom.com, Scott Branden , =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , linux-gpio@vger.kernel.org, linux-arm-kernel@lists.infradead.org In-Reply-To: <20211008153939.19685-1-zajec5@gmail.com> References: <20211008153939.19685-1-zajec5@gmail.com> Subject: Re: [PATCH V2 linux-pinctrl 1/2] Revert "dt-bindings: pinctrl: bcm4708-pinmux: rework binding to use syscon" Date: Fri, 08 Oct 2021 14:48:56 -0500 Message-Id: <1633722536.868012.3211952.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211008_124903_030036_D2C7FA20 X-CRM114-Status: GOOD ( 19.25 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1286143861349318685==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============1286143861349318685== Content-Type: text/plain On Fri, 08 Oct 2021 17:39:38 +0200, Rafał Miłecki wrote: > From: Rafał Miłecki > > This reverts commit 2ae80900f239484069569380e1fc4340fd6e0089. > > My rework was unneeded & wrong. It replaced a clear & correct "reg" > property usage with a custom "offset" one. > > Back then I didn't understand how to properly handle CRU block binding. > I heard / read about syscon and tried to use it in a totally invalid > way. That change also missed Rob's review (obviously). > > Northstar's pin controller is a simple consistent hardware block that > can be cleanly mapped using a 0x24 long reg space. > > Since the rework commit there wasn't any follow up modifying in-kernel > DTS files to use the new binding. Broadcom also isn't known to use that > bugged binding. There is close to zero chance this revert may actually > cause problems / regressions. > > This commit is a simple revert. Example binding may (should) be updated > / cleaned up but that can be handled separately. > > Signed-off-by: Rafał Miłecki > --- > V2: Update brcm,cru.yaml to avoid new yamllint warnings/errors > --- > .../devicetree/bindings/mfd/brcm,cru.yaml | 11 +++++---- > .../bindings/pinctrl/brcm,ns-pinmux.yaml | 23 +++++++++++-------- > 2 files changed, 19 insertions(+), 15 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.example.dt.yaml: cru@1800c100: $nodename:0: 'cru@1800c100' does not match '^([a-z][a-z0-9\\-]+-bus|bus|soc|axi|ahb|apb)(@[0-9a-f]+)?$' From schema: /usr/local/lib/python3.8/dist-packages/dtschema/schemas/simple-bus.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1538413 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. --===============1286143861349318685== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============1286143861349318685==--