From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 104D3C433EF for ; Fri, 10 Dec 2021 14:04:31 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: MIME-Version:List-Subscribe:List-Help:List-Post:List-Archive:List-Unsubscribe :List-Id:Message-Id:Date:Subject:References:In-Reply-To:Cc:To:From:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ooWkMwsZbZHpKSwI1/Q+sUO+QV1jrD5Cob9r1emXh6Y=; b=vdPeL3JMLsefRAr15pChognRVg 1I7nVtiK+IQUTxehDdfM7asX6EZDHZLlK+XkC1EJfD6fUZVPnEdRbW6beeqLK8ZCzBtbyDwBfO1rK Y9M1dcDw6kkMUWfEyj8wI3d0TjSDli4zYBjrsG2oF9WtsUhgpaPM6/WKnuciDSzF8wU0NHDfiPhRG uer4VgSdo/B0wg9yp+gaQHPlnEQYvFx3hfUT35xoNDyy7HDBfLtkYm6R1qWgu6ZHmCni6r/FyFw9w 1PQeOzu/WoPUquK0xi0v/443QB0/w5QURa54bn/0FL93FLDjs7HxTpl+/8Fv/45M/OY8Vqgzqdatl 4dw4xHUQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvgUN-0027Bw-Pk; Fri, 10 Dec 2021 14:03:07 +0000 Received: from mail-oi1-f179.google.com ([209.85.167.179]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mvgUJ-0027Ai-2C for linux-arm-kernel@lists.infradead.org; Fri, 10 Dec 2021 14:03:04 +0000 Received: by mail-oi1-f179.google.com with SMTP id m6so13370836oim.2 for ; Fri, 10 Dec 2021 06:03:01 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=yERcZG0LYZMGlslnxe6v1+iJXRzLWJCmIMN6Bxt3k18=; b=jgySRa/oampWeBpXY1Vpc1x8PybWgXS5B+sdKLchiyRPHhkGxNSE63TblRGG6KqRBO pS778zMctsdxdXBkpDblU/sEwyFPBhwx9t7tntDjU5Avi0kLnVUkqLpxccTg6OmDERcF bwM9EBQbBVA9hVfx2ji224g6sDX/gO4wQEfYpsSqE90gQcqof1PLhP6bMHoVtUvgRzw6 3iqQmQB7AD+o9XVYPMjhQXltrYBaUyMQN5HCM6APqH45dcEuP7rHjycCNgAT9muOKgay uCUjUdAS8ZT29HDGo8Vt9K6v8Df5/BqPaZKO5PI0XLCmgEwzleIHDdhIrQPFNjFWSyGp gJ9Q== X-Gm-Message-State: AOAM530Hnqe3GU1u0p/ZZyo5o110gNlVlq493w2Z8Dsq46Kd4s45s3rB wkJQoKpyKKMy5ekM/H8tZg== X-Google-Smtp-Source: ABdhPJwza5Xh7FjwPl3bUzlD3XI4unHXX0Rpc+dEnENgFFOxb0gtCfEVpj1oA58lBte6xxH8FCh5RQ== X-Received: by 2002:aca:ab84:: with SMTP id u126mr12182021oie.41.1639144979805; Fri, 10 Dec 2021 06:02:59 -0800 (PST) Received: from robh.at.kernel.org (66-90-148-213.dyn.grandenetworks.net. [66.90.148.213]) by smtp.gmail.com with ESMTPSA id a5sm532423otd.74.2021.12.10.06.02.58 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Dec 2021 06:02:59 -0800 (PST) Received: (nullmailer pid 1252253 invoked by uid 1000); Fri, 10 Dec 2021 14:02:56 -0000 From: Rob Herring To: =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= Cc: linux-gpio@vger.kernel.org, =?utf-8?b?UmFmYcWCIE1pxYJlY2tp?= , Rob Herring , Linus Walleij , Florian Fainelli , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Tony Lindgren , bcm-kernel-feedback-list@broadcom.com, Andy Shevchenko In-Reply-To: <20211210114222.26581-3-zajec5@gmail.com> References: <20211210114222.26581-1-zajec5@gmail.com> <20211210114222.26581-3-zajec5@gmail.com> Subject: Re: [PATCH V3 2/2] dt-bindings: pinctrl: brcm, ns-pinmux: describe pins, groups & functions Date: Fri, 10 Dec 2021 08:02:56 -0600 Message-Id: <1639144976.220651.1252252.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211210_060303_129144_3FFEE55F X-CRM114-Status: GOOD ( 16.23 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2228952647745182199==" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org --===============2228952647745182199== Content-Type: text/plain On Fri, 10 Dec 2021 12:42:22 +0100, Rafał Miłecki wrote: > From: Rafał Miłecki > > Use and extend generic pinctrl binding to include info about pins, > groups & functions. > > Northstar platform pins have numbers assigned to them (they are needed > for mux programming) so add a custom "number" property for that. > > Extend example to provide a complete binding of a single / random > function. > > Signed-off-by: Rafał Miłecki > --- > .../bindings/pinctrl/brcm,ns-pinmux.yaml | 38 ++++++++++++++++++- > 1 file changed, 37 insertions(+), 1 deletion(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml: 'additionalProperties' is a required property hint: A schema without a "$ref" to another schema must define all properties and use "additionalProperties" from schema $id: http://devicetree.org/meta-schemas/base.yaml# schemas/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: warning: no schema found in file: ./Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.yaml Documentation/devicetree/bindings/pinctrl/brcm,ns-pinmux.example.dt.yaml:0:0: /example-0/pin-controller@1800c1c0: failed to match any schema with compatible: ['brcm,bcm4708-pinmux'] make[1]: *** Deleting file 'Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml' schemas/pinctrl/brcm,ns-pinmux.yaml: ignoring, error in schema: Traceback (most recent call last): File "/usr/local/bin/dt-validate", line 170, in sg.check_trees(filename, testtree) File "/usr/local/bin/dt-validate", line 119, in check_trees self.check_subtree(dt, subtree, False, "/", "/", filename) File "/usr/local/bin/dt-validate", line 110, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/local/bin/dt-validate", line 110, in check_subtree self.check_subtree(tree, value, disabled, name, fullname + name, filename) File "/usr/local/bin/dt-validate", line 105, in check_subtree self.check_node(tree, subtree, disabled, nodename, fullname, filename) File "/usr/local/bin/dt-validate", line 49, in check_node errors = sorted(dtschema.DTValidator(schema).iter_errors(node), key=lambda e: e.linecol) File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 224, in iter_errors for error in errors: File "/usr/local/lib/python3.8/dist-packages/jsonschema/_validators.py", line 25, in patternProperties yield from validator.descend( File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 240, in descend for error in self.evolve(schema=schema).iter_errors(instance): File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 224, in iter_errors for error in errors: File "/usr/local/lib/python3.8/dist-packages/jsonschema/_validators.py", line 298, in ref yield from validator.descend(instance, resolved) File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 240, in descend for error in self.evolve(schema=schema).iter_errors(instance): File "/usr/local/lib/python3.8/dist-packages/dtschema/lib.py", line 766, in iter_errors for error in super().iter_errors(instance, _schema): File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 214, in iter_errors scope = id_of(_schema) File "/usr/local/lib/python3.8/dist-packages/jsonschema/validators.py", line 90, in _id_of return schema.get("$id", "") AttributeError: 'NoneType' object has no attribute 'get' make[1]: *** [scripts/Makefile.lib:373: Documentation/devicetree/bindings/mfd/brcm,cru.example.dt.yaml] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1413: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1566458 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. --===============2228952647745182199== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel --===============2228952647745182199==--