From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3FD4EC433F5 for ; Tue, 14 Dec 2021 16:56:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=touMNpD5lUEG9ArtX5fjEYvSv/wSEpkircnCKeh+MLI=; b=LK8c1gaXEWGlmv IR+//AWekoe/OTKmsBArCdy51/KdewkITqKmyRy3PptsaWn08p0NJRjcevO39Zzx25GHXgvDim+Sh jPP37CbveqP1JkfHANACJ2SxaUM6wQCyC5vmN4N0Iouq70i2m0orJBy2ki+Cdzq3Zr8I5mJz/MdNu iUZy56TcVVzAtVNZo2ZKtln/EIqVib16343Mptt8KhlckolVlka1gHyVP1x9/rPthYcI6jTBNIbqt WAxfBhz60JQ+rJKYDxnD0gVS+eHEfyLLqarH+VrWEiguJzHaIZJVH/dOPI7tJg3IYvFc2R+UjLEAl kZ3DyHVjzSIEH9d883Uw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxB4o-00Ez1O-VF; Tue, 14 Dec 2021 16:54:55 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1mxB4l-00Ez05-8z for linux-arm-kernel@lists.infradead.org; Tue, 14 Dec 2021 16:54:52 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id D174FCE19DB; Tue, 14 Dec 2021 16:54:48 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id DBD91C34606; Tue, 14 Dec 2021 16:54:45 +0000 (UTC) From: Catalin Marinas To: linux-arm-kernel@lists.infradead.org, Mark Rutland Cc: Will Deacon , peterz@infradead.org, boqun.feng@gmail.com Subject: Re: [PATCH 0/5] arm64: atomics: cleanups and codegen improvements Date: Tue, 14 Dec 2021 16:54:43 +0000 Message-Id: <163950083236.2310936.13071029056172034055.b4-ty@arm.com> X-Mailer: git-send-email 2.30.2 In-Reply-To: <20211210151410.2782645-1-mark.rutland@arm.com> References: <20211210151410.2782645-1-mark.rutland@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211214_085451_513466_414FE66B X-CRM114-Status: GOOD ( 13.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 10 Dec 2021 15:14:05 +0000, Mark Rutland wrote: > While looking at Peter's recent refcount rework, I spotted that we have > some unfortunate code generation for the LSE atomics. Due to a > combination of assembly constraints and manipulation performed in > assembly which the compiler has no visibilty of, the compiler ends up > generating unnecessary register shuffling and redundant manipulation. > > This series (based on v5.16-rc4) attempts to improve this by improving > the constraints, and moving value manipulation to C where the compiler > can perofrm a number of optimizations. This also has the benefit of > simplifying the implementation and deleting 100+ lines of code. > > [...] Applied to arm64 (for-next/atomics), thanks! (also fixed the double "instruction" in the last patch). [1/5] arm64: atomics: format whitespace consistently https://git.kernel.org/arm64/c/8e6082e94aac [2/5] arm64: atomics lse: define SUBs in terms of ADDs https://git.kernel.org/arm64/c/ef5324506098 [3/5] arm64: atomics: lse: define ANDs in terms of ANDNOTs https://git.kernel.org/arm64/c/5e9e43c987b2 [4/5] arm64: atomics: lse: improve constraints for simple ops https://git.kernel.org/arm64/c/8a578a759ad6 [5/5] arm64: atomics: lse: define RETURN ops in terms of FETCH ops https://git.kernel.org/arm64/c/053f58bab331 -- Catalin _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel