From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 3B03EC433EF for ; Mon, 24 Jan 2022 09:49:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:From:Cc:To :Subject:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=Qy8rJ2ElSh8pb/aU67vLXvnobyqpEJvFTOY1Q+cAunE=; b=ABmtUmqtb4vVpF JJBuftTDHS9pg53+xjbwdgoobNJsHykUCk7czkXzzQnKA2Nso6e1PYNZiWQ8ZqRyHKU3SUDeeXo8s L2sD5HfyLVrnAG7cVS7wPcqxoUjUUtkpa8QVUE4Qlr06uXhZb75gQ0w+kfDRpIXaaGQ5eRC7vOD+4 PzvXXRGTCAvLHU8+L1xEUzeUU3Za/QS9Uj+81TahMf+1qJS6V6J/EK+j8iXClSKc5c75ID7Zt5iyb ZfrZxLfaaYFByRPdm+50o2S1OdVTtkmKk3B0XW5nooOGDxex/Zli/yzwxVwoO0rHxvNMtZZWAUnG2 6WKgHj/XwWkqMmVkg26g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBvxe-002rUa-EY; Mon, 24 Jan 2022 09:48:30 +0000 Received: from ams.source.kernel.org ([2604:1380:4601:e00::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nBvxZ-002rTv-MN for linux-arm-kernel@lists.infradead.org; Mon, 24 Jan 2022 09:48:27 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ams.source.kernel.org (Postfix) with ESMTPS id 41592B80EDF; Mon, 24 Jan 2022 09:48:24 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6B205C340E1; Mon, 24 Jan 2022 09:48:22 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linuxfoundation.org; s=korg; t=1643017703; bh=dGt0sggPuh2en3HgriA360RmwyyDNaU/OzLOAGLvPZI=; h=Subject:To:Cc:From:Date:From; b=pFRuQwXVJO+Rs5I625fT25D09Req6h0gqun/rSucNAdIy8MzgZ0Nvk7CJ34yPt0RR KBxWcmnAO8wLXP8nswCZfFNG+Py+USO2YWelmqCi42eu6j9nJE9Eqy4C49qrcH+Lv9 wPLr6S3LzVJ7IeaSE+wWXlLPZCYYz0+gw0hwrVUc= Subject: Patch "crypto: stm32/crc32 - Fix kernel BUG triggered in probe()" has been added to the 4.14-stable tree To: alexandre.torgue@foss.st.com, fabien.dessenne@st.com, gregkh@linuxfoundation.org, herbert@gondor.apana.org.au, linux-arm-kernel@lists.infradead.org, linux-stm32@st-md-mailman.stormreply.com, lionel.debieve@st.com, marex@denx.de, nicolas.toromanoff@foss.st.com, nicolas.toromanoff@st.com Cc: From: Date: Mon, 24 Jan 2022 10:48:20 +0100 Message-ID: <1643017700222194@kroah.com> MIME-Version: 1.0 X-stable: commit X-Patchwork-Hint: ignore X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220124_014826_070324_D3146816 X-CRM114-Status: GOOD ( 19.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org This is a note to let you know that I've just added the patch titled crypto: stm32/crc32 - Fix kernel BUG triggered in probe() to the 4.14-stable tree which can be found at: http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary The filename of the patch is: crypto-stm32-crc32-fix-kernel-bug-triggered-in-probe.patch and it can be found in the queue-4.14 subdirectory. If you, or anyone else, feels it should not be added to the stable tree, please let know about it. >From 29009604ad4e3ef784fd9b9fef6f23610ddf633d Mon Sep 17 00:00:00 2001 From: Marek Vasut Date: Mon, 20 Dec 2021 20:50:22 +0100 Subject: crypto: stm32/crc32 - Fix kernel BUG triggered in probe() From: Marek Vasut commit 29009604ad4e3ef784fd9b9fef6f23610ddf633d upstream. The include/linux/crypto.h struct crypto_alg field cra_driver_name description states "Unique name of the transformation provider. " ... " this contains the name of the chip or provider and the name of the transformation algorithm." In case of the stm32-crc driver, field cra_driver_name is identical for all registered transformation providers and set to the name of the driver itself, which is incorrect. This patch fixes it by assigning a unique cra_driver_name to each registered transformation provider. The kernel crash is triggered when the driver calls crypto_register_shashes() which calls crypto_register_shash(), which calls crypto_register_alg(), which calls __crypto_register_alg(), which returns -EEXIST, which is propagated back through this call chain. Upon -EEXIST from crypto_register_shash(), the crypto_register_shashes() starts unregistering the providers back, and calls crypto_unregister_shash(), which calls crypto_unregister_alg(), and this is where the BUG() triggers due to incorrect cra_refcnt. Fixes: b51dbe90912a ("crypto: stm32 - Support for STM32 CRC32 crypto module") Signed-off-by: Marek Vasut Cc: # 4.12+ Cc: Alexandre Torgue Cc: Fabien Dessenne Cc: Herbert Xu Cc: Lionel Debieve Cc: Nicolas Toromanoff Cc: linux-arm-kernel@lists.infradead.org Cc: linux-stm32@st-md-mailman.stormreply.com To: linux-crypto@vger.kernel.org Acked-by: Nicolas Toromanoff Signed-off-by: Herbert Xu Signed-off-by: Greg Kroah-Hartman --- drivers/crypto/stm32/stm32_crc32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- a/drivers/crypto/stm32/stm32_crc32.c +++ b/drivers/crypto/stm32/stm32_crc32.c @@ -206,7 +206,7 @@ static struct shash_alg algs[] = { .digestsize = CHKSUM_DIGEST_SIZE, .base = { .cra_name = "crc32", - .cra_driver_name = DRIVER_NAME, + .cra_driver_name = "stm32-crc32-crc32", .cra_priority = 200, .cra_flags = CRYPTO_ALG_OPTIONAL_KEY, .cra_blocksize = CHKSUM_BLOCK_SIZE, @@ -228,7 +228,7 @@ static struct shash_alg algs[] = { .digestsize = CHKSUM_DIGEST_SIZE, .base = { .cra_name = "crc32c", - .cra_driver_name = DRIVER_NAME, + .cra_driver_name = "stm32-crc32-crc32c", .cra_priority = 200, .cra_flags = CRYPTO_ALG_OPTIONAL_KEY, .cra_blocksize = CHKSUM_BLOCK_SIZE, Patches currently in stable-queue which might be from marex@denx.de are queue-4.14/crypto-stm32-crc32-fix-kernel-bug-triggered-in-probe.patch _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel