From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 627FCC433F5 for ; Tue, 15 Feb 2022 23:22:53 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=Lxcs/VIsS/QSEFemE6O6dIA0SgwPe1ktMU42z/NLD6k=; b=lv5jBp5T2rMGoS MI9j0bEeGRDaksThweiIG5xzUgmwea2R2IcZM62pW2evZ3YlpP/3UMkaKDPcQ0O3b66OD1c2+V5rY De252li4WJwSoxNctwUd47vRxYwwtJwsQ2o8xcVXLFMoiCf/NOGmj1crKrrL56JP+OPtqEFuChksp 05pqubGv50o1pz9imPOnQjaCjKjyQxqWky2xrm4dJg5S9MvQSR/Yy9Xf3vfA96rkOTDd82tTjwf8J 4L3D/GFp8bbYVQz3FG763VkiOWzruMoKlSz48frMopQoU0huq3DkoioWsy0kK0vIMeghZ/Imz4t4n YUgDFMrrVE/ABVHy2chQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK78Z-004taO-Ok; Tue, 15 Feb 2022 23:21:36 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nK766-004sOF-5i for linux-arm-kernel@lists.infradead.org; Tue, 15 Feb 2022 23:19:04 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id CBDCCCE2421; Tue, 15 Feb 2022 23:18:58 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 7F8B0C340F0; Tue, 15 Feb 2022 23:18:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1644967137; bh=vJwgqHlTSVS2MaFXBwRnv90xILurIVswlRO3SZJ4PW8=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NznsgA8VWDwJBGrcJqnU6VSL16vQd1VKlsXwmhPvyDkDhFfr8WSxM048cN5Io1tV7 3j7lCJWMbDOfix6W6FAoVra3HCtqRYKYOHWQqJOsKWhVWNCKQKv1Z7UN2ZFCFdfblK yP0/Y0y/5Xjj1MxRMsbk/cRrGUG1//aliZc4LiEDGYB0ajCD5Jnzc3SIOvJJckV+ki V1fe5inaefV2ArFHOZaxYBOts+dvXD2bF+1HfF2UBqM42g5FYLeYhp0iCdLEnJmWbn U8Fj1eggF6zYZvx3SOkhz829QGgB9rJoIKdqPmXMA2lCdlkx7aMRSFd/GVqjLNWJdB 1d+BTR1MLK01g== From: Will Deacon To: linux-kselftest@vger.kernel.org, linux-arm-kernel@lists.infradead.org, James Morse Cc: catalin.marinas@arm.com, kernel-team@android.com, Will Deacon , Marc Zyngier , Shuah Khan , Mark Brown Subject: Re: [PATCH 0/3] arm64: insn: Generate 64 bit mask immediates correctly Date: Tue, 15 Feb 2022 23:18:29 +0000 Message-Id: <164494031388.1780361.10975276520222127155.b4-ty@kernel.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20220127162127.2391947-1-james.morse@arm.com> References: <20220127162127.2391947-1-james.morse@arm.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220215_151902_396801_63C3BC00 X-CRM114-Status: GOOD ( 11.32 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 27 Jan 2022 16:21:24 +0000, James Morse wrote: > aarch64_insn_gen_logical_immediate() is generating the wrong code if > it is handed a 64bit immediate which has a single span of 1s (i.e. a > mask), with bit 63 set, and 0s in the remaining upper 32 bits. > Clear as mud. An example always helps: 0x800000003fffffff would be wrongly > encoded, but 0x000000003fffffff is unaffected. > > It would appear eBPF is unable to hit these cases, as build_insn()'s > imm value is a s32, so when used with BPF_ALU64, the sign-extended > u64 immediate would always have all-1s or all-0s in the upper 32 bits. > > [...] Applied to arm64 (for-next/insn), thanks! [1/3] arm64: selftests: Generate all the possible logical immediates as a header (no commit info) [2/3] arm64: insn: Add tests for aarch64_insn_gen_logical_immediate() (no commit info) [3/3] arm64: insn: Generate 64 bit mask immediates correctly https://git.kernel.org/arm64/c/a6aab0188299 Cheers, -- Will https://fixes.arm64.dev https://next.arm64.dev https://will.arm64.dev _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel