Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119)
Date: Wed, 19 Nov 2014 12:15:45 +0100	[thread overview]
Message-ID: <16479190.7SIDaKWfdW@wuerfel> (raw)
In-Reply-To: <546c75d7.6336460a.14b5.474d@mx.google.com>

On Wednesday 19 November 2014 02:49:59 Olof's autobuilder wrote:
> 
>         arm64.allmodconfig:
> drivers/net/ethernet/dec/tulip/winbond-840.c:910:2: warning: #warning Processor architecture undefined [-Wcpp]
>  #warning Processor architecture undefined
> drivers/net/ethernet/dec/tulip/tulip_core.c:101:2: warning: #warning Processor architecture undefined! [-Wcpp]
>  #warning Processor architecture undefined!
> :(.text+0x42344): undefined reference to `pci_iomap'
> :(.text+0x42ca0): undefined reference to `pci_iomap'
> :(.text+0x11c10): undefined reference to `pci_iomap'
> 
>         arm64.defconfig:
> drivers/pci/quirks.c:2965: undefined reference to `pci_iomap'
> drivers/pci/quirks.c:3328: undefined reference to `pci_iomap'
> drivers/tty/serial/8250/8250_pci.c:1044: undefined reference to `pci_iomap'
> drivers/tty/serial/8250/8250_pci.c:1012: undefined reference to `pci_iomap'
> lib/devres.c:273: undefined reference to `pci_iomap'
> 

Hi Thierry,

This is another regression from your asm-generic change in arm64. We
are now lacking a working pci_iomap function after you removed the
'select GENERIC_IOMAP' statement.

For all I can tell, this is the correct solution (note GENERIC_PCI_IOMAP
instead of GENERIC_IOMAP):

diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
index 37cd23625708..bc8879c283b9 100644
--- a/arch/arm64/Kconfig
+++ b/arch/arm64/Kconfig
@@ -25,6 +25,7 @@ config ARM64
        select GENERIC_EARLY_IOREMAP
        select GENERIC_IRQ_PROBE
        select GENERIC_IRQ_SHOW
+       select GENERIC_PCI_IOMAP
        select GENERIC_SCHED_CLOCK
        select GENERIC_SMP_IDLE_THREAD
        select GENERIC_STRNCPY_FROM_USER


Any comments?

	Arnd

       reply	other threads:[~2014-11-19 11:15 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <546c75d7.6336460a.14b5.474d@mx.google.com>
2014-11-19 11:15 ` Arnd Bergmann [this message]
2014-11-19 13:56   ` arm64 pci_iomap, was: Re: next build: 258 warnings 9 failures (next/next-20141119) Thierry Reding
2014-11-19 14:11     ` Arnd Bergmann
2014-11-19 14:20       ` Thierry Reding

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=16479190.7SIDaKWfdW@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox