From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 44D50C433EF for ; Tue, 29 Mar 2022 11:52:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=0uBrk1tjHGe2AQgCLW9FvxHbwewkSas2KGAvhTtvgnk=; b=Npp6jwOeknSVZr 7nWB4y0DgC8pVp55kmVQK47+HTIhIRR1n9iPtJTgvk9Y9OtN0uwf05kePihHMHDXPUkaE6JmFx3M0 nnIKp76PeZftmP6E5uGvENRG3Q7LkmXGcA5gtGzWwQsfU4v5ApGXBxNwyVPsLXBt5jHk6JiB8/inp mBwO4vlKdmzASMcgBHwUBNjf6Co9rEFt612GnOdmTsyhceaFfETYO1xVWfLwsuDgzN0b3uBGMOGgo sX6GDcwOV0Az9Ej3BuiTUDb2XZdQjf207baLRVKMRfhJ0SxYDAjRpT5tVDkioElmEv3tW7z5XOWnu gI43bjSFYG27HxC3T3Pg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZAMx-00C4TE-Df; Tue, 29 Mar 2022 11:50:39 +0000 Received: from mail-oo1-f45.google.com ([209.85.161.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nZAMq-00C4RA-Jo for linux-arm-kernel@lists.infradead.org; Tue, 29 Mar 2022 11:50:34 +0000 Received: by mail-oo1-f45.google.com with SMTP id u30-20020a4a6c5e000000b00320d8dc2438so3042910oof.12 for ; Tue, 29 Mar 2022 04:50:32 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=yuvwzw+NPlzU064huZNX24SkiRaX81wKTyH2T/53Ev8=; b=Ak4bMgdFIFaYLF2RcKTMXeNs2mgvawVmR2s7ul6ChlvEpDqTrwgwpHYXVL1WvmbjXB v9cHbzAuzN0mqNSwdu5yV+KKU2rOF3FBi9m3MRs5CoVuxve3iDNthe7ZgOHGLJS8ltIC AJmxT0TAtpEN9ZefQN2HliAuFbKjLues83PiMSfby6WmMxUamuWXg7+W2jp+E+6dwRsW BAQGW9bGehvqnn8Km/MZgohx9H5z01zP3FH0LO0IF5d2VJqIdpIh6xbzfvxCBe+IjDkC rZH8z2UG/IZo08snLz0IA49hacA84FmQOMcLXYP9NBvZDytZk3+WStcEaA0FvU/xX2CX NZgA== X-Gm-Message-State: AOAM532UjUNWzcwy9D5NBuFuv0kIAYCVx9HTYqhgWUHVxrlgOWixfm55 rqJlpFJSn3CSR+ORUijGZeaoSqt6yA== X-Google-Smtp-Source: ABdhPJwmR/a0AlYIct99XZbVh2WM6/sYPiNZPnX2sfuAxKga/UBtw/wMHWh9AAsLInOrS4ej0s0RZQ== X-Received: by 2002:a4a:d254:0:b0:324:b1bf:da28 with SMTP id e20-20020a4ad254000000b00324b1bfda28mr834035oos.49.1648554631484; Tue, 29 Mar 2022 04:50:31 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id d3-20020a9d2903000000b005cda765f578sm8641220otb.0.2022.03.29.04.50.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 29 Mar 2022 04:50:30 -0700 (PDT) Received: (nullmailer pid 350363 invoked by uid 1000); Tue, 29 Mar 2022 11:50:29 -0000 From: Rob Herring To: Chris Packham Cc: andrew@lunn.ch, ulf.hansson@linaro.org, linux-arm-kernel@lists.infradead.org, sebastian.hesselbarth@gmail.com, gregory.clement@bootlin.com, linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org, krzk+dt@kernel.org, huziji@marvell.com, robh+dt@kernel.org, devicetree@vger.kernel.org In-Reply-To: <20220329000231.3544810-3-chris.packham@alliedtelesis.co.nz> References: <20220329000231.3544810-1-chris.packham@alliedtelesis.co.nz> <20220329000231.3544810-3-chris.packham@alliedtelesis.co.nz> Subject: Re: [PATCH v4 2/2] dt-bindings: mmc: xenon: Convert to JSON schema Date: Tue, 29 Mar 2022 06:50:29 -0500 Message-Id: <1648554629.870840.350362.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220329_045032_718115_298A8BF4 X-CRM114-Status: GOOD ( 17.85 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 29 Mar 2022 13:02:31 +1300, Chris Packham wrote: > Convert the marvell,xenon-sdhci binding to JSON schema. Currently the > in-tree dts files don't validate because they use sdhci@ instead of mmc@ > as required by the generic mmc-controller schema. > > The compatible "marvell,sdhci-xenon" was not documented in the old > binding but it accompanies the of "marvell,armada-3700-sdhci" in the > armada-37xx SoC dtsi so this combination is added to the new binding > document. > > Signed-off-by: Chris Packham > Reviewed-by: Krzysztof Kozlowski > --- > > Notes: > Changes in v4: > - Add review from Krzysztof > - Squash in addition of marvell,sdhci-xenon with an explanation in the > commit message > Changes in v3: > - Don't accept ap807 without ap806 > - Add ref: string for pad-type > Changes in v2: > - Update MAINTAINERS entry > - Incorporate feedback from Krzysztof > > .../bindings/mmc/marvell,xenon-sdhci.txt | 173 ----------- > .../bindings/mmc/marvell,xenon-sdhci.yaml | 275 ++++++++++++++++++ > MAINTAINERS | 2 +- > 3 files changed, 276 insertions(+), 174 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.txt > create mode 100644 Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@aa0000: compatible: 'oneOf' conditional failed, one must be fixed: ['marvell,armada-3700-sdhci'] is too short 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] 'marvell,armada-ap807-sdhci' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.example.dt.yaml: mmc@ab0000: compatible: 'oneOf' conditional failed, one must be fixed: ['marvell,armada-3700-sdhci'] is too short 'marvell,armada-3700-sdhci' is not one of ['marvell,armada-cp110-sdhci', 'marvell,armada-ap806-sdhci'] 'marvell,armada-ap807-sdhci' was expected From schema: /builds/robherring/linux-dt-review/Documentation/devicetree/bindings/mmc/marvell,xenon-sdhci.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/1610447 This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel