From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 19684C433EF for ; Tue, 12 Apr 2022 13:19:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:MIME-Version:List-Subscribe:List-Help: List-Post:List-Archive:List-Unsubscribe:List-Id:Message-Id:Date:Subject: References:In-Reply-To:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KPM3ugd2HKlpaWxxJAeI+MXlTlvmQfSYw6/pXaio3hQ=; b=sWeq3SiDSHlO0e sqY+UCY8q8tA9YDRvjxlB8B4zGk7NRBobsstkkweXY0z+v66evpyXq9nct7WZrM/YG5U/VhPTfcHd 2gyVj3PcecEfE2cX4tvFrSVYx0acce5V1KCUhV+ZlsDAqan94OsGD9EcoOwMWXovSUB8Kj/d+Y1t7 FRtpyCFGSGJTp2pR4oiQo4oYckjbD8iNL8SYdjF6/dpDlmZEOBRzgKYDACaf07DP6N+xUOSYJUTvl wE/bcm5Zgw51IVYhiuBounYL+vcbNeB4skD2d7XbNgZnRTAokedF1cix2nT+Djau/GtU83iiLWEcA B5ZgmjP5o8Az+QYj/fbA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1neGPj-00EVfU-Ga; Tue, 12 Apr 2022 13:18:36 +0000 Received: from mail-ot1-f45.google.com ([209.85.210.45]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1neGLR-00ETa9-8s for linux-arm-kernel@lists.infradead.org; Tue, 12 Apr 2022 13:14:11 +0000 Received: by mail-ot1-f45.google.com with SMTP id e25-20020a0568301e5900b005b236d5d74fso13404394otj.0 for ; Tue, 12 Apr 2022 06:14:07 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:in-reply-to:references:subject:date :message-id; bh=4Hu29V9bbNGQ7NeMGoWiDLgZuDde0wP79E71crt9DdM=; b=v/tpFmc2H2a04q5uW4wSDuwAPRcXeICfPEBXWa27edNgkAoYVWz6X9c7/y5AqlyDMU 1rjmRrJ4ofOQQORo3fqy3H1b4dk0fX6slQp0jZYMT5EA3JSL+2Js9KPUPvDEHap0mfb0 xpy5iues8/YCeryOlZxmwijG3t7OURaWawB4ezY2x33YpSPifxTFFn/MAABqQ4dfif/N oP78dxhpF8+2GcJnU9NMu3Y/t3CYHFHnKVkf7wreOsxQ5SWvKMvqRVsNhk/uxtNwqKpw JpdQvLt7i13OTFmrbIExy3NPxChmxquXbAy3ynXvXe0oASkpMV8bK9bBEEPMS9bRy0a7 ZJTQ== X-Gm-Message-State: AOAM533m/12PbMbf84GN8/AvqKsYMl5Kx5lPCjQOFbvzmQp/Fcf55cMy 8rckONLgaTIcAZ5LrzIQJA== X-Google-Smtp-Source: ABdhPJy/ZMhWQUc529yUtvgnyCadjBqr7fjsWtZYK6b6y58vnNMwVPuq1IYac7H3Y8QrDWl4AkwVgw== X-Received: by 2002:a05:6830:2aa1:b0:5e6:cccf:419b with SMTP id s33-20020a0568302aa100b005e6cccf419bmr6816302otu.208.1649769246965; Tue, 12 Apr 2022 06:14:06 -0700 (PDT) Received: from robh.at.kernel.org (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id n62-20020acaef41000000b002ef646e6690sm12947467oih.53.2022.04.12.06.14.06 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 12 Apr 2022 06:14:06 -0700 (PDT) Received: (nullmailer pid 3815484 invoked by uid 1000); Tue, 12 Apr 2022 13:14:05 -0000 From: Rob Herring To: Dylan Hung Cc: netdev@vger.kernel.org, kuba@kernel.org, linux-aspeed@lists.ozlabs.org, Krzysztof Kozlowski , devicetree@vger.kernel.org, joel@jms.id.au, hkallweit1@gmail.com, pabeni@redhat.com, linux-arm-kernel@lists.infradead.org, andrew@aj.id.au, robh+dt@kernel.org, p.zabel@pengutronix.de, krzk+dt@kernel.org, linux-kernel@vger.kernel.org, andrew@lunn.ch, BMC-SW@aspeedtech.com, linux@armlinux.org.uk, davem@davemloft.net In-Reply-To: <20220412065611.8930-2-dylan_hung@aspeedtech.com> References: <20220412065611.8930-1-dylan_hung@aspeedtech.com> <20220412065611.8930-2-dylan_hung@aspeedtech.com> Subject: Re: [PATCH v4 1/3] dt-bindings: net: add reset property for aspeed, ast2600-mdio binding Date: Tue, 12 Apr 2022 08:14:05 -0500 Message-Id: <1649769245.688561.3815481.nullmailer@robh.at.kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220412_061409_394062_D859DEF7 X-CRM114-Status: GOOD ( 16.08 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 12 Apr 2022 14:56:09 +0800, Dylan Hung wrote: > The AST2600 MDIO bus controller has a reset control bit and must be > deasserted before manipulating the MDIO controller. By default, the > hardware asserts the reset so the driver only need to deassert it. > > Regarding to the old DT blobs which don't have reset property in them, > the reset deassertion is usually done by the bootloader so the reset > property is optional to work with them. > > Signed-off-by: Dylan Hung > Reviewed-by: Krzysztof Kozlowski > --- > .../devicetree/bindings/net/aspeed,ast2600-mdio.yaml | 5 +++++ > 1 file changed, 5 insertions(+) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: Error: Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.example.dts:25.35-36 syntax error FATAL ERROR: Unable to parse input tree make[1]: *** [scripts/Makefile.lib:364: Documentation/devicetree/bindings/net/aspeed,ast2600-mdio.example.dtb] Error 1 make[1]: *** Waiting for unfinished jobs.... make: *** [Makefile:1401: dt_binding_check] Error 2 doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel