From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 09A9FC433F5 for ; Thu, 21 Apr 2022 02:51:01 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Message-ID:Date:Subject:CC :To:From:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:In-Reply-To:References: List-Owner; bh=UYzX2BN52iHD7X+oqoCWlBB5/XYj2b+y8xXZvgwERbc=; b=OzMQiTh/mgnWjd 6hvUiWYID5kclXsHZxDcrujr8OOZt0GaOtGgP1tbY08GlzY/Omf70bNm0yiic+OdYU4wnsWlto8eC Zj8/8mv5RdqSbi04He8Y1cNj72aqC9lPEZ9nuc5dyHMvG6sbsiknUbISleuoIcayzrWZb/eUTzWXS xggROxJQ5xjieEM6Pm+zIgTNkJCWbbuVg6LJ4V+Ljt9Ka07GFewzDthfE9un6HN5KkLMz4zdcs9nd yDau6svDE4Wb0BWgQ1J4Ud0YBN81fG8K6jNEIIac667LuZfk4DkRKlygL89Qr8QLRfx2PH+ZeHgBi 04vd2XugmxvaGiUnr/yA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhMtO-00BCwc-Vg; Thu, 21 Apr 2022 02:50:03 +0000 Received: from edge05.meizu.com ([157.122.146.251] helo=mail.meizu.com) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nhMtK-00BCu1-Me for linux-arm-kernel@lists.infradead.org; Thu, 21 Apr 2022 02:50:00 +0000 Received: from IT-EXMB-1-125.meizu.com (172.16.1.125) by mz-mail12.meizu.com (172.16.1.108) with Microsoft SMTP Server (TLS) id 14.3.487.0; Thu, 21 Apr 2022 10:49:54 +0800 Received: from meizu.meizu.com (172.16.137.70) by IT-EXMB-1-125.meizu.com (172.16.1.125) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2308.14; Thu, 21 Apr 2022 10:49:51 +0800 From: Haowen Bai To: Vinod Koul , Shawn Guo , "Sascha Hauer" , Pengutronix Kernel Team , Fabio Estevam , NXP Linux Team CC: Haowen Bai , , , Subject: [PATCH] dmaengine: imx-sdma: Remove useless null check before call of_node_put() Date: Thu, 21 Apr 2022 10:49:50 +0800 Message-ID: <1650509390-26877-1-git-send-email-baihaowen@meizu.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Originating-IP: [172.16.137.70] X-ClientProxiedBy: IT-EXMB-1-126.meizu.com (172.16.1.126) To IT-EXMB-1-125.meizu.com (172.16.1.125) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220420_194959_124926_F3DA7AAF X-CRM114-Status: UNSURE ( 8.14 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org No need to add null check before call of_node_put(), since the implementation of of_node_put() has done it. Signed-off-by: Haowen Bai --- drivers/dma/imx-sdma.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/dma/imx-sdma.c b/drivers/dma/imx-sdma.c index 6196a7b3956b..b8a1299b93f0 100644 --- a/drivers/dma/imx-sdma.c +++ b/drivers/dma/imx-sdma.c @@ -1933,8 +1933,7 @@ static int sdma_event_remap(struct sdma_engine *sdma) } out: - if (gpr_np) - of_node_put(gpr_np); + of_node_put(gpr_np); return ret; } -- 2.7.4 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel