From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id D546CC433EF for ; Thu, 28 Apr 2022 20:00:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:To:From:Reply-To:Cc:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=z0TBR+2zNI8BgyXlh9k1+3U6z0EaiWeMsZ2GSLQlCCU=; b=TqI6+nSUCIZawP dukNdMTpGZp5nbPFHLi+/x7h4w1OGwwcvlAA8s6OrHIsjaiNZez56G/utvE1UwbYvphK8w9N7CeyX 8lY2Ef29jBDieCkjGcv4a2+YzNiEKa1b+nwhKtS+YW78j644/RnIb3ry3eQkD0dK17XmK8retUphn 1WgrbE8uweDP8yGfifVpiwQIVZ4C0A35ZpDbInwMPWcfZ8Qg3gZ7MBr1dTNWJzFAb5BmDf7Oy8bt4 B2Z8okR/D5FwX3wpQTIV9fJ50Vy4m0lqEXCUtYXAwJTUkV/3TlDBTpsGyUmMtgyGLM+QZvALqG979 R9OJznPKIgiyVn03i4jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkAIB-008Jek-4j; Thu, 28 Apr 2022 19:59:11 +0000 Received: from sin.source.kernel.org ([2604:1380:40e1:4800::1]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nkAI8-008Jdy-Jn for linux-arm-kernel@lists.infradead.org; Thu, 28 Apr 2022 19:59:10 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sin.source.kernel.org (Postfix) with ESMTPS id 04D3CCE2DAD; Thu, 28 Apr 2022 19:59:03 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 561D2C385AF; Thu, 28 Apr 2022 19:59:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1651175940; bh=2VpuXfSni30Kb/eTw7UZLyG2wBlPNOJWkggE1bbFFCE=; h=From:To:Subject:Date:In-Reply-To:References:From; b=DVDCnGs+zqo2oLW52P6WQB/+50WL+4HDCfG9fI9/Gba5nc9y5zW2ucTmC4TQsEm+K SecChsBnoav7wo53YNj5wrGJc3a1SRogPz9ErxmMZiszJfQTnYBwXXTtFrcsO4+H0G q+q+YNKncBWM/wXcKf6ysHqmFKKTt5CSchjG/xK0AJpSdOSY4nhLWhmRoDTHZzHwlL OrHzT8/7kDigQMDU8ntPSOhBwB9H4somfY9++KgwwcqIEye3YIS62iHzoEQxuCsMny GvEJC0p3mkN+rVdjmOOtcHJXGzSyJiCh/mjgvgMPx2qUGMB56ulmgVoVjrqnwgJO/V 7lrO103GhcHIQ== Received: from sofa.misterjones.org ([185.219.108.64] helo=hot-poop.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.94.2) (envelope-from ) id 1nkAHy-007lBY-0K; Thu, 28 Apr 2022 20:58:58 +0100 From: Marc Zyngier To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, Alexandru Elisei , james.morse@arm.com, suzuki.poulose@arm.com Subject: Re: [PATCH] KVM/arm64: Don't emulate a PMU for 32-bit guests if feature not set Date: Thu, 28 Apr 2022 20:58:54 +0100 Message-Id: <165117592520.3115569.6681600496977267947.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20220425145530.723858-1-alexandru.elisei@arm.com> References: <20220425145530.723858-1-alexandru.elisei@arm.com> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: kvmarm@lists.cs.columbia.edu, linux-arm-kernel@lists.infradead.org, alexandru.elisei@arm.com, james.morse@arm.com, suzuki.poulose@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220428_125908_858906_764E36D4 X-CRM114-Status: GOOD ( 13.12 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Mon, 25 Apr 2022 15:55:30 +0100, Alexandru Elisei wrote: > kvm->arch.arm_pmu is set when userspace attempts to set the first PMU > attribute. As certain attributes are mandatory, arm_pmu ends up always > being set to a valid arm_pmu, otherwise KVM will refuse to run the VCPU. > However, this only happens if the VCPU has the PMU feature. If the VCPU > doesn't have the feature bit set, kvm->arch.arm_pmu will be left > uninitialized and equal to NULL. > > [...] Applied to fixes, thanks! [1/1] KVM/arm64: Don't emulate a PMU for 32-bit guests if feature not set commit: 8f6379e207e7d834065a080f407a60d67349d961 Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel