From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 5E1E4C47DD9 for ; Fri, 22 Mar 2024 13:14:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=eK8TJbC+rz3pX1HF351v9JEmaG/NabGXKpHjtcYGgNs=; b=GX95xtzwmERcNF hprrAm8x4L++xNQKrNdL57lJIXHxNGRaywutXk1hfOloEo5IHblY5xvtOubVvDiepzUrGkqp+MeRm iqLKZ5Dg1HeF52wCNgKyyV82scL6s+/eDFcRDBIK91y76CZtTm5qaZXBQ0/fGZ61+s56w2YoT86Rc l5CSvrl+v6AUV0NCFBuxMKBUHqg7SKrRPQXiLxKYBYYlJ6tJ7rvvhl3BEF0/VvW91V1I2rS4ufLC8 X9zi34E73aiVrGmvcD6UFRwx2KPFae0sOvRUEsYmC6saPQFffM4A70YbB4YQEKpe2bKEjOqJSCITu AEl2L1W6gTHOM6VsRcaA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnejJ-00000007Fnf-2NvD; Fri, 22 Mar 2024 13:14:41 +0000 Received: from vps0.lunn.ch ([156.67.10.101]) by bombadil.infradead.org with esmtps (Exim 4.97.1 #2 (Red Hat Linux)) id 1rnejF-00000007Fn0-3q81 for linux-arm-kernel@lists.infradead.org; Fri, 22 Mar 2024 13:14:39 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lunn.ch; s=20171124; h=In-Reply-To:Content-Disposition:Content-Type:MIME-Version: References:Message-ID:Subject:Cc:To:From:Date:From:Sender:Reply-To:Subject: Date:Message-ID:To:Cc:MIME-Version:Content-Type:Content-Transfer-Encoding: Content-ID:Content-Description:Content-Disposition:In-Reply-To:References; bh=vIwrXgz6mGqYH+RLNNIetaWtlUBzNHwGkAChikoCXt4=; b=LYvbscrWOzxXELMGyTRAUKsso+ 0PK0gHi6At8wOpXed5xwM//GqJVMALwzJjP3o3EnQjh3g7jywOKJIA7XrqRnTjS8a7y9szH73OZX0 ClZU2dAjjeL0s2cRcAph0vSkNYeVDBu/e1te5+jmR9X/7Tf5z3XNwB8/w+/5xRVlASPo=; Received: from andrew by vps0.lunn.ch with local (Exim 4.94.2) (envelope-from ) id 1rnej2-00Axe0-LV; Fri, 22 Mar 2024 14:14:24 +0100 Date: Fri, 22 Mar 2024 14:14:24 +0100 From: Andrew Lunn To: Arnd Bergmann Cc: Thomas Gleixner , Arnd Bergmann , Gregory Clement , Sebastian Hesselbarth , Marc Zyngier , Nathan Rossi , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] [RESEND] irqchip: armada: suppress unused-function warning Message-ID: <1656dbc4-a695-4150-b24c-aeb3d6ecd77e@lunn.ch> References: <20240322125838.901649-1-arnd@kernel.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20240322125838.901649-1-arnd@kernel.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20240322_061438_058907_434EE2C4 X-CRM114-Status: GOOD ( 12.14 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, Mar 22, 2024 at 01:58:25PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > armada_370_xp_msi_reenable_percpu is only defined when CONFIG_PCI_MSI > is enabled, and only called when SMP is enabled. > > Without CONFIG_SMP, there are no callers, so we get a build time > warning instead: > > drivers/irqchip/irq-armada-370-xp.c:319:13: error: 'armada_370_xp_msi_reenable_percpu' defined but not used [-Werror=unused-function] > 319 | static void armada_370_xp_msi_reenable_percpu(void) {} > | ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ > > Mark the function as __maybe_unused to avoid adding more complexity > to the #ifdefs. > > Fixes: 8ca61cde32c1 ("irqchip/armada-370-xp: Enable MSI affinity configuration") > Link: https://lore.kernel.org/lkml/20221215170202.2441960-1-arnd@kernel.org/ > Signed-off-by: Arnd Bergmann Reviewed-by: Andrew Lunn Andrew _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel