From: florian@openwrt.org (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: ep93xx irq-vic regression
Date: Sun, 17 Mar 2013 15:48:19 +0100 [thread overview]
Message-ID: <1659668.cz5sPBWP0g@bender> (raw)
In-Reply-To: <51450905.8030108@gmail.com>
On Sunday 17 March 2013 11:06:29 Ryan Mallon wrote:
[snip]
> >> From: H Hartley Sweeten <hsweeten@visionengravers.com>
> >> Subject: [PATCH] arm: ep93xx: fix wait for UART FIFO to be empty
> >>
> >> commit 210dce5f "ARM: ep93xx: properly wait for UART FIFO to be empty"
> >>
> >> Removed the timeout loop while waiting for the uart transmit fifo to
> >> empty. Some bootloaders leave the uart in a state where there might
> >> be bytes in the uart that are not transmitted when execution is handed
> >> over to the kernel. This results in a deadlocked system while waiting
> >> for the fifo to empty.
> >>
> >> Add back the timeout wait to prevent the deadlock.
> >>
> >> Increase the wait time to hopefully prevent the decompressor corruption
> >> that lead to commit 210dce5f. This corruption was probably due to a
> >> slow uart baudrate. The 10* increase in the wait time should be enough
> >> for all cases.
> >
> > Ok, your solution seems like it would work, when I come accross this bug I
> > initially ended up doing the same thing and incrementing the number of
> > iterations in the loop. I was not quite happy with that as it would still
be
> > highly depending on the clocking. Anyway, sorry for breaking your system
with
> > this commit.
>
>
> Do you want to add an Acked/Reviewed-by Florian? I'll queue this
> up in my tree if you are happy with it.
Yes, I just re-tested with 10000 as a loop value, and it fixes the corruption I
was seeing, you can add my Acked-by: Florian Fainelli <florian@openwrt.org>
Thanks to both of you!
--
Florian
next prev parent reply other threads:[~2013-03-17 14:48 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-03-15 21:46 ep93xx irq-vic regression H Hartley Sweeten
2013-03-15 23:11 ` Ryan Mallon
2013-03-16 0:16 ` H Hartley Sweeten
2013-03-16 13:49 ` Florian Fainelli
2013-03-17 0:06 ` Ryan Mallon
2013-03-17 14:48 ` Florian Fainelli [this message]
2013-03-18 20:21 ` Linus Walleij
2013-03-19 17:03 ` H Hartley Sweeten
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1659668.cz5sPBWP0g@bender \
--to=florian@openwrt.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox