From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Thu, 17 Mar 2016 13:30:20 +0200 Subject: [PATCH v5 5/9] dmaengine: rcar-dmac: slave address are physical In-Reply-To: <1457404974-1800-6-git-send-email-niklas.soderlund+renesas@ragnatech.se> References: <1457404974-1800-1-git-send-email-niklas.soderlund+renesas@ragnatech.se> <1457404974-1800-6-git-send-email-niklas.soderlund+renesas@ragnatech.se> Message-ID: <1661205.m6h487t3oE@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Niklas, Thank you for the patch. On Tuesday 08 March 2016 03:42:50 Niklas S?derlund wrote: > Slave addresses coming from a client is physical not dma. Store the > address using the correct data type. This is in preparation for hooking > up the dma-mapping API to the slave addresses. > > Signed-off-by: Niklas S?derlund > --- > drivers/dma/sh/rcar-dmac.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/dma/sh/rcar-dmac.c b/drivers/dma/sh/rcar-dmac.c > index 7820d07..01cf82f 100644 > --- a/drivers/dma/sh/rcar-dmac.c > +++ b/drivers/dma/sh/rcar-dmac.c > @@ -144,8 +144,8 @@ struct rcar_dmac_chan { > > unsigned int src_xfer_size; > unsigned int dst_xfer_size; > - dma_addr_t src_slave_addr; > - dma_addr_t dst_slave_addr; > + phys_addr_t src_slave_addr; > + phys_addr_t dst_slave_addr; This moves the cast from phys_addr_t to dma_addr_t from the driver's DMA engine operations to other places. I'm not sure there's much value in doing so. I'd squash this patch with 7/9, the result will be easier to review. > int mid_rid; > > spinlock_t lock; -- Regards, Laurent Pinchart