Linux-ARM-Kernel Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: icenowy@aosc.xyz (Icenowy Zheng)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] mmc: sunxi: change controller error info to debug level
Date: Fri, 24 Mar 2017 15:52:08 +0800	[thread overview]
Message-ID: <1662971490341928@web27j.yandex.ru> (raw)
In-Reply-To: <CAPDyKFppqPjjXtAAcSynxMw-1Oc7W6ZMf=oJLzWwsnLUWCq5Rw@mail.gmail.com>



24.03.2017, 15:46, "Ulf Hansson" <ulf.hansson@linaro.org>:
> On 16 March 2017 at 14:29, Icenowy Zheng <icenowy@aosc.xyz> wrote:
>> ?The controller's errors are usually normal (for example, for MMC or SDIO
>> ?cards, some errors are expected to happen; and for boards without a
>> ?dedicated card detect pin the error info will even flood console and
>> ?hide other normal messages) and hard to understand.
>>
>> ?Change their print level to debug, thus it won't be shown to generic
>> ?users.
>>
>> ?Signed-off-by: Icenowy Zheng <icenowy@aosc.xyz>
>
> For some reason this change didn't enter the mmc patchtracker. However
> I have picked it up for next anyway.

Thanks!

Maybe it's because of the e-mail provider chosen by AOSC (Yandex.Mail).

Sorry. I will try to ask for a migration to other e-mail provider.

>
> Thanks!
>
> Kind regards
> Uffe
>
>> ?---
>> ??drivers/mmc/host/sunxi-mmc.c | 2 +-
>> ??1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> ?diff --git a/drivers/mmc/host/sunxi-mmc.c b/drivers/mmc/host/sunxi-mmc.c
>> ?index 6ffcd2838272..0391c62cc99f 100644
>> ?--- a/drivers/mmc/host/sunxi-mmc.c
>> ?+++ b/drivers/mmc/host/sunxi-mmc.c
>> ?@@ -489,7 +489,7 @@ static void sunxi_mmc_dump_errinfo(struct sunxi_mmc_host *host)
>> ???????????????????????????????????????cmd->opcode == SD_IO_RW_DIRECT))
>> ?????????????????return;
>>
>> ?- dev_err(mmc_dev(host->mmc),
>> ?+ dev_dbg(mmc_dev(host->mmc),
>> ?????????????????"smc %d err, cmd %d,%s%s%s%s%s%s%s%s%s%s !!\n",
>> ?????????????????host->mmc->index, cmd->opcode,
>> ?????????????????data ? (data->flags & MMC_DATA_WRITE ? " WR" : " RD") : "",
>> ?--
>> ?2.12.0

      reply	other threads:[~2017-03-24  7:52 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-16 13:29 [PATCH] mmc: sunxi: change controller error info to debug level Icenowy Zheng
2017-03-20  8:59 ` Maxime Ripard
2017-03-24  7:46 ` Ulf Hansson
2017-03-24  7:52   ` Icenowy Zheng [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1662971490341928@web27j.yandex.ru \
    --to=icenowy@aosc.xyz \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox