Re: [PATCH] soc/tegra: fuse: Export tegra_get_platform() & tegra_is_silicon()

Thierry Reding
2022-10-20T09:55:29Z

[-- Attachment #1.1: Type: text/plain, Size: 1686 bytes --]

On Mon, Sep 26, 2022 at 03:35:59PM +0530, Kartik wrote:
> Functions tegra_get_platform() and tegra_is_silicon() are required
> for pre-silicon development to correctly identify the platform on
> which the software is running.
>
> Export tegra_get_platform() and tegra_is_silicon(), so they can be
> used for pre-slicon development of device drivers and kernel space
> tests.
>
> Signed-off-by: Kartik <kkartik@nvidia.com>
> ---
> drivers/soc/tegra/fuse/tegra-apbmisc.c | 2 ++
> 1 file changed, 2 insertions(+)

Hi Arnd, Olof,

can you take a quick look at this and provide some feedback regarding
acceptance? It's slightly unorthodox because the only in-tree users of
these functions are built-in drivers and early code, so they don't
technically need to be exported for strictly in-kernel users. However,
we do see these used quite frequently in pre-silicon development and
having these available upstream would help with internal kernel
transitions and so on. We may also see them used more commonly in
upstream drivers in the future.

Thierry

> diff --git a/drivers/soc/tegra/fuse/tegra-apbmisc.c b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> index 3351bd872ab2..904797f651a1 100644
> --- a/drivers/soc/tegra/fuse/tegra-apbmisc.c
> +++ b/drivers/soc/tegra/fuse/tegra-apbmisc.c
> @@ -56,6 +56,7 @@ u8 tegra_get_platform(void)
> {
> return (tegra_read_chipid() >> 20) & 0xf;
> }
> +EXPORT_SYMBOL(tegra_get_platform);
>
> bool tegra_is_silicon(void)
> {
> @@ -76,6 +77,7 @@ bool tegra_is_silicon(void)
> */
> return true;
> }
> +EXPORT_SYMBOL(tegra_is_silicon);
>
> u32 tegra_read_straps(void)
> {
> --
> 2.17.1
>

[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

[-- Attachment #2: Type: text/plain, Size: 176 bytes --]