Re: [PATCH] soc/tegra: fuse: Export tegra_get_platform() & tegra_is_silicon()

Arnd Bergmann
2022-10-20T09:59:22Z

On Thu, Oct 20, 2022, at 11:54, Thierry Reding wrote:
> On Mon, Sep 26, 2022 at 03:35:59PM +0530, Kartik wrote:
>> Functions tegra_get_platform() and tegra_is_silicon() are required
>> for pre-silicon development to correctly identify the platform on
>> which the software is running.
>>
>> Export tegra_get_platform() and tegra_is_silicon(), so they can be
>> used for pre-slicon development of device drivers and kernel space
>> tests.
>>
>> Signed-off-by: Kartik <kkartik@nvidia.com>
>> ---
>> drivers/soc/tegra/fuse/tegra-apbmisc.c | 2 ++
>> 1 file changed, 2 insertions(+)
>
> Hi Arnd, Olof,
>
> can you take a quick look at this and provide some feedback regarding
> acceptance? It's slightly unorthodox because the only in-tree users of
> these functions are built-in drivers and early code, so they don't
> technically need to be exported for strictly in-kernel users. However,
> we do see these used quite frequently in pre-silicon development and
> having these available upstream would help with internal kernel
> transitions and so on. We may also see them used more commonly in
> upstream drivers in the future.

Hi Thierry and Kartik,

Have you looked at using soc_device_match() instead?

As long as the information is part of the soc_device_attribute
prvoided by the soc info driver, any other kernel driver should
be able to just use string matching to get what you need here.

Arnd