From: laurent.pinchart@ideasonboard.com (Laurent Pinchart)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: shmobile: lager: Correct setting of ethernet PHY LED mode
Date: Tue, 08 Apr 2014 14:07:49 +0200 [thread overview]
Message-ID: <1665021.dQPpZ5R559@avalon> (raw)
In-Reply-To: <1396916495-13018-1-git-send-email-horms+renesas@verge.net.au>
Hi Simon,
On Tuesday 08 April 2014 09:21:35 Simon Horman wrote:
> The correct binding is "micrel,led-mode", not "led-mode".
>
> This corrects an error which was introduced when setting of ethernet PHY
> LED mode was added by 82e62182d59bd1d0 ("ARM: shmobile: lager: Set ethernet
> PHY LED mode").
Indeed. I wonder how I've missed that... :-( Sorry.
> This makes the lager code consistent with the koelsch code which was added
> by ae00d12a032490b3 ("ARM: shmobile: koelsch: Set ethernet PHY LED mode").
>
> Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
>
> * This is compile tested only (which is of negligible value)
> as I do not have physical access to a Lager board.
> ---
> arch/arm/boot/dts/r8a7790-lager.dts | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/boot/dts/r8a7790-lager.dts
> b/arch/arm/boot/dts/r8a7790-lager.dts index a55c5f8..265cba1 100644
> --- a/arch/arm/boot/dts/r8a7790-lager.dts
> +++ b/arch/arm/boot/dts/r8a7790-lager.dts
> @@ -213,7 +213,7 @@
> reg = <1>;
> interrupt-parent = <&irqc0>;
> interrupts = <0 IRQ_TYPE_LEVEL_LOW>;
> - led-mode = <1>;
> + micrel,led-mode = <1>;
> };
> };
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2014-04-08 12:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-04-08 0:21 [PATCH] ARM: shmobile: lager: Correct setting of ethernet PHY LED mode Simon Horman
2014-04-08 12:07 ` Laurent Pinchart [this message]
2014-04-09 6:15 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1665021.dQPpZ5R559@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox