public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
* [PATCH] ARM: integrator: remove unused variable
@ 2015-01-30 21:59 Arnd Bergmann
  2015-01-30 22:15 ` Bjorn Helgaas
  0 siblings, 1 reply; 2+ messages in thread
From: Arnd Bergmann @ 2015-01-30 21:59 UTC (permalink / raw)
  To: linux-arm-kernel

The patch to add the new generic config space accessors removed
a useless spinlock, but left the flags variable in place, which
now causes a build warning:

arch/arm/mach-integrator/pci_v3.c: In function 'pci_v3_preinit':
arch/arm/mach-integrator/pci_v3.c:614:16: warning: unused variable 'flags' [-Wunused-variable]

This removes it.

Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Fixes: 1ba525109219 ("ARM: integrator: Convert PCI to use generic config accessors")

diff --git a/arch/arm/mach-integrator/pci_v3.c b/arch/arm/mach-integrator/pci_v3.c
index dc7782f26cbb..2565f0e7b5cf 100644
--- a/arch/arm/mach-integrator/pci_v3.c
+++ b/arch/arm/mach-integrator/pci_v3.c
@@ -611,7 +611,6 @@ static int __init pci_v3_setup(int nr, struct pci_sys_data *sys)
  */
 static void __init pci_v3_preinit(void)
 {
-	unsigned long flags;
 	unsigned int temp;
 	phys_addr_t io_address = pci_pio_to_address(io_mem.start);
 

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* [PATCH] ARM: integrator: remove unused variable
  2015-01-30 21:59 [PATCH] ARM: integrator: remove unused variable Arnd Bergmann
@ 2015-01-30 22:15 ` Bjorn Helgaas
  0 siblings, 0 replies; 2+ messages in thread
From: Bjorn Helgaas @ 2015-01-30 22:15 UTC (permalink / raw)
  To: linux-arm-kernel

On Fri, Jan 30, 2015 at 3:59 PM, Arnd Bergmann <arnd@arndb.de> wrote:
> The patch to add the new generic config space accessors removed
> a useless spinlock, but left the flags variable in place, which
> now causes a build warning:
>
> arch/arm/mach-integrator/pci_v3.c: In function 'pci_v3_preinit':
> arch/arm/mach-integrator/pci_v3.c:614:16: warning: unused variable 'flags' [-Wunused-variable]
>
> This removes it.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> Fixes: 1ba525109219 ("ARM: integrator: Convert PCI to use generic config accessors")

Folded in, thanks!

>
> diff --git a/arch/arm/mach-integrator/pci_v3.c b/arch/arm/mach-integrator/pci_v3.c
> index dc7782f26cbb..2565f0e7b5cf 100644
> --- a/arch/arm/mach-integrator/pci_v3.c
> +++ b/arch/arm/mach-integrator/pci_v3.c
> @@ -611,7 +611,6 @@ static int __init pci_v3_setup(int nr, struct pci_sys_data *sys)
>   */
>  static void __init pci_v3_preinit(void)
>  {
> -       unsigned long flags;
>         unsigned int temp;
>         phys_addr_t io_address = pci_pio_to_address(io_mem.start);
>
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2015-01-30 22:15 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-01-30 21:59 [PATCH] ARM: integrator: remove unused variable Arnd Bergmann
2015-01-30 22:15 ` Bjorn Helgaas

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox