From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 269A3C32772 for ; Tue, 23 Aug 2022 08:45:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:From:References:Cc:To: Subject:MIME-Version:Date:Message-ID:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=UinMUG/hHGFfeU5MgEsfiwqxqLpP1Gr2i0cCPJ9fd1I=; b=OIYoV/8N4ikE/S F+Tw61jt7Gy31KOhsGCex3bciCuTXlxBu75JQUCc6YMFXdxgZwKFjh6V7DW9MXkV5vGUUdO1re82b 6wXNCkxtk7Cv628zulKd8yoBXMZscVxX4t4O0Mi484lW/T+FfuM66UF9jUOfvnGfSg4ii3lxn53yd Mbed2qbNPAR2QhiNoGt/y3BTGZ3o8IbrsI388XARNy287zVnm/8+IRi3NUDGcUS8Da42SXKYV7tfL UJY/Bzn0qFjqEGzNXvllen6yQvrF2SKIGELe33WmCh2lmVLPEgAkGxaBIWRjov7b1TfEXGuCaSDoK ACAJeCTBwBWoonS/GU1g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQPWJ-0048wL-VX; Tue, 23 Aug 2022 08:44:24 +0000 Received: from mail-lf1-x131.google.com ([2a00:1450:4864:20::131]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1oQPWF-0048so-Dg for linux-arm-kernel@lists.infradead.org; Tue, 23 Aug 2022 08:44:21 +0000 Received: by mail-lf1-x131.google.com with SMTP id l1so18191913lfk.8 for ; Tue, 23 Aug 2022 01:44:19 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc; bh=wLOhMX2dSEteMTksjEMlhBF251+OnM4n2eaNqEAOV54=; b=PknsZfB6W2EJKNNwKk7QEfdH1d2OoV+QRXFjgxHK1if5lCTlkHp72zKFrc/8sO8TYT BtFCqylmbj1htRf493fkeFyBOAMPb+XASiSyDLDIERf1hfLCkLjsTGDPH/c+gRzQVfM7 wYSVmVVKef5jui3VQdQM1JoXM+ahK/u/OjLsvZ1+KCXFZWGU1zr0qX+VVHQGn0cIhSec MeVYYk/U4m5nxRhUcaUhnxIo5rp81h0bzYVAiC044n3pYgb3kpkgM1YUv21KDg2rdyyG DATXjWQOI18vlPP1La/MPvkQRTjgBmGFxg/supoG91p66au28uNYozhaYsY9jmkiy/AW QJ4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc; bh=wLOhMX2dSEteMTksjEMlhBF251+OnM4n2eaNqEAOV54=; b=uBKh7HDfssjq2sUzpOZudjGzj5+YkWP7ZV92nuL9cjJrpYWF5TF/LG7oZa+pwuug7m 1fXZNXLQ3MOVN3+xhyIYlJXhaYdm1NNYaWW1PRmUVQEtbGuUvc/O4mJIiWbhkwbWSem1 tQfvz78QhUVSEXaDOP2I1RPEsWUmFMG18aYNYIOFiy6DIF0Y0h6aETqrbK0RGIYMyUPM Bo15TJTIH7r1v/QTYSdpewDpRyHR3nU43p0+QeMp8DtfYW0rAI+HdlkLJFe7QA0i/+C+ Tp0+2Uc9H/WslSBcv8WsLtdWl7Zb7zLUcT+ew4i21ScA2fF7DJGKhUm6PvPZZzNeCFMu 14tw== X-Gm-Message-State: ACgBeo15z/aZfe7BpMMQ5ylj7LkGP7AzIqqmmHAx2pgMTt8VGLEX8+VS 4ayXFYFlmAJLysg5H5caNARVfA== X-Google-Smtp-Source: AA6agR7hl1CGI7r2CQqS6Ira4/M3Fw4abVlO0e7P1ZL3XHG/Tl7iMks/nNyA7kdEi1FrOfgHE/v3gQ== X-Received: by 2002:a05:6512:2356:b0:492:e06d:7530 with SMTP id p22-20020a056512235600b00492e06d7530mr3420177lfu.103.1661244257706; Tue, 23 Aug 2022 01:44:17 -0700 (PDT) Received: from [192.168.0.11] (89-27-92-210.bb.dnainternet.fi. [89.27.92.210]) by smtp.gmail.com with ESMTPSA id w9-20020a05651203c900b0048b0bf9f4bfsm2392165lfp.140.2022.08.23.01.44.16 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 23 Aug 2022 01:44:17 -0700 (PDT) Message-ID: <166c0198-17c4-3b19-77fe-632d65f17cb0@linaro.org> Date: Tue, 23 Aug 2022 11:44:16 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.12.0 Subject: Re: [PATCH 16/20] dt-bindings: memory: snps: Detach Zynq DDRC controller support Content-Language: en-US To: Serge Semin Cc: Serge Semin , Rob Herring , Michal Simek , Borislav Petkov , Mauro Carvalho Chehab , Tony Luck , Rob Herring , Manish Narani , Alexey Malahov , Michail Ivanov , Pavel Parkhomenko , Punnaiah Choudary Kalluri , Dinh Nguyen , James Morse , Robert Richter , Krzysztof Kozlowski , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org References: <20220822190730.27277-1-Sergey.Semin@baikalelectronics.ru> <20220822190730.27277-17-Sergey.Semin@baikalelectronics.ru> <20220823083243.aovlgu22j7uv73qv@mobilestation> From: Krzysztof Kozlowski In-Reply-To: <20220823083243.aovlgu22j7uv73qv@mobilestation> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220823_014419_497031_A562FFE6 X-CRM114-Status: GOOD ( 19.27 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 23/08/2022 11:32, Serge Semin wrote: > On Tue, Aug 23, 2022 at 11:17:23AM +0300, Krzysztof Kozlowski wrote: >> On 22/08/2022 22:07, Serge Semin wrote: >>> The Zynq A05 DDRC controller has nothing in common with DW uMCTL2 DDRC: >>> the CSRs layout is absolutely different and it doesn't has IRQ unlike DW >>> uMCTL2 DDR controller of all versions (v1.x, v2.x and v3.x). Thus there is >>> no any reason to have these controllers described by the same bindings. >>> Thus let's split them up. >>> >>> While at it rename the original Synopsys uMCTL2 DT-schema file to a more >>> descriptive - snps,dw-umctl2-ddrc.yaml and add a more detailed title and >>> description of the device bindings. >> > >> Filename should be based on compatible, so if renaming then >> snps,ddrc-3.80a.yaml or snps,ddrc.yaml... which leads to original >> filename anyway. Therefore nack for rename. > > New requirement? I've submitted not a single patch to the DT-bindings > sources and didn't get any comment from Rob about that. This is not a new requirement. It has been since some time and Rob gave such reviews. https://lore.kernel.org/linux-devicetree/YlhkwvGdcf4ozTzG@robh.at.kernel.org/ For devices with multiple compatibles that's a bit tricky, but assuming the bindings describe both original design from Synopsys and it's implementations, then something closer to Synopsys makes sense. > In addition > There are DT bindings with names different from what is defined in the > compatible name. Moreover there are tons of bindings with various > compatible names. What name to choose then? Finally the current name > is too generic to use for actual DW uMCTL2 DDRC controller. There are thousands of bugs, inconsistencies, naming differences in kernel. I don't find these as arguments to repeat the practice...so the bindings file name should be based on the compatible. Best regards, Krzysztof _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel