* [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators
2025-04-09 13:41 [PATCH v2 0/7] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
@ 2025-04-09 13:41 ` Yemike Abhilash Chandra
2025-04-11 13:32 ` Francis, Neha
2025-04-11 13:34 ` Kumar, Udit
2025-04-09 13:41 ` [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy Yemike Abhilash Chandra
` (5 subsequent siblings)
6 siblings, 2 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-09 13:41 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1,
Yemike Abhilash Chandra, stable
Add device tree nodes for two power regulators on the J721E SK board.
vsys_5v0: A fixed regulator representing the 5V supply output from the
LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator.
J721E-SK schematics: https://www.ti.com/lit/zip/sprr438
Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK")
Cc: stable@vger.kernel.org
Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++
1 file changed, 31 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
index 440ef57be294..4965957e6545 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
@@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 {
regulator-boot-on;
};
+ vsys_5v0: fixedregulator-vsys5v0 {
+ /* Output of LM61460 */
+ compatible = "regulator-fixed";
+ regulator-name = "vsys_5v0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vusb_main>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
vdd_mmc1: fixedregulator-sd {
compatible = "regulator-fixed";
pinctrl-names = "default";
@@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 {
<3300000 0x1>;
};
+ vdd_sd_dv: gpio-regulator-TLV71033 {
+ compatible = "regulator-gpio";
+ pinctrl-names = "default";
+ pinctrl-0 = <&vdd_sd_dv_pins_default>;
+ regulator-name = "tlv71033";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <3300000>;
+ regulator-boot-on;
+ vin-supply = <&vsys_5v0>;
+ gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>;
+ states = <1800000 0x0>,
+ <3300000 0x1>;
+ };
+
transceiver1: can-phy1 {
compatible = "ti,tcan1042";
#phy-cells = <0>;
@@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */
>;
};
+ vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
+ pinctrl-single,pins = <
+ J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
+ >;
+ };
+
wkup_uart0_pins_default: wkup-uart0-default-pins {
pinctrl-single,pins = <
J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators
2025-04-09 13:41 ` [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators Yemike Abhilash Chandra
@ 2025-04-11 13:32 ` Francis, Neha
2025-04-11 13:34 ` Kumar, Udit
1 sibling, 0 replies; 24+ messages in thread
From: Francis, Neha @ 2025-04-11 13:32 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
Hi Abhilash
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> Add device tree nodes for two power regulators on the J721E SK board.
> vsys_5v0: A fixed regulator representing the 5V supply output from the
> LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator.
>
> J721E-SK schematics: https://www.ti.com/lit/zip/sprr438
> Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 440ef57be294..4965957e6545 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 {
> regulator-boot-on;
> };
>
> + vsys_5v0: fixedregulator-vsys5v0 {
> + /* Output of LM61460 */
> + compatible = "regulator-fixed";
> + regulator-name = "vsys_5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&vusb_main>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> vdd_mmc1: fixedregulator-sd {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> @@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 {
> <3300000 0x1>;
> };
>
> + vdd_sd_dv: gpio-regulator-TLV71033 {
> + compatible = "regulator-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&vdd_sd_dv_pins_default>;
> + regulator-name = "tlv71033";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + vin-supply = <&vsys_5v0>;
> + gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>;
> + states = <1800000 0x0>,
> + <3300000 0x1>;
> + };
> +
> transceiver1: can-phy1 {
> compatible = "ti,tcan1042";
> #phy-cells = <0>;
> @@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */
> >;
> };
>
> + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> + pinctrl-single,pins = <
> + J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
> + >;
> + };
> +
> wkup_uart0_pins_default: wkup-uart0-default-pins {
> pinctrl-single,pins = <
> J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators
2025-04-09 13:41 ` [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators Yemike Abhilash Chandra
2025-04-11 13:32 ` Francis, Neha
@ 2025-04-11 13:34 ` Kumar, Udit
2025-04-14 11:50 ` Yemike Abhilash Chandra
1 sibling, 1 reply; 24+ messages in thread
From: Kumar, Udit @ 2025-04-11 13:34 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, stable, u-kumar1
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> Add device tree nodes for two power regulators on the J721E SK board.
> vsys_5v0: A fixed regulator representing the 5V supply output from the
> LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator.
>
> J721E-SK schematics: https://www.ti.com/lit/zip/sprr438
> Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK")
For me does not looks like a fix, you can adding missing nodes
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++
> 1 file changed, 31 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> index 440ef57be294..4965957e6545 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
> @@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 {
> regulator-boot-on;
> };
>
> + vsys_5v0: fixedregulator-vsys5v0 {
> + /* Output of LM61460 */
> + compatible = "regulator-fixed";
> + regulator-name = "vsys_5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&vusb_main>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> vdd_mmc1: fixedregulator-sd {
> compatible = "regulator-fixed";
> pinctrl-names = "default";
> @@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 {
> <3300000 0x1>;
> };
>
> + vdd_sd_dv: gpio-regulator-TLV71033 {
> + compatible = "regulator-gpio";
> + pinctrl-names = "default";
> + pinctrl-0 = <&vdd_sd_dv_pins_default>;
> + regulator-name = "tlv71033";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <3300000>;
> + regulator-boot-on;
> + vin-supply = <&vsys_5v0>;
> + gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>;
> + states = <1800000 0x0>,
> + <3300000 0x1>;
> + };
> +
> transceiver1: can-phy1 {
> compatible = "ti,tcan1042";
> #phy-cells = <0>;
> @@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26) WKUP_GPIO0_9 */
> >;
> };
>
> + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
> + pinctrl-single,pins = <
> + J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1) SPI1_CLK.GPIO0_118 */
Shouldn't be this pin be output to control regulator ?
> + >;
> + };
> +
> wkup_uart0_pins_default: wkup-uart0-default-pins {
> pinctrl-single,pins = <
> J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29) WKUP_UART0_RXD */
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators
2025-04-11 13:34 ` Kumar, Udit
@ 2025-04-14 11:50 ` Yemike Abhilash Chandra
0 siblings, 0 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-14 11:50 UTC (permalink / raw)
To: Kumar, Udit, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, stable
Hi Udit,
On 11/04/25 19:04, Kumar, Udit wrote:
>
> On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
>> Add device tree nodes for two power regulators on the J721E SK board.
>> vsys_5v0: A fixed regulator representing the 5V supply output from the
>> LM61460 and vdd_sd_dv: A GPIO-controlled TLV71033 regulator.
>>
>> J721E-SK schematics: https://www.ti.com/lit/zip/sprr438
>> Fixes: 1bfda92a3a36 ("arm64: dts: ti: Add support for J721E SK")
>
> For me does not looks like a fix, you can adding missing nodes
>
Since we are adding the regulator nodes in the sensor overlay, (Patch 4
of this series) which in turn references these regulator nodes, I have
included the Fixes tag in this patch as well.
>
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>> ---
>> arch/arm64/boot/dts/ti/k3-j721e-sk.dts | 31 ++++++++++++++++++++++++++
>> 1 file changed, 31 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
>> b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
>> index 440ef57be294..4965957e6545 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk.dts
>> @@ -184,6 +184,17 @@ vsys_3v3: fixedregulator-vsys3v3 {
>> regulator-boot-on;
>> };
>> + vsys_5v0: fixedregulator-vsys5v0 {
>> + /* Output of LM61460 */
>> + compatible = "regulator-fixed";
>> + regulator-name = "vsys_5v0";
>> + regulator-min-microvolt = <5000000>;
>> + regulator-max-microvolt = <5000000>;
>> + vin-supply = <&vusb_main>;
>> + regulator-always-on;
>> + regulator-boot-on;
>> + };
>> +
>> vdd_mmc1: fixedregulator-sd {
>> compatible = "regulator-fixed";
>> pinctrl-names = "default";
>> @@ -211,6 +222,20 @@ vdd_sd_dv_alt: gpio-regulator-tps659411 {
>> <3300000 0x1>;
>> };
>> + vdd_sd_dv: gpio-regulator-TLV71033 {
>> + compatible = "regulator-gpio";
>> + pinctrl-names = "default";
>> + pinctrl-0 = <&vdd_sd_dv_pins_default>;
>> + regulator-name = "tlv71033";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <3300000>;
>> + regulator-boot-on;
>> + vin-supply = <&vsys_5v0>;
>> + gpios = <&main_gpio0 118 GPIO_ACTIVE_HIGH>;
>> + states = <1800000 0x0>,
>> + <3300000 0x1>;
>> + };
>> +
>> transceiver1: can-phy1 {
>> compatible = "ti,tcan1042";
>> #phy-cells = <0>;
>> @@ -613,6 +638,12 @@ J721E_WKUP_IOPAD(0xd4, PIN_OUTPUT, 7) /* (G26)
>> WKUP_GPIO0_9 */
>> >;
>> };
>> + vdd_sd_dv_pins_default: vdd-sd-dv-default-pins {
>> + pinctrl-single,pins = <
>> + J721E_IOPAD(0x1dc, PIN_INPUT, 7) /* (Y1)
>> SPI1_CLK.GPIO0_118 */
>
> Shouldn't be this pin be output to control regulator ?
>
Yes, I will correct this in the next revision.
Thanks and Regards
Yemike Abhilash Chandra
>
>> + >;
>> + };
>> +
>> wkup_uart0_pins_default: wkup-uart0-default-pins {
>> pinctrl-single,pins = <
>> J721E_WKUP_IOPAD(0xa0, PIN_INPUT, 0) /* (J29)
>> WKUP_UART0_RXD */
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy
2025-04-09 13:41 [PATCH v2 0/7] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
2025-04-09 13:41 ` [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators Yemike Abhilash Chandra
@ 2025-04-09 13:41 ` Yemike Abhilash Chandra
2025-04-11 13:46 ` Kumar, Udit
` (2 more replies)
2025-04-09 13:41 ` [PATCH v2 3/7] arm64: dts: ti: k3-j721e-sk: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
` (4 subsequent siblings)
6 siblings, 3 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-09 13:41 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1,
Yemike Abhilash Chandra, stable
Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to
LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for
the LM61460 5V supply to support this change.
AM68-SK schematics: https://www.ti.com/lit/zip/sprr463
Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
Cc: stable@vger.kernel.org
Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++-
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
index 11522b36e0ce..5fa70a874d7b 100644
--- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
+++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
@@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 {
regulator-boot-on;
};
+ vsys_5v0: regulator-vsys5v0 {
+ /* Output of LM61460 */
+ compatible = "regulator-fixed";
+ regulator-name = "vsys_5v0";
+ regulator-min-microvolt = <5000000>;
+ regulator-max-microvolt = <5000000>;
+ vin-supply = <&vusb_main>;
+ regulator-always-on;
+ regulator-boot-on;
+ };
+
vsys_3v3: regulator-vsys3v3 {
/* Output of LM5141 */
compatible = "regulator-fixed";
@@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 {
regulator-min-microvolt = <1800000>;
regulator-max-microvolt = <3300000>;
regulator-boot-on;
- vin-supply = <&vsys_3v3>;
+ vin-supply = <&vsys_5v0>;
gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>;
states = <1800000 0x0>,
<3300000 0x1>;
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy
2025-04-09 13:41 ` [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy Yemike Abhilash Chandra
@ 2025-04-11 13:46 ` Kumar, Udit
2025-04-11 13:50 ` Francis, Neha
2025-04-11 17:29 ` Kumar, Udit
2 siblings, 0 replies; 24+ messages in thread
From: Kumar, Udit @ 2025-04-11 13:46 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, stable
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to
> LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for
> the LM61460 5V supply to support this change.
>
> AM68-SK schematics: https://www.ti.com/lit/zip/sprr463
> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 11522b36e0ce..5fa70a874d7b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 {
> regulator-boot-on;
> };
>
> + vsys_5v0: regulator-vsys5v0 {
> + /* Output of LM61460 */
> + compatible = "regulator-fixed";
> + regulator-name = "vsys_5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&vusb_main>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> vsys_3v3: regulator-vsys3v3 {
> /* Output of LM5141 */
> compatible = "regulator-fixed";
> @@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> - vin-supply = <&vsys_3v3>;
> + vin-supply = <&vsys_5v0>;
Looking at schematic page -3
USB PD Controller is giving input to LM61460 , LM5141(3V3), and TPS62177.
Could you please recheck this, vin-supply for 3v3 regulator
Thanks
Udit
> gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>;
> states = <1800000 0x0>,
> <3300000 0x1>;
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy
2025-04-09 13:41 ` [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy Yemike Abhilash Chandra
2025-04-11 13:46 ` Kumar, Udit
@ 2025-04-11 13:50 ` Francis, Neha
2025-04-11 17:29 ` Kumar, Udit
2 siblings, 0 replies; 24+ messages in thread
From: Francis, Neha @ 2025-04-11 13:50 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to
> LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for
> the LM61460 5V supply to support this change.
>
> AM68-SK schematics: https://www.ti.com/lit/zip/sprr463
> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 11522b36e0ce..5fa70a874d7b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 {
> regulator-boot-on;
> };
>
> + vsys_5v0: regulator-vsys5v0 {
> + /* Output of LM61460 */
> + compatible = "regulator-fixed";
> + regulator-name = "vsys_5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&vusb_main>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> vsys_3v3: regulator-vsys3v3 {
> /* Output of LM5141 */
> compatible = "regulator-fixed";
> @@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> - vin-supply = <&vsys_3v3>;
> + vin-supply = <&vsys_5v0>;
> gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>;
> states = <1800000 0x0>,
> <3300000 0x1>;
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy
2025-04-09 13:41 ` [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy Yemike Abhilash Chandra
2025-04-11 13:46 ` Kumar, Udit
2025-04-11 13:50 ` Francis, Neha
@ 2025-04-11 17:29 ` Kumar, Udit
2 siblings, 0 replies; 24+ messages in thread
From: Kumar, Udit @ 2025-04-11 17:29 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, stable, u-kumar1
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> Update the vin-supply of the TLV71033 regulator from LM5141 (vsys_3v3) to
> LM61460 (vsys_5v0) to match the schematics. Add a fixed regulator node for
> the LM61460 5V supply to support this change.
>
> AM68-SK schematics: https://www.ti.com/lit/zip/sprr463
> Fixes: a266c180b398 ("arm64: dts: ti: k3-am68-sk: Add support for AM68 SK base board")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> index 11522b36e0ce..5fa70a874d7b 100644
> --- a/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am68-sk-base-board.dts
> @@ -44,6 +44,17 @@ vusb_main: regulator-vusb-main5v0 {
> regulator-boot-on;
> };
>
> + vsys_5v0: regulator-vsys5v0 {
> + /* Output of LM61460 */
> + compatible = "regulator-fixed";
> + regulator-name = "vsys_5v0";
> + regulator-min-microvolt = <5000000>;
> + regulator-max-microvolt = <5000000>;
> + vin-supply = <&vusb_main>;
> + regulator-always-on;
> + regulator-boot-on;
> + };
> +
> vsys_3v3: regulator-vsys3v3 {
> /* Output of LM5141 */
> compatible = "regulator-fixed";
> @@ -76,7 +87,7 @@ vdd_sd_dv: regulator-tlv71033 {
> regulator-min-microvolt = <1800000>;
> regulator-max-microvolt = <3300000>;
> regulator-boot-on;
> - vin-supply = <&vsys_3v3>;
> + vin-supply = <&vsys_5v0>;
> gpios = <&main_gpio0 49 GPIO_ACTIVE_HIGH>;
Please ignore previous comment , I realized you are changing parent for
tlv71033 not for vsys_3v3.
With that
Reviewed-by: Udit Kumar <u-kumar1@ti.com>
> states = <1800000 0x0>,
> <3300000 0x1>;
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 3/7] arm64: dts: ti: k3-j721e-sk: Remove clock-names property from IMX219 overlay
2025-04-09 13:41 [PATCH v2 0/7] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
2025-04-09 13:41 ` [PATCH v2 1/7] arm64: dts: ti: j721e-sk: Add DT nodes for power regulators Yemike Abhilash Chandra
2025-04-09 13:41 ` [PATCH v2 2/7] arm64: dts: ti: am68-sk: Fix regulator hierarchy Yemike Abhilash Chandra
@ 2025-04-09 13:41 ` Yemike Abhilash Chandra
2025-04-11 13:36 ` Francis, Neha
2025-04-14 6:47 ` Jai Luthra
2025-04-09 13:41 ` [PATCH v2 4/7] arm64: dts: ti: k3-j721e-sk: Add requiried voltage supplies for IMX219 Yemike Abhilash Chandra
` (3 subsequent siblings)
6 siblings, 2 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-09 13:41 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1,
Yemike Abhilash Chandra, stable
The IMX219 sensor device tree bindings do not include a clock-names
property. Remove the incorrectly added clock-names entry to avoid
dtbs_check warnings.
Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
Cc: stable@vger.kernel.org
Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 2 --
1 file changed, 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
index 47bb5480b5b0..4a395d1209c8 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
@@ -34,7 +34,6 @@ imx219_0: imx219-0@10 {
reg = <0x10>;
clocks = <&clk_imx219_fixed>;
- clock-names = "xclk";
port {
csi2_cam0: endpoint {
@@ -56,7 +55,6 @@ imx219_1: imx219-1@10 {
reg = <0x10>;
clocks = <&clk_imx219_fixed>;
- clock-names = "xclk";
port {
csi2_cam1: endpoint {
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 3/7] arm64: dts: ti: k3-j721e-sk: Remove clock-names property from IMX219 overlay
2025-04-09 13:41 ` [PATCH v2 3/7] arm64: dts: ti: k3-j721e-sk: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
@ 2025-04-11 13:36 ` Francis, Neha
2025-04-14 6:47 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Francis, Neha @ 2025-04-11 13:36 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> The IMX219 sensor device tree bindings do not include a clock-names
> property. Remove the incorrectly added clock-names entry to avoid
> dtbs_check warnings.
>
> Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> index 47bb5480b5b0..4a395d1209c8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> @@ -34,7 +34,6 @@ imx219_0: imx219-0@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
>
> port {
> csi2_cam0: endpoint {
> @@ -56,7 +55,6 @@ imx219_1: imx219-1@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
>
> port {
> csi2_cam1: endpoint {
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 3/7] arm64: dts: ti: k3-j721e-sk: Remove clock-names property from IMX219 overlay
2025-04-09 13:41 ` [PATCH v2 3/7] arm64: dts: ti: k3-j721e-sk: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
2025-04-11 13:36 ` Francis, Neha
@ 2025-04-14 6:47 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Jai Luthra @ 2025-04-14 6:47 UTC (permalink / raw)
To: Yemike Abhilash Chandra
Cc: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, vaishnav.a,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
[-- Attachment #1: Type: text/plain, Size: 1315 bytes --]
Hi Abhilash,
Thanks for the fix.
On Wed, Apr 09, 2025 at 07:11:24PM +0530, Yemike Abhilash Chandra wrote:
> The IMX219 sensor device tree bindings do not include a clock-names
> property. Remove the incorrectly added clock-names entry to avoid
> dtbs_check warnings.
>
> Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Jai Luthra <jai.luthra@linux.dev>
> ---
> arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> index 47bb5480b5b0..4a395d1209c8 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> @@ -34,7 +34,6 @@ imx219_0: imx219-0@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
>
> port {
> csi2_cam0: endpoint {
> @@ -56,7 +55,6 @@ imx219_1: imx219-1@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
>
> port {
> csi2_cam1: endpoint {
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 4/7] arm64: dts: ti: k3-j721e-sk: Add requiried voltage supplies for IMX219
2025-04-09 13:41 [PATCH v2 0/7] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
` (2 preceding siblings ...)
2025-04-09 13:41 ` [PATCH v2 3/7] arm64: dts: ti: k3-j721e-sk: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
@ 2025-04-09 13:41 ` Yemike Abhilash Chandra
2025-04-11 13:38 ` Francis, Neha
2025-04-09 13:41 ` [PATCH v2 5/7] arm64: dts: ti: k3-am62x: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
` (2 subsequent siblings)
6 siblings, 1 reply; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-09 13:41 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1,
Yemike Abhilash Chandra, stable
The device tree overlay for the IMX219 sensor requires three voltage
supplies to be defined: VANA (analog), VDIG (digital core), and VDDL
(digital I/O). Add the corresponding voltage supply definitions to avoid
dtbs_check warnings.
Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
Cc: stable@vger.kernel.org
Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
.../dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 33 +++++++++++++++++++
1 file changed, 33 insertions(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
index 4a395d1209c8..4eb3cffab032 100644
--- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
+++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
@@ -19,6 +19,33 @@ clk_imx219_fixed: imx219-xclk {
#clock-cells = <0>;
clock-frequency = <24000000>;
};
+
+ reg_2p8v: regulator-2p8v {
+ compatible = "regulator-fixed";
+ regulator-name = "2P8V";
+ regulator-min-microvolt = <2800000>;
+ regulator-max-microvolt = <2800000>;
+ vin-supply = <&vdd_sd_dv>;
+ regulator-always-on;
+ };
+
+ reg_1p8v: regulator-1p8v {
+ compatible = "regulator-fixed";
+ regulator-name = "1P8V";
+ regulator-min-microvolt = <1800000>;
+ regulator-max-microvolt = <1800000>;
+ vin-supply = <&vdd_sd_dv>;
+ regulator-always-on;
+ };
+
+ reg_1p2v: regulator-1p2v {
+ compatible = "regulator-fixed";
+ regulator-name = "1P2V";
+ regulator-min-microvolt = <1200000>;
+ regulator-max-microvolt = <1200000>;
+ vin-supply = <&vdd_sd_dv>;
+ regulator-always-on;
+ };
};
&csi_mux {
@@ -34,6 +61,9 @@ imx219_0: imx219-0@10 {
reg = <0x10>;
clocks = <&clk_imx219_fixed>;
+ VANA-supply = <®_2p8v>;
+ VDIG-supply = <®_1p8v>;
+ VDDL-supply = <®_1p2v>;
port {
csi2_cam0: endpoint {
@@ -55,6 +85,9 @@ imx219_1: imx219-1@10 {
reg = <0x10>;
clocks = <&clk_imx219_fixed>;
+ VANA-supply = <®_2p8v>;
+ VDIG-supply = <®_1p8v>;
+ VDDL-supply = <®_1p2v>;
port {
csi2_cam1: endpoint {
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 4/7] arm64: dts: ti: k3-j721e-sk: Add requiried voltage supplies for IMX219
2025-04-09 13:41 ` [PATCH v2 4/7] arm64: dts: ti: k3-j721e-sk: Add requiried voltage supplies for IMX219 Yemike Abhilash Chandra
@ 2025-04-11 13:38 ` Francis, Neha
2025-04-14 11:40 ` Yemike Abhilash Chandra
0 siblings, 1 reply; 24+ messages in thread
From: Francis, Neha @ 2025-04-11 13:38 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> The device tree overlay for the IMX219 sensor requires three voltage
> supplies to be defined: VANA (analog), VDIG (digital core), and VDDL
> (digital I/O). Add the corresponding voltage supply definitions to avoid
> dtbs_check warnings.
>
> Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> .../dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 33 +++++++++++++++++++
> 1 file changed, 33 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> index 4a395d1209c8..4eb3cffab032 100644
> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
The link to the schematics seems to need updation, would like to see where these
regulators are mentioned, can't find them in [0] which I assume is the latest link.
> @@ -19,6 +19,33 @@ clk_imx219_fixed: imx219-xclk {
> #clock-cells = <0>;
> clock-frequency = <24000000>;
> };
> +
> + reg_2p8v: regulator-2p8v {
> + compatible = "regulator-fixed";
> + regulator-name = "2P8V";
> + regulator-min-microvolt = <2800000>;
> + regulator-max-microvolt = <2800000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> +
> + reg_1p8v: regulator-1p8v {
> + compatible = "regulator-fixed";
> + regulator-name = "1P8V";
> + regulator-min-microvolt = <1800000>;
> + regulator-max-microvolt = <1800000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> +
> + reg_1p2v: regulator-1p2v {
> + compatible = "regulator-fixed";
> + regulator-name = "1P2V";
> + regulator-min-microvolt = <1200000>;
> + regulator-max-microvolt = <1200000>;
> + vin-supply = <&vdd_sd_dv>;
> + regulator-always-on;
> + };
> };
>
> &csi_mux {
> @@ -34,6 +61,9 @@ imx219_0: imx219-0@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> + VANA-supply = <®_2p8v>;
> + VDIG-supply = <®_1p8v>;
> + VDDL-supply = <®_1p2v>;
>
> port {
> csi2_cam0: endpoint {
> @@ -55,6 +85,9 @@ imx219_1: imx219-1@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> + VANA-supply = <®_2p8v>;
> + VDIG-supply = <®_1p8v>;
> + VDDL-supply = <®_1p2v>;
>
> port {
> csi2_cam1: endpoint {
[0] https://datasheets.raspberrypi.com/camera/camera-module-2-schematics.pdf
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 4/7] arm64: dts: ti: k3-j721e-sk: Add requiried voltage supplies for IMX219
2025-04-11 13:38 ` Francis, Neha
@ 2025-04-14 11:40 ` Yemike Abhilash Chandra
0 siblings, 0 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-14 11:40 UTC (permalink / raw)
To: Francis, Neha, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
Hi Neha,
On 11/04/25 19:08, Francis, Neha wrote:
> On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
>> The device tree overlay for the IMX219 sensor requires three voltage
>> supplies to be defined: VANA (analog), VDIG (digital core), and VDDL
>> (digital I/O). Add the corresponding voltage supply definitions to avoid
>> dtbs_check warnings.
>>
>> Fixes: f767eb918096 ("arm64: dts: ti: k3-j721e-sk: Add overlay for IMX219")
>> Cc: stable@vger.kernel.org
>> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
>> ---
>> .../dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso | 33 +++++++++++++++++++
>> 1 file changed, 33 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
>> index 4a395d1209c8..4eb3cffab032 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
>> +++ b/arch/arm64/boot/dts/ti/k3-j721e-sk-csi2-dual-imx219.dtso
>
> The link to the schematics seems to need updation, would like to see where these
> regulators are mentioned, can't find them in [0] which I assume is the latest link.
>
Yes, It seems that the link to the schematics has been changed.
I will submit a separate patch to fix that.
While the regulators are not clearly documented in the schematics,
the voltage levels can be observed in the top-right corner of the
schematics.
However, the required regulators are explicitly described in the device
tree bindings.
Please refer: ./Documentation/devicetree/bindings/media/i2c/imx219.yaml
Thanks and Regards
Yemike Abhilash Chandra
>> @@ -19,6 +19,33 @@ clk_imx219_fixed: imx219-xclk {
>> #clock-cells = <0>;
>> clock-frequency = <24000000>;
>> };
>> +
>> + reg_2p8v: regulator-2p8v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "2P8V";
>> + regulator-min-microvolt = <2800000>;
>> + regulator-max-microvolt = <2800000>;
>> + vin-supply = <&vdd_sd_dv>;
>> + regulator-always-on;
>> + };
>> +
>> + reg_1p8v: regulator-1p8v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "1P8V";
>> + regulator-min-microvolt = <1800000>;
>> + regulator-max-microvolt = <1800000>;
>> + vin-supply = <&vdd_sd_dv>;
>> + regulator-always-on;
>> + };
>> +
>> + reg_1p2v: regulator-1p2v {
>> + compatible = "regulator-fixed";
>> + regulator-name = "1P2V";
>> + regulator-min-microvolt = <1200000>;
>> + regulator-max-microvolt = <1200000>;
>> + vin-supply = <&vdd_sd_dv>;
>> + regulator-always-on;
>> + };
>> };
>>
>> &csi_mux {
>> @@ -34,6 +61,9 @@ imx219_0: imx219-0@10 {
>> reg = <0x10>;
>>
>> clocks = <&clk_imx219_fixed>;
>> + VANA-supply = <®_2p8v>;
>> + VDIG-supply = <®_1p8v>;
>> + VDDL-supply = <®_1p2v>;
>>
>> port {
>> csi2_cam0: endpoint {
>> @@ -55,6 +85,9 @@ imx219_1: imx219-1@10 {
>> reg = <0x10>;
>>
>> clocks = <&clk_imx219_fixed>;
>> + VANA-supply = <®_2p8v>;
>> + VDIG-supply = <®_1p8v>;
>> + VDDL-supply = <®_1p2v>;
>>
>> port {
>> csi2_cam1: endpoint {
> [0] https://datasheets.raspberrypi.com/camera/camera-module-2-schematics.pdf
>
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 5/7] arm64: dts: ti: k3-am62x: Remove clock-names property from IMX219 overlay
2025-04-09 13:41 [PATCH v2 0/7] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
` (3 preceding siblings ...)
2025-04-09 13:41 ` [PATCH v2 4/7] arm64: dts: ti: k3-j721e-sk: Add requiried voltage supplies for IMX219 Yemike Abhilash Chandra
@ 2025-04-09 13:41 ` Yemike Abhilash Chandra
2025-04-11 13:39 ` Francis, Neha
2025-04-14 6:48 ` Jai Luthra
2025-04-09 13:41 ` [PATCH v2 6/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in " Yemike Abhilash Chandra
2025-04-09 13:41 ` [PATCH v2 7/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay Yemike Abhilash Chandra
6 siblings, 2 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-09 13:41 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1,
Yemike Abhilash Chandra, stable
The IMX219 sensor device tree bindings do not include a clock-names
property. Remove the incorrectly added clock-names entry to avoid
dtbs_check warnings.
Fixes: 4111db03dc05 ("arm64: dts: ti: k3-am62x: Add overlay for IMX219")
Cc: stable@vger.kernel.org
Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
index 76ca02127f95..7a0d35eb04d3 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
@@ -39,7 +39,6 @@ ov5640: camera@10 {
reg = <0x10>;
clocks = <&clk_imx219_fixed>;
- clock-names = "xclk";
reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 5/7] arm64: dts: ti: k3-am62x: Remove clock-names property from IMX219 overlay
2025-04-09 13:41 ` [PATCH v2 5/7] arm64: dts: ti: k3-am62x: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
@ 2025-04-11 13:39 ` Francis, Neha
2025-04-14 6:48 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Francis, Neha @ 2025-04-11 13:39 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> The IMX219 sensor device tree bindings do not include a clock-names
> property. Remove the incorrectly added clock-names entry to avoid
> dtbs_check warnings.
>
> Fixes: 4111db03dc05 ("arm64: dts: ti: k3-am62x: Add overlay for IMX219")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> index 76ca02127f95..7a0d35eb04d3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> @@ -39,7 +39,6 @@ ov5640: camera@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
>
> reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
>
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 5/7] arm64: dts: ti: k3-am62x: Remove clock-names property from IMX219 overlay
2025-04-09 13:41 ` [PATCH v2 5/7] arm64: dts: ti: k3-am62x: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
2025-04-11 13:39 ` Francis, Neha
@ 2025-04-14 6:48 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Jai Luthra @ 2025-04-14 6:48 UTC (permalink / raw)
To: Yemike Abhilash Chandra
Cc: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, vaishnav.a,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
[-- Attachment #1: Type: text/plain, Size: 1104 bytes --]
Thanks for the fix,
On Wed, Apr 09, 2025 at 07:11:26PM +0530, Yemike Abhilash Chandra wrote:
> The IMX219 sensor device tree bindings do not include a clock-names
> property. Remove the incorrectly added clock-names entry to avoid
> dtbs_check warnings.
>
> Fixes: 4111db03dc05 ("arm64: dts: ti: k3-am62x: Add overlay for IMX219")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Jai Luthra <jai.luthra@linux.dev>
> ---
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> index 76ca02127f95..7a0d35eb04d3 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> @@ -39,7 +39,6 @@ ov5640: camera@10 {
> reg = <0x10>;
>
> clocks = <&clk_imx219_fixed>;
> - clock-names = "xclk";
>
> reset-gpios = <&exp1 13 GPIO_ACTIVE_HIGH>;
>
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 6/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in IMX219 overlay
2025-04-09 13:41 [PATCH v2 0/7] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
` (4 preceding siblings ...)
2025-04-09 13:41 ` [PATCH v2 5/7] arm64: dts: ti: k3-am62x: Remove clock-names property from IMX219 overlay Yemike Abhilash Chandra
@ 2025-04-09 13:41 ` Yemike Abhilash Chandra
2025-04-11 13:40 ` Francis, Neha
2025-04-14 6:49 ` Jai Luthra
2025-04-09 13:41 ` [PATCH v2 7/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay Yemike Abhilash Chandra
6 siblings, 2 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-09 13:41 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1,
Yemike Abhilash Chandra, stable
The IMX219 device tree overlay incorrectly defined an I2C switch instead
of an I2C mux. According to the DT bindings, the correct terminology and
node definition should use "i2c-mux" instead of "i2c-switch". Hence,
update the same to avoid dtbs_check warnings.
Fixes: 4111db03dc05 ("arm64: dts: ti: k3-am62x: Add overlay for IMX219")
Cc: stable@vger.kernel.org
Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
index 7a0d35eb04d3..dd090813a32d 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
@@ -22,7 +22,7 @@ &main_i2c2 {
#size-cells = <0>;
status = "okay";
- i2c-switch@71 {
+ i2c-mux@71 {
compatible = "nxp,pca9543";
#address-cells = <1>;
#size-cells = <0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 6/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in IMX219 overlay
2025-04-09 13:41 ` [PATCH v2 6/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in " Yemike Abhilash Chandra
@ 2025-04-11 13:40 ` Francis, Neha
2025-04-14 6:49 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Francis, Neha @ 2025-04-11 13:40 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> The IMX219 device tree overlay incorrectly defined an I2C switch instead
> of an I2C mux. According to the DT bindings, the correct terminology and
> node definition should use "i2c-mux" instead of "i2c-switch". Hence,
> update the same to avoid dtbs_check warnings.
>
> Fixes: 4111db03dc05 ("arm64: dts: ti: k3-am62x: Add overlay for IMX219")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> index 7a0d35eb04d3..dd090813a32d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> @@ -22,7 +22,7 @@ &main_i2c2 {
> #size-cells = <0>;
> status = "okay";
>
> - i2c-switch@71 {
> + i2c-mux@71 {
> compatible = "nxp,pca9543";
> #address-cells = <1>;
> #size-cells = <0>;
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 6/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in IMX219 overlay
2025-04-09 13:41 ` [PATCH v2 6/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in " Yemike Abhilash Chandra
2025-04-11 13:40 ` Francis, Neha
@ 2025-04-14 6:49 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Jai Luthra @ 2025-04-14 6:49 UTC (permalink / raw)
To: Yemike Abhilash Chandra
Cc: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, vaishnav.a,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
[-- Attachment #1: Type: text/plain, Size: 1221 bytes --]
On Wed, Apr 09, 2025 at 07:11:27PM +0530, Yemike Abhilash Chandra wrote:
> The IMX219 device tree overlay incorrectly defined an I2C switch instead
> of an I2C mux. According to the DT bindings, the correct terminology and
> node definition should use "i2c-mux" instead of "i2c-switch". Hence,
> update the same to avoid dtbs_check warnings.
>
> Fixes: 4111db03dc05 ("arm64: dts: ti: k3-am62x: Add overlay for IMX219")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Jai Luthra <jai.luthra@linux.dev>
> ---
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> index 7a0d35eb04d3..dd090813a32d 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-imx219.dtso
> @@ -22,7 +22,7 @@ &main_i2c2 {
> #size-cells = <0>;
> status = "okay";
>
> - i2c-switch@71 {
> + i2c-mux@71 {
> compatible = "nxp,pca9543";
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread
* [PATCH v2 7/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay
2025-04-09 13:41 [PATCH v2 0/7] Fix dtbs_check warnings in CSI overlays Yemike Abhilash Chandra
` (5 preceding siblings ...)
2025-04-09 13:41 ` [PATCH v2 6/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in " Yemike Abhilash Chandra
@ 2025-04-09 13:41 ` Yemike Abhilash Chandra
2025-04-11 13:42 ` Francis, Neha
2025-04-14 6:50 ` Jai Luthra
6 siblings, 2 replies; 24+ messages in thread
From: Yemike Abhilash Chandra @ 2025-04-09 13:41 UTC (permalink / raw)
To: nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1,
Yemike Abhilash Chandra, stable
The OV5640 device tree overlay incorrectly defined an I2C switch instead
of an I2C mux. According to the DT bindings, the correct terminology and
node definition should use "i2c-mux" instead of "i2c-switch". Hence,
update the same to avoid dtbs_check warnings.
Fixes: 635ed9715194 ("arm64: dts: ti: k3-am62x: Add overlays for OV5640")
Cc: stable@vger.kernel.org
Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
---
arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso | 2 +-
arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
index ccc7f5e43184..7fc7c95f5cd5 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
@@ -22,7 +22,7 @@ &main_i2c2 {
#size-cells = <0>;
status = "okay";
- i2c-switch@71 {
+ i2c-mux@71 {
compatible = "nxp,pca9543";
#address-cells = <1>;
#size-cells = <0>;
diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
index 4eaf9d757dd0..b6bfdfbbdd98 100644
--- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
+++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
@@ -22,7 +22,7 @@ &main_i2c2 {
#size-cells = <0>;
status = "okay";
- i2c-switch@71 {
+ i2c-mux@71 {
compatible = "nxp,pca9543";
#address-cells = <1>;
#size-cells = <0>;
--
2.34.1
^ permalink raw reply related [flat|nested] 24+ messages in thread
* Re: [PATCH v2 7/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay
2025-04-09 13:41 ` [PATCH v2 7/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay Yemike Abhilash Chandra
@ 2025-04-11 13:42 ` Francis, Neha
2025-04-14 6:50 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Francis, Neha @ 2025-04-11 13:42 UTC (permalink / raw)
To: Yemike Abhilash Chandra, nm, vigneshr
Cc: kristo, robh, krzk+dt, conor+dt, vaishnav.a, jai.luthra,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
On 4/9/2025 7:11 PM, Yemike Abhilash Chandra wrote:
> The OV5640 device tree overlay incorrectly defined an I2C switch instead
> of an I2C mux. According to the DT bindings, the correct terminology and
> node definition should use "i2c-mux" instead of "i2c-switch". Hence,
> update the same to avoid dtbs_check warnings.
>
> Fixes: 635ed9715194 ("arm64: dts: ti: k3-am62x: Add overlays for OV5640")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
> ---
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso | 2 +-
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
> index ccc7f5e43184..7fc7c95f5cd5 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
> @@ -22,7 +22,7 @@ &main_i2c2 {
> #size-cells = <0>;
> status = "okay";
>
> - i2c-switch@71 {
> + i2c-mux@71 {
> compatible = "nxp,pca9543";
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
> index 4eaf9d757dd0..b6bfdfbbdd98 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
> @@ -22,7 +22,7 @@ &main_i2c2 {
> #size-cells = <0>;
> status = "okay";
>
> - i2c-switch@71 {
> + i2c-mux@71 {
> compatible = "nxp,pca9543";
> #address-cells = <1>;
> #size-cells = <0>;
Reviewed-by: Neha Malcom Francis <n-francis@ti.com>
--
Thanking You
Neha Malcom Francis
^ permalink raw reply [flat|nested] 24+ messages in thread
* Re: [PATCH v2 7/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay
2025-04-09 13:41 ` [PATCH v2 7/7] arm64: dts: ti: k3-am62x: Rename I2C switch to I2C mux in OV5640 overlay Yemike Abhilash Chandra
2025-04-11 13:42 ` Francis, Neha
@ 2025-04-14 6:50 ` Jai Luthra
1 sibling, 0 replies; 24+ messages in thread
From: Jai Luthra @ 2025-04-14 6:50 UTC (permalink / raw)
To: Yemike Abhilash Chandra
Cc: nm, vigneshr, kristo, robh, krzk+dt, conor+dt, vaishnav.a,
linux-arm-kernel, devicetree, imx, linux-kernel, u-kumar1, stable
[-- Attachment #1: Type: text/plain, Size: 1816 bytes --]
On Wed, Apr 09, 2025 at 07:11:28PM +0530, Yemike Abhilash Chandra wrote:
> The OV5640 device tree overlay incorrectly defined an I2C switch instead
> of an I2C mux. According to the DT bindings, the correct terminology and
> node definition should use "i2c-mux" instead of "i2c-switch". Hence,
> update the same to avoid dtbs_check warnings.
>
> Fixes: 635ed9715194 ("arm64: dts: ti: k3-am62x: Add overlays for OV5640")
> Cc: stable@vger.kernel.org
> Signed-off-by: Yemike Abhilash Chandra <y-abhilashchandra@ti.com>
Reviewed-by: Jai Luthra <jai.luthra@linux.dev>
> ---
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso | 2 +-
> arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
> index ccc7f5e43184..7fc7c95f5cd5 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-ov5640.dtso
> @@ -22,7 +22,7 @@ &main_i2c2 {
> #size-cells = <0>;
> status = "okay";
>
> - i2c-switch@71 {
> + i2c-mux@71 {
> compatible = "nxp,pca9543";
> #address-cells = <1>;
> #size-cells = <0>;
> diff --git a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
> index 4eaf9d757dd0..b6bfdfbbdd98 100644
> --- a/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
> +++ b/arch/arm64/boot/dts/ti/k3-am62x-sk-csi2-tevi-ov5640.dtso
> @@ -22,7 +22,7 @@ &main_i2c2 {
> #size-cells = <0>;
> status = "okay";
>
> - i2c-switch@71 {
> + i2c-mux@71 {
> compatible = "nxp,pca9543";
> #address-cells = <1>;
> #size-cells = <0>;
> --
> 2.34.1
>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 24+ messages in thread