From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 67D7FC4332F for ; Wed, 21 Dec 2022 12:41:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=RbrRSq8ZpF13rN7W9MFf+lqWmw0QJ6saJzAzkZYK4oE=; b=fCUN001b0gYIwg oPwg3PQ/htJOynWlD4sdlonkxV3kNf2VlYhH8oXBzusPVyk2z9Un85KtVgF3kEq2TwU2EcHBHKRd/ iXoHFMKak7bRWfqDSFAcIisehHejcEWsik87dreKuj8v0kBWTVdAAqaRZe6CpNwaeqBJCHT2GlWAb OUUsb7ZUkgSRzW1QC5+RCPs5Vla0tDOU/GUF0Cdw8qXT+q1ME70C7362EJDIYyzHH7u+23494aFUt JUJp3gMGBjxkej19lUIgBLOlpdPpOIjLjJU1MepqTYAh4vPo972eYlC4Yk8Z847eduvET0BAuS2X5 LzjYkIn8HV9k+om05iPg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7yOs-00El5z-Fr; Wed, 21 Dec 2022 12:40:46 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1p7yHt-00Ei6Z-Nd; Wed, 21 Dec 2022 12:33:35 +0000 Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 51A6FFB; Wed, 21 Dec 2022 13:33:25 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1671626005; bh=5Fd2x2guEXhJvwsldua4/D1afcQdq+w5Tdig2fs5xT4=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=oylmFDmpwe19jgOU9ccsnHaXmatKYGIHtxpuqVJpQsyWHx+HvUbI60OYAfRcSH4Pm dFq8xU+Z2huSzm3NiJalMifeCXhUJYBS9hkIBvvv7mqyBMd35Er2jtSBSLMPLE4woj bMBrzycYHMJ+DwLgEKZnZLZp22Yw2tFHbuA53xDY= MIME-Version: 1.0 In-Reply-To: <20221221074047.233473-1-umang.jain@ideasonboard.com> References: <20221221074047.233473-1-umang.jain@ideasonboard.com> Subject: Re: [PATCH] staging: vchiq_arm: Remove extra struct vchiq_instance declaration From: Kieran Bingham Cc: Greg Kroah-Hartman , Adrien Thierry , Stefan Wahren , Laurent Pinchart , Umang Jain To: Umang Jain , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-staging@lists.linux.dev Date: Wed, 21 Dec 2022 12:33:22 +0000 Message-ID: <167162600273.3944359.9522944722768752331@Monstersaurus> User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20221221_043333_992465_20268FF5 X-CRM114-Status: GOOD ( 12.20 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Umang Jain (2022-12-21 07:40:47) > Additional declaration of struct vchiq_instance was introduced in the > commit 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to > service callbacks"). Drop the extra declaration. > > Fixes: 726e79f8a648 ("staging: vchiq_arm: pass vchiq instance to service callbacks") > Signed-off-by: Umang Jain It's tempting to move the other instance up to near the top of the file too, but not necessary. Reviewed-by: Kieran Bingham > --- > drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > index 66965da11443..52e106f117da 100644 > --- a/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > +++ b/drivers/staging/vc04_services/include/linux/raspberrypi/vchiq.h > @@ -78,8 +78,6 @@ struct vchiq_service_params_kernel { > short version_min; /* Update for incompatible changes */ > }; > > -struct vchiq_instance; > - > extern int vchiq_initialise(struct vchiq_instance **pinstance); > extern int vchiq_shutdown(struct vchiq_instance *instance); > extern int vchiq_connect(struct vchiq_instance *instance); > -- > 2.38.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel