From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id C763DC25B4E for ; Sun, 22 Jan 2023 16:27:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=7XfzHYZ7IkU+dvIVRzO//am2cQ4Nw5CI8fbdfrA0CUw=; b=ugqSPgJCkxIsxH P+dC6jELBBO49vmkkHCrvCm+GkkgYnaL5o6DlWL1ewCTVPUhVHFIZu7O4vo5FTK0yY8YwYCSSYqfF 4tP2GiuY+6Q6S3bFtq5Lzn0aMUL2uref4zQ35NRekLBJvERFBsytOgcge6gOmownjStTvP/zXWJ5l XvFQcmUDk5m1hfqyiab9QQ8IiRUP5Bj+uXjAoYFizq79p2u79zrjZ2Uc426pW673UcKO0iF86fsTA X9KSA6jEmuJBqACEQ4a3bk187HnS9CvC4mezxR9BMuV22gNlp2/NJkghNSpulXlFhzjzZz1Exud3B hh+WNWk8vF0TAAtDFfng==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJdBR-00FXBk-CF; Sun, 22 Jan 2023 16:27:05 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1pJdBO-00FXAq-B6; Sun, 22 Jan 2023 16:27:03 +0000 Received: from pendragon.ideasonboard.com (cpc89244-aztw30-2-0-cust3082.18-1.cable.virginm.net [86.31.172.11]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id D748D308; Sun, 22 Jan 2023 17:26:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1674404814; bh=eujLJzueQN/rr7uEp/mzOY8lg5QhIUlSSUUSueSHrF8=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=PF6/H4pYaje1DHtCKKhBZbSIvmIwHe93BCVej26Ongx+mvhibGt2Oi5X+QyVzt/zW Ba14W9Q7TkuJNfBb91mHNK9g1hMRHziTVg66FcIqfaYwxhqU4Lcv1MnIvKY2XvyiTT +uz8AO92TN2BXqlf9oWFcN0E34k3Lr2KhJX5M72g= MIME-Version: 1.0 In-Reply-To: References: <20230118115810.21979-1-umang.jain@ideasonboard.com> Subject: Re: [RFC PATCH 0/4] Drop custom logging From: Kieran Bingham Cc: Greg Kroah-Hartman , Florian Fainelli , Adrien Thierry , Dan Carpenter , Dave Stevenson , linux-arm-kernel@lists.infradead.org, Laurent Pinchart , linux-kernel@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-staging@lists.linux.dev, linux-media@vger.kernel.org, Phil Elwell To: Stefan Wahren , Umang Jain Date: Sun, 22 Jan 2023 16:26:50 +0000 Message-ID: <167440481093.3533645.5465896340839457121@Monstersaurus> User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230122_082702_562610_0A4D489B X-CRM114-Status: GOOD ( 18.11 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Stefan, Quoting Stefan Wahren (2023-01-22 14:21:05) > Hi Umang, > > Am 18.01.23 um 12:58 schrieb Umang Jain: > > Drop custom logging from the vchiq interface. > > Mostly of them are replaced with dev_dbg and friends > > and/or pr_info and friends. > > > > The debugfs log levels (in 4/4) are mapped to kernel > > logs levels (coming from include/linux/kern_levels.h) > > Would like some thoughts on it as I am not sure (hence > > marking this is RFC) > > > > From drivers/staging/vc04_services/interface/TODO: > > > > """ > > * Cleanup logging mechanism > > > > The driver should probably be using the standard kernel logging mechanisms > > such as dev_info, dev_dbg, and friends. > > """ > > at first i want to thank you for the work on vchiq so far. > > There is something which is not directly related to this series, but it > is also about debugging. The driver has a buffer which is accessed by > it's own DEBUG_* macros. The content of this debug buffer can be dumped > via the /dev/vchiq which is also used by ioctl. I would appreciate to > move this dump feature into a new debugfs entry. Do you have a full list of the tasks you'd like to see completed ? (including/or above drivers/staging/vc04_services/interface/TODO) It would help to have a clear picture of tasks needed to get this driver destaged, so that we can support the ISP upstream. Regards -- Kieran _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel