From: Rob Herring <robh@kernel.org>
To: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@gmail.com>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
linux-sunxi@lists.linux.dev, Conor Dooley <conor@kernel.org>,
linux-rockchip@lists.infradead.org,
Nicolas Frattaroli <frattaroli.nicolas@gmail.com>,
kernel@collabora.com, Palmer Dabbelt <palmer@dabbelt.com>,
Albert Ou <aou@eecs.berkeley.edu>,
Samuel Holland <samuel@sholland.org>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Heiko Stuebner <heiko@sntech.de>,
Rob Herring <robh+dt@kernel.org>,
linux-serial@vger.kernel.org,
Paul Walmsley <paul.walmsley@sifive.com>,
linux-riscv@lists.infradead.org
Subject: Re: [PATCH v2 01/10] dt-bindings: serial: snps-dw-apb-uart: Switch dma-names order
Date: Mon, 27 Mar 2023 10:30:21 -0500 [thread overview]
Message-ID: <167993102075.3908904.11641161105077047331.robh@kernel.org> (raw)
In-Reply-To: <20230321215624.78383-2-cristian.ciocaltea@collabora.com>
On Tue, 21 Mar 2023 23:56:15 +0200, Cristian Ciocaltea wrote:
> Commit 370f696e4474 ("dt-bindings: serial: snps-dw-apb-uart: add dma &
> dma-names properties") documented dma-names property to handle Allwinner
> D1 dtbs_check warnings, but relies on the rx->tx ordering, which is the
> reverse of what a different board expects:
>
> rk3326-odroid-go2.dtb: serial@ff030000: dma-names:0: 'rx' was expected
>
> A quick and incomplete check shows the inconsistency is present in many
> other DTS files:
>
> $ git grep -A10 snps,dw-apb-uart | grep dma-names | sort -u
> arch/arm64/boot/dts/rockchip/px30.dtsi- dma-names = "tx", "rx";
> arch/arm64/boot/dts/rockchip/rk3328.dtsi- dma-names = "tx", "rx";
> arch/arm64/boot/dts/rockchip/rk3588s.dtsi- dma-names = "tx", "rx";
> arch/arm/boot/dts/rk3066a.dtsi- dma-names = "tx", "rx";
> arch/arm/boot/dts/rk3128.dtsi- dma-names = "tx", "rx";
> arch/arm/boot/dts/rk3288.dtsi- dma-names = "tx", "rx";
> arch/arm/boot/dts/rv1126.dtsi- dma-names = "tx", "rx";
> arch/arm/boot/dts/socfpga.dtsi- dma-names = "tx", "rx";
> arch/arm/boot/dts/sun6i-a31.dtsi- dma-names = "rx", "tx";
> arch/arm/boot/dts/sun8i-a23-a33.dtsi- dma-names = "rx", "tx";
> arch/arm/boot/dts/sun8i-v3s.dtsi- dma-names = "rx", "tx";
> arch/arm/boot/dts/sunxi-h3-h5.dtsi- dma-names = "rx", "tx";
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dma-names = "rx", "tx";
>
> The initial proposed solution was to allow a flexible dma-names order in
> the binding, due to potential ABI breakage concerns after fixing the DTS
> files. But luckily the Allwinner boards are not really affected, since
> all of them are using a shared DMA channel for rx and tx:
>
> $ git grep -A10 snps,dw-apb-uart | grep 'sun.*dmas' | sort -u
> arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 10>, <&dma 10>;
> arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 22>, <&dma 22>;
> arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 6>, <&dma 6>;
> arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 7>, <&dma 7>;
> arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 8>, <&dma 8>;
> arch/arm/boot/dts/sun6i-a31.dtsi- dmas = <&dma 9>, <&dma 9>;
> arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 10>, <&dma 10>;
> arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 6>, <&dma 6>;
> arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 7>, <&dma 7>;
> arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 8>, <&dma 8>;
> arch/arm/boot/dts/sun8i-a23-a33.dtsi- dmas = <&dma 9>, <&dma 9>;
> arch/arm/boot/dts/sun8i-v3s.dtsi- dmas = <&dma 6>, <&dma 6>;
> arch/arm/boot/dts/sun8i-v3s.dtsi- dmas = <&dma 7>, <&dma 7>;
> arch/arm/boot/dts/sun8i-v3s.dtsi- dmas = <&dma 8>, <&dma 8>;
> arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 6>, <&dma 6>;
> arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 7>, <&dma 7>;
> arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 8>, <&dma 8>;
> arch/arm/boot/dts/sunxi-h3-h5.dtsi- dmas = <&dma 9>, <&dma 9>;
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 14>, <&dma 14>;
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 15>, <&dma 15>;
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 16>, <&dma 16>;
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 17>, <&dma 17>;
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 18>, <&dma 18>;
> arch/riscv/boot/dts/allwinner/sunxi-d1s-t113.dtsi- dmas = <&dma 19>, <&dma 19>;
>
> Switch dma-names order to tx->rx as the first step in fixing the
> inconsistency. The remaining DTS fixes will be handled by separate
> patches.
>
> Signed-off-by: Cristian Ciocaltea <cristian.ciocaltea@collabora.com>
> ---
> Documentation/devicetree/bindings/serial/snps-dw-apb-uart.yaml | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-03-27 15:31 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-21 21:56 [PATCH v2 00/10] Enable I2S support for RK3588/RK3588S SoCs Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 01/10] dt-bindings: serial: snps-dw-apb-uart: Switch dma-names order Cristian Ciocaltea
2023-03-21 22:09 ` Conor Dooley
2023-03-21 22:17 ` Cristian Ciocaltea
2023-03-27 15:30 ` Rob Herring [this message]
2023-03-21 21:56 ` [PATCH v2 02/10] ARM: dts: sun6i: a31: Switch dma-names order for snps,dw-apb-uart nodes Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 03/10] ARM: dts: sun8i: a23/a33: " Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 04/10] ARM: dts: sun8i: v3s: " Cristian Ciocaltea
2023-04-08 12:12 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 05/10] ARM: dts: sunxi: h3/h5: " Cristian Ciocaltea
2023-04-08 12:13 ` Jernej Škrabec
2023-03-21 21:56 ` [PATCH v2 06/10] riscv: dts: allwinner: d1: " Cristian Ciocaltea
2023-03-21 22:10 ` Conor Dooley
2023-04-08 12:36 ` Jernej Škrabec
2023-04-10 12:25 ` Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 07/10] arm64: dts: rockchip: rk3588s: Move assigned-clocks/assigned-clock-rates out of scmi Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 08/10] arm64: dts: rockchip: rk3588s: Add I2S nodes Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 09/10] arm64: dts: rockchip: rk3588: " Cristian Ciocaltea
2023-03-21 21:56 ` [PATCH v2 10/10] arm64: dts: rockchip: rk3588-rock-5b: Add analog audio Cristian Ciocaltea
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=167993102075.3908904.11641161105077047331.robh@kernel.org \
--to=robh@kernel.org \
--cc=aou@eecs.berkeley.edu \
--cc=conor@kernel.org \
--cc=cristian.ciocaltea@collabora.com \
--cc=devicetree@vger.kernel.org \
--cc=frattaroli.nicolas@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=heiko@sntech.de \
--cc=jernej.skrabec@gmail.com \
--cc=kernel@collabora.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=linux-serial@vger.kernel.org \
--cc=linux-sunxi@lists.linux.dev \
--cc=palmer@dabbelt.com \
--cc=paul.walmsley@sifive.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox