From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C4FFC77B7A for ; Wed, 24 May 2023 12:50:21 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-Id:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=aNfjBmAAAHYxc4cY+Yzej9SQjFYpxuxMKIk6M8IV8qg=; b=E8ALJ5jdWlrNjH efiobMN8ooeAsbauCEP/gkILpOOKVEN1IzEaeHiJhTzhMTFiN5aAo/M9MY2peTIY8CXut0lGsIXB/ 2OtB19gGEUXRZCbO/tpvCZ8qud+NdvpHly6a0/kPbmXUSHicYDPGAA10ixKiM5s4pCXH22bqxGmX6 fCvNDUi8LL15RVlhpP6kTjDeCQwJmkej3UkhoohOFo6RmRP2PzV35jRiYdPFIrtkVIEDM3IS6GfZ6 lv8vonP/+evmDgL1jZZI0IlivxWcnrTWHv1d1tR6G759ibRQhKzFTzsc/k+amx9KvzTHJgTKygtMf zPM8KFWrnnYqpskJwY8A==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q1nwB-00DTmq-1d; Wed, 24 May 2023 12:49:55 +0000 Received: from dfw.source.kernel.org ([139.178.84.217]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q1nw7-00DTlp-34 for linux-arm-kernel@lists.infradead.org; Wed, 24 May 2023 12:49:53 +0000 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by dfw.source.kernel.org (Postfix) with ESMTPS id 0B28563CD1; Wed, 24 May 2023 12:49:50 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id 688B5C433D2; Wed, 24 May 2023 12:49:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1684932589; bh=cOFN2G/iT6VXMnNjHgQa0UC2BMzAHqV2vza1H2oeKTg=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NCM5hu9L9UrEngsmsdqqtfeLWm15y5V2Zgb+FDbJ1EcWzf44qiVq3H2K/nXCbo+DC 7IRyOiWXvjkDH6GKETm85rCY+bs0FCQTKXq7gfHUeHIJsUHCjL3+vJYvntOD+Qz5S7 uMsreTPYF1RtGNTxZHrhLoy+upWdOXeKB5a7KQq6v/C6oUc10cCvVBNk25WkXdfgxa UQsbXQpVk4jShNnK6Ec7WXyW2orag5jc7vpr7cpK8QVvz+PKSP8W0NgyZvxAP/GRRJ vCFLBiEJSdz6eDabsdrXTYW/C1uDJadt67oXwjq0Is8Ho8QLpV2t/gim2cr/DVWKj6 xwTAHJtF1CUKw== Received: from sofa.misterjones.org ([185.219.108.64] helo=valley-girl.lan) by disco-boy.misterjones.org with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.95) (envelope-from ) id 1q1nw2-0002Ld-Vx; Wed, 24 May 2023 13:49:47 +0100 From: Marc Zyngier To: oliver.upton@linux.dev, Jean-Philippe Brucker Cc: yuzenghui@huawei.com, kvmarm@lists.linux.dev, james.morse@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, catalin.marinas@arm.com Subject: Re: [PATCH 0/4] KVM: arm64: vgic: Locking fixes Date: Wed, 24 May 2023 13:49:39 +0100 Message-Id: <168493254802.3630329.8583196060399633594.b4-ty@kernel.org> X-Mailer: git-send-email 2.34.1 In-Reply-To: <20230518100914.2837292-1-jean-philippe@linaro.org> References: <20230518100914.2837292-1-jean-philippe@linaro.org> MIME-Version: 1.0 X-SA-Exim-Connect-IP: 185.219.108.64 X-SA-Exim-Rcpt-To: oliver.upton@linux.dev, jean-philippe@linaro.org, yuzenghui@huawei.com, kvmarm@lists.linux.dev, james.morse@arm.com, will@kernel.org, linux-arm-kernel@lists.infradead.org, suzuki.poulose@arm.com, catalin.marinas@arm.com X-SA-Exim-Mail-From: maz@kernel.org X-SA-Exim-Scanned: No (on disco-boy.misterjones.org); SAEximRunCond expanded to false X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230524_054952_047282_FCD04021 X-CRM114-Status: GOOD ( 13.93 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Thu, 18 May 2023 11:09:14 +0100, Jean-Philippe Brucker wrote: > Another fun locking puzzle, between the new config_lock and srcu. > Patch 1 attempts to fix it, and the other patches fix simpler issues. > > I got these lockdep reports while running KVM QEMU on a TCG QEMU, but it > can also be triggered by running the vgic_irq kselftest on TCG QEMU. > Now, with the fix and lockdep enabled, vgic_irq hangs but I believe it's > an unrelated weirdness: if I introduce a separate lockdep warning for > some made up locks, then the test passes again. So I'm sending this out > now for discussion, and will investigate that one later. > > [...] Applied to fixes, thanks! [1/4] KVM: arm64: vgic: Fix a circular locking issue commit: 59112e9c390be595224e427827475a6cd3726021 [2/4] KVM: arm64: vgic: Wrap vgic_its_create() with config_lock commit: 9cf2f840c439b6b23bd99f584f2917ca425ae406 [3/4] KVM: arm64: vgic: Fix locking comment commit: c38b8400aef99d63be2b1ff131bb993465dcafe1 [4/4] KVM: arm64: vgic: Fix a comment commit: 62548732260976ca88fcb17ef98ab661e7ce7504 Cheers, M. -- Without deviation from the norm, progress is not possible. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel