From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id EE563C77B7E for ; Fri, 26 May 2023 01:44:17 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Date:Subject:Message-Id:References: In-Reply-To:Cc:To:From:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=xbV/YzkfxcEsqC9O7i7xtD6NbX1WEmDEsbn9SgNUNGw=; b=EQMJuQXramqsDY YZoBXfO3LPQrPjYq2Ng2ATqlWvutfSD23+rmZ2uZA6RYeI/72W0j8H4GRGorkxM/5oBQJSAFFaguZ sQohjuqwR6CFz9orscj7Zu8usPh+ePTUasU26ieAcctrz22G75bv0QlsNgwqnYHK4HiZoYWSq2+jL zICmxRDMke2z04gmBh08Cc3wA0ezN5ArycQpZwAYNMj1rOAh3Ov4ZYC2oVK6r7dqT4b3S+yA3H9oM 2WjHCYE35c25AG5da/lngBVqk3LhyWVKsSb/KdjQodC04I8hmNjfHqIhz+66IdxyxMTqwNsGoYPSd guKI784bZtRrz7E6kvHg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q2MUh-000fC5-3A; Fri, 26 May 2023 01:43:51 +0000 Received: from mail-il1-f170.google.com ([209.85.166.170]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q2MUf-000fAj-1N for linux-arm-kernel@lists.infradead.org; Fri, 26 May 2023 01:43:51 +0000 Received: by mail-il1-f170.google.com with SMTP id e9e14a558f8ab-3319a6f989aso1998265ab.2 for ; Thu, 25 May 2023 18:43:47 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1685065427; x=1687657427; h=date:subject:message-id:references:in-reply-to:cc:to:from :mime-version:content-transfer-encoding:x-gm-message-state:from:to :cc:subject:date:message-id:reply-to; bh=9kkqmVgPfMqIpngCVwFGsQ4SKC/aGOoR2j/ffV6nKd4=; b=gmQNH3OtPzDH3xpy+yX5IW6faq08wEKKwxNA7u2FBw4JHM95SG5/iXBI4VuMoxBgGo U6DBo5bdSqVUdJdTC7fH3OH6tTqyvvLe1/XTR2u2jP4dBNo7uyxmuscZsyyBd359qNB1 6HFdg3vwzVFExEJDJEHnTWyUxk6wnHJqYfT3prkwAoxLx1v6/HArXRpNrOP3SUK6N7bd vcivsLY5u4XXRfS2U/J5UBXA++FfiXhBIgUlN32Emm4hbuTm6/ysrDcpjwnzjbBA7Tdg /HaV5cenzuxIBMXGRtuhI34jLhRtpPaIMwkLKSKuozk1s6/eirYPYBKiqQUA7rlnvHPc fbRw== X-Gm-Message-State: AC+VfDzBq4Hpti8ZVDrjikxp9E+lSaksSJZvCA9YqPMETWNHGUjpBKYh Vz7M2hVpHn6ZvdfS7n3/WQ== X-Google-Smtp-Source: ACHHUZ606ICxYqI7w5Joho9qmcY1XHqxNYROkxzrFYpKsk8gS+nkwRlIKTaoQaLt73CTzi4wI9hg0Q== X-Received: by 2002:a92:d9c7:0:b0:329:bba2:781a with SMTP id n7-20020a92d9c7000000b00329bba2781amr346194ilq.0.1685065426628; Thu, 25 May 2023 18:43:46 -0700 (PDT) Received: from robh_at_kernel.org ([64.188.179.254]) by smtp.gmail.com with ESMTPSA id o14-20020a056e02068e00b003318ec8f9e9sm658058ils.80.2023.05.25.18.43.45 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 May 2023 18:43:45 -0700 (PDT) Received: (nullmailer pid 3166 invoked by uid 1000); Fri, 26 May 2023 01:43:44 -0000 MIME-Version: 1.0 From: Rob Herring To: William Zhang Cc: f.fainelli@gmail.com, Rob Herring , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Krzysztof Kozlowski In-Reply-To: <20230525050241.3700-1-william.zhang@broadcom.com> References: <20230525050241.3700-1-william.zhang@broadcom.com> Message-Id: <168506542054.3041.3667248390783185219.robh@kernel.org> Subject: Re: dt_binding_check report false alarm? Date: Thu, 25 May 2023 20:43:44 -0500 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230525_184349_467620_5A552A49 X-CRM114-Status: GOOD ( 21.79 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 24 May 2023 22:02:41 -0700, William Zhang wrote: > Hi, > > It seems dt_binding_check reports a false error when run on this > modified yaml. I picked this simple file just to demostrate this issue. > Basically I made the interrupts and interrupt-names as optional > properties. But when there are two interrupts present, then > interrupt-names are required. However in the example, I don't define > interrupts and interrupt-name at all, the dt binding check reports error > that interrupt-names are required: > > make dt_binding_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/crypto/fsl-imx-scc.yaml > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTEX Documentation/devicetree/bindings/crypto/fsl-imx-scc.example.dts > DTC_CHK Documentation/devicetree/bindings/crypto/fsl-imx-scc.example.dtb > Documentation/devicetree/bindings/crypto/fsl-imx-scc.example.dtb: crypto@53fac000: 'interrupt-names' is a required property > From schema: /home/william/projects/linux/Documentation/devicetree/bindings/crypto/fsl-imx-scc.yaml > > This does not make sense to me as name is required only when there are > two interrupts. Can someone familar with this please help to check if I > miss anything in the yaml file or it is indeed a bug in binding check? > > Thanks, > William > > --- > .../devicetree/bindings/crypto/fsl-imx-scc.yaml | 13 +++++++++---- > 1 file changed, 9 insertions(+), 4 deletions(-) > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/crypto/fsl-imx-scc.example.dtb: crypto@53fac000: 'interrupt-names' is a required property From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/crypto/fsl-imx-scc.yaml doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20230525050241.3700-1-william.zhang@broadcom.com The base for the series is generally the latest rc1. A different dependency should be noted in *this* patch. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit after running the above command yourself. Note that DT_SCHEMA_FILES can be set to your schema file to speed up checking your schema. However, it must be unset to test all examples with your schema. _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel