From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B4BC0C7EE2E for ; Tue, 13 Jun 2023 12:16:56 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:Cc:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=nwYS9QHqB8duxD42gt9nRT7DRDcnnxAJLkOEIAgqULU=; b=dJ3qQCGkwD5YF+ bJhi0ATF4Y3KKzyZrrMzU81q6wtjJYcl1cqQrRH9TBj4eY1Cs0LZAwIt9w4EInoj+BIVq3iN7Uysb 3H8JVvrg/x9l3ltFUHZafFWYCwWsOX0+DFb3MiXwNB4YGSiaTWgYwr4GnWi/sRS4kNnxUsnDDDQuj /tRL+4xj9mEMUANbo8jNxejZAIvez3xMYHHsR7VBGbyj9vsC+JrvrPl2xb0FVNEHbmH4a7Z6Ou1QB /wCVDKII6GdRMudGbkMVrv1+RGKcIYm3Xd0B0v7+VR8rwG6MekWsQ/d2Ln5Bhhh4EnxsxpmsSKLKj 0AjTpvW29l9GfPCBXnjg==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1q92wp-0081qr-23; Tue, 13 Jun 2023 12:16:31 +0000 Received: from out-12.mta1.migadu.com ([95.215.58.12]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1q92wm-0081oX-0U for linux-arm-kernel@lists.infradead.org; Tue, 13 Jun 2023 12:16:29 +0000 X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1686658580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=KSAEPk899fFIeec6HHaSoIZTwAJnWOrWf2em/FZAvE0=; b=ClpOLb+zqfw4RK3yxKIxW5y1+8cGDnRq77JdHFXZuP3cMEqwRLlSS+TD55Fnp8uHKO0zkK gRfVUhBm3yzUkAuRvhqxS4H8NRfaF0dWXFJXi5vwwvitbTX7xVyxpMAMXZpg2IbXmZvZZI xwShBVMuIUYeDtAj2xOcehf123cu2Z8= From: Oliver Upton To: Dan Carpenter , Christoffer Dall Cc: Oliver Upton , Will Deacon , Marc Zyngier , kernel-janitors@vger.kernel.org, kvmarm@lists.linux.dev, Catalin Marinas , Zenghui Yu , James Morse , Suzuki K Poulose , linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH v2] KVM: arm64: timers: Fix resource leaks in kvm_timer_hyp_init() Date: Tue, 13 Jun 2023 12:16:01 +0000 Message-ID: <168665854177.2681974.14382421414038699730.b4-ty@linux.dev> In-Reply-To: <72fffc35-7669-40b1-9d14-113c43269cf3@kili.mountain> References: <72fffc35-7669-40b1-9d14-113c43269cf3@kili.mountain> MIME-Version: 1.0 X-Migadu-Flow: FLOW_OUT X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230613_051628_358220_CA9A2C22 X-CRM114-Status: UNSURE ( 7.42 ) X-CRM114-Notice: Please train this message. X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Tue, 13 Jun 2023 09:43:39 +0300, Dan Carpenter wrote: > Smatch detected this bug: > arch/arm64/kvm/arch_timer.c:1425 kvm_timer_hyp_init() > warn: missing unwind goto? > > There are two resources to be freed the vtimer and ptimer. The > line that Smatch complains about should free the vtimer first > before returning and then after that cleanup code should free > the ptimer. > > [...] Applied to kvmarm/next, thanks! [1/1] KVM: arm64: timers: Fix resource leaks in kvm_timer_hyp_init() https://git.kernel.org/kvmarm/kvmarm/c/21e87daece5a -- Best, Oliver _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel