From: Furkan Kardame <f.kardame@manjaro.org>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>, robh+dt@kernel.org
Cc: krzysztof.kozlowski+dt@linaro.org, conor+dt@kernel.org,
heiko@sntech.de, broonie@kernel.org, deller@gmx.de,
dsterba@suse.com, arnd@arndb.de, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc
Date: Tue, 20 Jun 2023 17:05:48 +0000 [thread overview]
Message-ID: <1687280004029.3690769854.982412891@manjaro.org> (raw)
In-Reply-To: <c020531e-c56e-7606-1846-5ca7332de96f@linaro.org>
On Tuesday 20 June 2023 09:19:22 (+03:00), Krzysztof Kozlowski wrote:
> On 19/06/2023 20:48, Furkan Kardame wrote:
> > Add dts for Firefly Station P2.
> > Working IO:
> > * eMMC
> > * HDMI
> > * LAN
> > * LED
> > * SD Card
> > * UART
> > * USB2
> > * USB3
> ...
>
> > + };
> > +
> > + hdmi-con {
> > + compatible = "hdmi-connector";
> > + type = "a";
> > +
> > + port {
> > + hdmi_con_in: endpoint {
> > + remote-endpoint = <&hdmi_out_con>;
>
> Missing indentation.
I am not able to see any missing indentation in the patch.
I did run checkpatch and did not find any such warning.
Please advice in detail ?
>
> ...
>
> > +
> > + vcc3v3_lcd0_n: vcc3v3-lcd0-n-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc3v3_lcd0_n";
> > + regulator-boot-on;
> > +
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
>
> How do you turn this regulator off in suspend?
These nodes needs to be deleted as they are not used.
I will remove vcc3v3_lcd0_n and send a new patch.
>
> > + };
> > + };
> > +
> > + vcc3v3_lcd1_n: vcc3v3-lcd1-n-regulator {
> > + compatible = "regulator-fixed";
> > + regulator-name = "vcc3v3_lcd1_n";
> > + regulator-boot-on;
> > +
> > + regulator-state-mem {
> > + regulator-off-in-suspend;
>
> Same question here.
vcc3v3_lcd1_n will be removed.
>
> > + };
> > + };
> > +};
>
>
>
> Best regards,
> Krzysztof
>
>
--
--
With best regards
Furkan Kardame
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
next prev parent reply other threads:[~2023-06-20 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-19 18:48 [PATCHv3 0/2] Add support for Firefly Station P2 aka rk3568-roc-pc Furkan Kardame
2023-06-19 18:48 ` [PATCHv3 1/2] dt-bindings: arm: rockchip: Add Firefly Station P2 Furkan Kardame
2023-06-19 20:02 ` Conor Dooley
2023-06-19 18:48 ` [PATCHv3 2/2] arm64: dts: rockchip: add dts for Firefly Station P2 aka rk3568-roc-pc Furkan Kardame
2023-06-20 6:19 ` Krzysztof Kozlowski
2023-06-20 17:05 ` Furkan Kardame [this message]
2023-06-20 17:17 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1687280004029.3690769854.982412891@manjaro.org \
--to=f.kardame@manjaro.org \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=deller@gmx.de \
--cc=devicetree@vger.kernel.org \
--cc=dsterba@suse.com \
--cc=heiko@sntech.de \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox