From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.0 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, MENTIONS_GIT_HOSTING,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 116E5C433E0 for ; Wed, 12 Aug 2020 19:25:17 +0000 (UTC) Received: from merlin.infradead.org (merlin.infradead.org [205.233.59.134]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id D5A4C20838 for ; Wed, 12 Aug 2020 19:25:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="yFDHtubT" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D5A4C20838 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=merlin.20170209; h=Sender:Content-Transfer-Encoding: Content-Type:Cc:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=csYKIWj9CsffRmNRZThjDZ+GCunVoh7qO+vAzC/4Veg=; b=yFDHtubT56EuMJmEcdSZvO43B wNZP9SqPf92WMbmc4JzG4RDQc7f6sYYwSwN54fvMy7dul5yUtLujMEs8zivuQgzjq2643BI9m7VJt dgcOMmE2UJ4c5ApbrgMPJGVi2gbhGJS6KYjIwLNHGCGRTDUVOlPSfTqXlm/cbLp7uBldW6yRvwTdF SUjbYazwBrYuEF91/EDm2RMRqi2vSb/Jl2zDJ3Ia3Dhz8OE9hFaiMizXuP1lJpQot9zGQYJ3Lwzh3 bOBcnjSjW4AT2WLa1JBmyo5HYJpuxq295KtUtuFbQe4KLauv1WogA73TykpCH+Wf0P6eLQJlqhJU3 WRkDU68Tg==; Received: from localhost ([::1] helo=merlin.infradead.org) by merlin.infradead.org with esmtp (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5wLq-00038E-1K; Wed, 12 Aug 2020 19:23:54 +0000 Received: from gloria.sntech.de ([185.11.138.130]) by merlin.infradead.org with esmtps (Exim 4.92.3 #3 (Red Hat Linux)) id 1k5wLn-000373-Kx; Wed, 12 Aug 2020 19:23:52 +0000 Received: from dynamic-194-228-11-227.ipv4.broadband.iol.cz ([194.228.11.227] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1k5wLk-0000aL-3f; Wed, 12 Aug 2020 21:23:48 +0200 From: Heiko Stuebner To: Stephen Boyd Subject: Re: [PATCH] clk: rockchip: Fix initialization of mux_pll_src_4plls_p Date: Wed, 12 Aug 2020 21:23:31 +0200 Message-ID: <1687296.fXXW8n0h3p@phil> In-Reply-To: <159721875227.33733.9237826555988566719@swboyd.mtv.corp.google.com> References: <20200810044020.2063350-1-natechancellor@gmail.com> <159721875227.33733.9237826555988566719@swboyd.mtv.corp.google.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20200812_152351_726709_77C9D27A X-CRM114-Status: GOOD ( 15.40 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: clang-built-linux@googlegroups.com, Michael Turquette , linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, Nathan Chancellor , linux-clk@vger.kernel.org, linux-arm-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Am Mittwoch, 12. August 2020, 09:52:32 CEST schrieb Stephen Boyd: > Quoting Nathan Chancellor (2020-08-09 21:40:20) > > A new warning in Clang points out that the initialization of > > mux_pll_src_4plls_p appears incorrect: > > > > ../drivers/clk/rockchip/clk-rk3228.c:140:58: warning: suspicious > > concatenation of string literals in an array initialization; did you > > mean to separate the elements with a comma? [-Wstring-concatenation] > > PNAME(mux_pll_src_4plls_p) = { "cpll", "gpll", "hdmiphy" "usb480m" }; > > ^ > > , > > ../drivers/clk/rockchip/clk-rk3228.c:140:48: note: place parentheses > > around the string literal to silence warning > > PNAME(mux_pll_src_4plls_p) = { "cpll", "gpll", "hdmiphy" "usb480m" }; > > ^ > > 1 warning generated. > > > > Given the name of the variable and the same variable name in rv1108, it > > seems that this should have been four distinct elements. Fix it up by > > adding the comma as suggested. > > > > Fixes: 307a2e9ac524 ("clk: rockchip: add clock controller for rk3228") > > Link: https://github.com/ClangBuiltLinux/linux/issues/1123 > > Signed-off-by: Nathan Chancellor > > --- > > Looks good to me. I can pick it up for clk-fixes if Heiko agrees. Reviewed-by: Heiko Stuebner @Stephen you can pick this up as suggested Thanks Heiko _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel