From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 1C8F1EB64D7 for ; Wed, 28 Jun 2023 11:22:09 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Message-ID:Date:To:Cc:From:Subject: References:In-Reply-To:MIME-Version:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=TBwLLRwpE7olPdDE0bvilmcspeqJ+3Jd/WDD6KbntGE=; b=aY7WzRSVRKPzr5 IuGxidcthRGGCrNQBPQmCJHnsTlDVxRggEoGqOVom1Oe6mCDZABfpVXLPeCJoYOm3bj+de62B9LX0 Gy3Ssj0fNtbBeGhHPCvikWwcYDrV5kw2RGfo5NlckJP52CiMtsx/WI3nXg8eLZJt2SZwMXTIUNwIp tzVH8xJY/z4ku7iQO4LNKjYFHqgex2fhM1LrE8WvkfAdzzsH7iR6mSlnw7eZM0+a+xZRP/X3ClSI0 U+7ShEOTZ3G36iC0bHnSV1YUbVUusESB477EcfcYW2ZgujuX7cb7eBJDIvfa0xRf8LNLRV6eiFcMU JKqhpYXJaoy8U1nZuSSA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qETEz-00FZXD-08; Wed, 28 Jun 2023 11:21:41 +0000 Received: from perceval.ideasonboard.com ([213.167.242.64]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qETEv-00FZWj-2w; Wed, 28 Jun 2023 11:21:39 +0000 Received: from pendragon.ideasonboard.com (aztw-30-b2-v4wan-166917-cust845.vm26.cable.virginm.net [82.37.23.78]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 5E620814; Wed, 28 Jun 2023 13:20:52 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1687951252; bh=abc8pk8RuvvZJla85WjtaH3AoscYHKj27LLRxuhLM+E=; h=In-Reply-To:References:Subject:From:Cc:To:Date:From; b=HKOQlmhowxdU42zNj6H3E6T3eOqEEhzXTKmfc8bXe9RwDb/A99rCqBjBX9uWt9xn3 tMnRI7u9H+OBkHZg+RwAQ1br5UzExCOZYoZldGLs3T7pjnX1iruPEU4E46qps37Uf6 ehh4URLI2YyUURVZ+mFfgZnBdKjVjohp4j3TwaEw= MIME-Version: 1.0 In-Reply-To: <20230627201628.207483-3-umang.jain@ideasonboard.com> References: <20230627201628.207483-1-umang.jain@ideasonboard.com> <20230627201628.207483-3-umang.jain@ideasonboard.com> Subject: Re: [PATCH v8 2/5] staging: vc04_services: vchiq_arm: Register vchiq_bus_type From: Kieran Bingham Cc: stefan.wahren@i2se.com, gregkh@linuxfoundation.org, f.fainelli@gmail.com, athierry@redhat.com, error27@gmail.com, dave.stevenson@raspberrypi.com, laurent.pinchart@ideasonboard.com, Umang Jain To: Umang Jain , linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, linux-rpi-kernel@lists.infradead.org, linux-staging@lists.linux.dev Date: Wed, 28 Jun 2023 12:21:29 +0100 Message-ID: <168795128917.2878450.12280941046284606847@Monstersaurus> User-Agent: alot/0.10 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230628_042138_119805_899A15F5 X-CRM114-Status: GOOD ( 15.65 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Quoting Umang Jain (2023-06-27 21:16:25) > Register the vchiq_bus_type bus with the vchiq interface. > The bcm2835-camera nad bcm2835_audio will be registered to this bus type s/nad/and/ Is it possible to rename bcm2835_audio to bcm2835-audio for consistency? Or is that baked into existing usage/abi already? If it can be changed, I think it's probably something to do in an independent patch at the end of the series anyway. I suspect this patch could be merged with 1/5 but I think it's ok separate too. Reviewed-by: Kieran Bingham > going ahead. > > Signed-off-by: Umang Jain > --- > .../vc04_services/interface/vchiq_arm/vchiq_arm.c | 9 +++++++++ > 1 file changed, 9 insertions(+) > > diff --git a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > index aa2313f3bcab..e8d40f891449 100644 > --- a/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > +++ b/drivers/staging/vc04_services/interface/vchiq_arm/vchiq_arm.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > #include > @@ -34,6 +35,7 @@ > #include "vchiq_ioctl.h" > #include "vchiq_arm.h" > #include "vchiq_debugfs.h" > +#include "vchiq_device.h" > #include "vchiq_connected.h" > #include "vchiq_pagelist.h" > > @@ -1870,6 +1872,12 @@ static int __init vchiq_driver_init(void) > { > int ret; > > + ret = bus_register(&vchiq_bus_type); > + if (ret) { > + pr_err("Failed to register %s\n", vchiq_bus_type.name); > + return ret; > + } > + > ret = platform_driver_register(&vchiq_driver); > if (ret) > pr_err("Failed to register vchiq driver\n"); > @@ -1880,6 +1888,7 @@ module_init(vchiq_driver_init); > > static void __exit vchiq_driver_exit(void) > { > + bus_unregister(&vchiq_bus_type); > platform_driver_unregister(&vchiq_driver); > } > module_exit(vchiq_driver_exit); > -- > 2.39.1 > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel