[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Tomasz Figa]

This patch adds status override of serial nodes to enable used serial ports
on Origen and SMDKV310 board.

Signed-off-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index d1a1101..c7295fb 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -57,6 +57,22 @@
 		status = "okay";
 	};
 
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+
 	gpio_keys {
 		compatible = "gpio-keys";
 		#address-cells = <1>;
diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index b87cca2..f634907 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -43,6 +43,22 @@
 		status = "okay";
 	};
 
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+
 	keypad at 100A0000 {
 		samsung,keypad-num-rows = <2>;
 		samsung,keypad-num-columns = <8>;
-- 
1.7.12

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Kukjin Kim]

Tomasz Figa wrote:
> 
> This patch adds status override of serial nodes to enable used serial
> ports
> on Origen and SMDKV310 board.
> 
Well...I'm not sure about the status of Origen serial, but all of the
serials are enabled on SMDKV310, is it right?

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Tomasz Figa]

Hi Kgene,

On Saturday 08 of September 2012 11:36:30 Kukjin Kim wrote:
> Tomasz Figa wrote:
> > This patch adds status override of serial nodes to enable used serial
> > ports
> > on Origen and SMDKV310 board.
> 
> Well...I'm not sure about the status of Origen serial, but all of the
> serials are enabled on SMDKV310, is it right?

According to arrays of struct s3c2410_uartcfg in mach-origen.c and mach-
smdkv310.c, all the four serial ports are enabled on both boards.

--
Best regards,
Tomasz Figa

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Tomasz Figa]

This patch adds status override of serial nodes to enable used serial ports
on Origen and SMDKV310 board.

Signed-off-by: Tomasz Figa <t.figa@samsung.com>
---
 arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
 arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
 2 files changed, 32 insertions(+)

diff --git a/arch/arm/boot/dts/exynos4210-origen.dts b/arch/arm/boot/dts/exynos4210-origen.dts
index d1a1101..c7295fb 100644
--- a/arch/arm/boot/dts/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/exynos4210-origen.dts
@@ -57,6 +57,22 @@
 		status = "okay";
 	};
 
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+
 	gpio_keys {
 		compatible = "gpio-keys";
 		#address-cells = <1>;
diff --git a/arch/arm/boot/dts/exynos4210-smdkv310.dts b/arch/arm/boot/dts/exynos4210-smdkv310.dts
index b87cca2..f634907 100644
--- a/arch/arm/boot/dts/exynos4210-smdkv310.dts
+++ b/arch/arm/boot/dts/exynos4210-smdkv310.dts
@@ -43,6 +43,22 @@
 		status = "okay";
 	};
 
+	serial at 13800000 {
+		status = "okay";
+	};
+
+	serial at 13810000 {
+		status = "okay";
+	};
+
+	serial at 13820000 {
+		status = "okay";
+	};
+
+	serial at 13830000 {
+		status = "okay";
+	};
+
 	keypad at 100A0000 {
 		samsung,keypad-num-rows = <2>;
 		samsung,keypad-num-columns = <8>;
-- 
1.7.12

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Tomasz Figa]

Hi Kgene,

On Monday 08 of October 2012 15:12:48 Tomasz Figa wrote:
> This patch adds status override of serial nodes to enable used serial
> ports on Origen and SMDKV310 board.
> 
> Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> ---
>  arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
>  arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
>  2 files changed, 32 insertions(+)
> 

I think you missed this patch when applying Exynos dts reorganization 
patches. It is needed to enable serial ports on Origen and SMDKV310 boards. 
Could you apply it as well?

Best regards,
-- 
Tomasz Figa
Samsung Poland R&D Center

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Kukjin Kim]

Tomasz Figa wrote:
> 
> Hi Kgene,
> 
> On Monday 08 of October 2012 15:12:48 Tomasz Figa wrote:
> > This patch adds status override of serial nodes to enable used serial
> > ports on Origen and SMDKV310 board.
> >
> > Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> > ---
> >  arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
> >  arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
> >  2 files changed, 32 insertions(+)
> >
> 
> I think you missed this patch when applying Exynos dts reorganization
> patches. It is needed to enable serial ports on Origen and SMDKV310
boards.
> Could you apply it as well?
> 
Oops, yeah. I will apply.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Tomasz Figa]

Hi Kgene,

On Monday 15 of October 2012 23:23:22 Kukjin Kim wrote:
> Tomasz Figa wrote:
> > Hi Kgene,
> > 
> > On Monday 08 of October 2012 15:12:48 Tomasz Figa wrote:
> > > This patch adds status override of serial nodes to enable used
> > > serial
> > > ports on Origen and SMDKV310 board.
> > > 
> > > Signed-off-by: Tomasz Figa <t.figa@samsung.com>
> > > ---
> > > 
> > >  arch/arm/boot/dts/exynos4210-origen.dts   | 16 ++++++++++++++++
> > >  arch/arm/boot/dts/exynos4210-smdkv310.dts | 16 ++++++++++++++++
> > >  2 files changed, 32 insertions(+)
> > 
> > I think you missed this patch when applying Exynos dts reorganization
> > patches. It is needed to enable serial ports on Origen and SMDKV310
> 
> boards.
> 
> > Could you apply it as well?
> 
> Oops, yeah. I will apply.

I saw that you applied this patch to your next/dt-samsung branch, thanks.

However I think this should be considered a fix, because without it serial 
console on Origen and SMDKV310 will be broken.

Best regards,
Tomasz Figa

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Kukjin Kim]

Tomasz Figa wrote:
> 
> However I think this should be considered a fix, because without it serial
> console on Origen and SMDKV310 will be broken.
> 
Well, I couldn't find any broken due to miss this for v3.7. I think, there
is no usage of serial controller in mainline for Origen and SMDKV310 now. So
this should be queued for -next. If not, please let me know.

Thanks.

Best regards,
Kgene.
--
Kukjin Kim <kgene.kim@samsung.com>, Senior Engineer,
SW Solution Development Team, Samsung Electronics Co., Ltd.

[PATCH] ARM: dts: exynos4: Enable serial controllers on Origen and SMDKV310

[Tomasz Figa]

On Tuesday 23 of October 2012 21:03:01 Kukjin Kim wrote:
> Tomasz Figa wrote:
> > However I think this should be considered a fix, because without it
> > serial console on Origen and SMDKV310 will be broken.
> 
> Well, I couldn't find any broken due to miss this for v3.7. I think,
> there is no usage of serial controller in mainline for Origen and
> SMDKV310 now. So this should be queued for -next. If not, please let me
> know.

Personally I'm fine with this, but it sounds a bit off, since (correct me 
if I am wrong) it looks like serial console is the only way to check if 
the board boots.

Best regards,
Tomasz Figa