From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 821B9C04A94 for ; Wed, 2 Aug 2023 22:05:26 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:Cc:To:From:Subject:Message-ID: References:Mime-Version:In-Reply-To:Date:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=FzJ4/9DU9i+2+BE8vqrY8CfwvphUGeZTlk3B6Ifkha0=; b=dpyL0Xp/rEMCUT6qqnR9yYlGBm 4rqTdAjdAApGXj2VzkjttmZlmlkpw7+xJ5zP7Yt3tiAMioP7dylaz7HPnw2gsS9a/aIC58Y5B6Y++ w4+SMz90v+t/FUHpeya4/svY4QzBcqvopkQ5GLzILPXXKTeID81mJj2gVneN/M066FceJF3VXutM3 1zuC85Bhqu0M6SbE+54CrPjjG9SmQLFIVIRP6dIG9oRXdXUZMCbs000bnQTvf28bVr+xZN7ePN7k/ vJ4aO0BhLPjDLrUpFoYN0Ug7EiSVId1hJnqKhcLIbKMDvIF1soySEtvnXldYci0WrlRI0pN+BG95c t+2HPF8w==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1qRJxg-005zMb-1F; Wed, 02 Aug 2023 22:04:56 +0000 Received: from mail-pl1-x64a.google.com ([2607:f8b0:4864:20::64a]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1qRJxc-005zKx-2U for linux-arm-kernel@lists.infradead.org; Wed, 02 Aug 2023 22:04:54 +0000 Received: by mail-pl1-x64a.google.com with SMTP id d9443c01a7336-1bb962ada0dso4815715ad.2 for ; Wed, 02 Aug 2023 15:04:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20221208; t=1691013887; x=1691618687; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=s4pG+0ROPLN5wFPTceCIK9yMxb584BXYEH3MDjAMHUI=; b=5IThkL7mCuko/iZIqR7UMcifDGS27vvyStr3c+LzjuZVQG91qOky9lKg+zrOiZTMpU OwwWPgG4cke3/T3XBolLw2Cx3WUuGyiif6ZowjDo07N0l7srbZJ6chbQoBVzIZBAk36f vOsJLqY8XbXpAV4lcysaz5w2Q7x8+E2jcr4xl4PoVSbEfMXaCQYRcBOftfG+xqOa9+A1 7wD40U6lLvSLC2KpqHnU2BJ36ecpDnhMawcETwGiYTqZ6YZVuaKEKYzU6SDT2fW6vWk5 kd4mjyDCuLytL9hJoedPQORuBvRjh15HoKTWlu0MrSrLcGPDhhGsnL2+Rh40VubQgp28 KP6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1691013887; x=1691618687; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=s4pG+0ROPLN5wFPTceCIK9yMxb584BXYEH3MDjAMHUI=; b=lSasEkRle/PPbZbyssT3BA906xHn+5F5botjO/baE53m/1zrrXtz+4ELsZbnGqzT+v ey5fGMh9U5TaO0PmLbDH7GC0+lSUsEs59hVAvrvpyYvz+kX4dh0YyyYnZsmSLLm14c3O iJ/aSBgU0jXwUT1CDJUfgD7ar1iZb+ErmH0tK2u4GNqBKBl0VT1vxCpBS8beRb7BgQnZ UlcScyuIA3u/YpQiqodtuOkRlNKs2HFvFKOZHTyDP+UZftR6TQ+c+m4GqkPYa+RAhnrs gNX1iJ/BUnzJ1mIHklpNKXJf2T+k52JxnmTIlSZsE2jLrimlgAzlWM3l83QiROSyPu6o kEXg== X-Gm-Message-State: ABy/qLYUg6iq/KZBbMpww16GnwzLIfFEjrHd4b+ACIEJ1rMgnc952KjK KKXQmUmyUbmEPeGlvuXOcw1rCC1wUlo= X-Google-Smtp-Source: APBJJlF5RdyRksKOEIlR2G5Z4RvCvNZ4hcQlx656VIxEW0DE1DwYcEzBQVuH42ayiSXyOKOjkSa++KcJmYM= X-Received: from zagreus.c.googlers.com ([fda3:e722:ac3:cc00:7f:e700:c0a8:5c37]) (user=seanjc job=sendgmr) by 2002:a17:903:2309:b0:1b3:bfa6:d064 with SMTP id d9-20020a170903230900b001b3bfa6d064mr104865plh.1.1691013887511; Wed, 02 Aug 2023 15:04:47 -0700 (PDT) Date: Wed, 2 Aug 2023 15:01:41 -0700 In-Reply-To: <20230729003643.1053367-1-seanjc@google.com> Mime-Version: 1.0 References: <20230729003643.1053367-1-seanjc@google.com> X-Mailer: git-send-email 2.41.0.585.gd2178a4bd4-goog Message-ID: <169101267140.1755771.17089576255751273053.b4-ty@google.com> Subject: Re: [PATCH v4 00/34] KVM: selftests: Guest printf and asserts overhaul From: Sean Christopherson To: Sean Christopherson , Paolo Bonzini , Marc Zyngier , Oliver Upton , Christian Borntraeger , Janosch Frank , Claudio Imbrenda Cc: kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, linux-kernel@vger.kernel.org, Thomas Huth , "=?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?=" , Aaron Lewis X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20230802_150452_837568_6E3A2283 X-CRM114-Status: GOOD ( 17.07 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Fri, 28 Jul 2023 17:36:09 -0700, Sean Christopherson wrote: > This is effectively v4 of Aaron's series to add printf capabilities to > the guest[*]. I also pulled in Thomas' patch to rename ASSERT_EQ() to > TEST_ASSERT_EQ(), mainly so that we can decide on a common output format > for both host and guest asserts in a single series, but also so that all > these basically treewide patches are contained in a single series. > > Note, Aaron did all of the heavy lifting, I just mopped up. The core code > is pretty much unchanged from Aaron's v3, v4 massages the assert code a > bit and converts all the tests. > > [...] Applied to kvm-x86 selftests and officially started this runaway train. I'll give this a few days to stew in linux-next, and assuming no fireworks, will create a tag and make everything up to that point immutable. I will follow-up with all the in-flight selftests series I can find to coordinate, though I'm hoping we'll get lucky and just not have any major conflitcs. Please yell asap if you encounter issues and/or object to any of this. Note, I technically applied patch 1 from Thomas' original posting, but captured it here too as I figured that'd be the least confusing thing. [1/36] KVM: selftests: Rename the ASSERT_EQ macro https://github.com/kvm-x86/linux/commit/6d85f51a1f08 [2/36] KVM: selftests: Make TEST_ASSERT_EQ() output look like normal TEST_ASSERT() https://github.com/kvm-x86/linux/commit/b145c58d95ff [3/36] KVM: selftests: Add a shameful hack to preserve/clobber GPRs across ucall https://github.com/kvm-x86/linux/commit/6783ca4105a7 [4/36] KVM: selftests: Add strnlen() to the string overrides https://github.com/kvm-x86/linux/commit/a1c1b55e116c [5/36] KVM: selftests: Add guest_snprintf() to KVM selftests https://github.com/kvm-x86/linux/commit/e5119382499c [6/36] KVM: selftests: Add additional pages to the guest to accommodate ucall https://github.com/kvm-x86/linux/commit/215a681710a5 [7/36] KVM: selftests: Add string formatting options to ucall https://github.com/kvm-x86/linux/commit/57e5c1fef5ec [8/36] KVM: selftests: Add formatted guest assert support in ucall framework https://github.com/kvm-x86/linux/commit/289c2b4db8f3 [9/36] KVM: selftests: Add arch ucall.h and inline simple arch hooks https://github.com/kvm-x86/linux/commit/b35f4c73d389 [10/36] KVM: selftests: Add #define of expected KVM exit reason for ucall https://github.com/kvm-x86/linux/commit/edb5b700f9f8 [11/36] KVM: selftests: Add a selftest for guest prints and formatted asserts https://github.com/kvm-x86/linux/commit/5d1d46f9d56f [12/36] KVM: selftests: Convert aarch_timer to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/db44e1c871bc [13/36] KVM: selftests: Convert debug-exceptions to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/bac9aeecc387 [14/36] KVM: selftests: Convert ARM's hypercalls test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/af5b41b97f1c [15/36] KVM: selftests: Convert ARM's page fault test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/df27f6b45454 [16/36] KVM: selftests: Convert ARM's vGIC IRQ test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/d0ad3bacc523 [17/36] KVM: selftests: Convert the memslot performance test to printf guest asserts https://github.com/kvm-x86/linux/commit/c55a475d5fc4 [18/36] KVM: selftests: Convert s390's memop test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/428c76c769fa [19/36] KVM: selftests: Convert s390's tprot test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/5f82bbab84ad [20/36] KVM: selftests: Convert set_memory_region_test to printf-based GUEST_ASSERT https://github.com/kvm-x86/linux/commit/9291c9cef5b5 [21/36] KVM: selftests: Convert steal_time test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/3d9bd831175e [22/36] KVM: selftests: Convert x86's CPUID test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/06b651d250e5 [23/36] KVM: selftests: Convert the Hyper-V extended hypercalls test to printf asserts https://github.com/kvm-x86/linux/commit/82cb0ed66d4e [24/36] KVM: selftests: Convert the Hyper-V feature test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/8d1d3ce604e5 [25/36] KVM: selftests: Convert x86's KVM paravirt test to printf style GUEST_ASSERT https://github.com/kvm-x86/linux/commit/bf6c760b9df3 [26/36] KVM: selftests: Convert the MONITOR/MWAIT test to use printf guest asserts https://github.com/kvm-x86/linux/commit/0f52e4aaa614 [27/36] KVM: selftests: Convert x86's nested exceptions test to printf guest asserts https://github.com/kvm-x86/linux/commit/b13a307ce3c6 [28/36] KVM: selftests: Convert x86's set BSP ID test to printf style guest asserts https://github.com/kvm-x86/linux/commit/40b319d6b4e1 [29/36] KVM: selftests: Convert the nSVM software interrupt test to printf guest asserts https://github.com/kvm-x86/linux/commit/a925f7994281 [30/36] KVM: selftests: Convert x86's TSC MSRs test to use printf guest asserts https://github.com/kvm-x86/linux/commit/847ae0795514 [31/36] KVM: selftests: Convert the x86 userspace I/O test to printf guest assert https://github.com/kvm-x86/linux/commit/417bfd0c820f [32/36] KVM: selftests: Convert VMX's PMU capabilities test to printf guest asserts https://github.com/kvm-x86/linux/commit/30a6e0b4553d [33/36] KVM: selftests: Convert x86's XCR0 test to use printf-based guest asserts https://github.com/kvm-x86/linux/commit/4e15c38a1aca [34/36] KVM: selftests: Rip out old, param-based guest assert macros https://github.com/kvm-x86/linux/commit/7ce7f8e75418 [35/36] KVM: selftests: Print out guest RIP on unhandled exception https://github.com/kvm-x86/linux/commit/6f321017c84b [36/36] KVM: selftests: Use GUEST_FAIL() in ARM's arch timer helpers https://github.com/kvm-x86/linux/commit/a05c4c2bd8b5 -- https://github.com/kvm-x86/linux/tree/next https://github.com/kvm-x86/linux/tree/fixes _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel