From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-19.4 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, INCLUDES_PATCH,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D59AAC433ED for ; Sun, 2 May 2021 10:46:23 +0000 (UTC) Received: from desiato.infradead.org (desiato.infradead.org [90.155.92.199]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id C6EC26135A for ; Sun, 2 May 2021 10:46:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C6EC26135A Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=desiato.20200630; h=Sender:Content-Transfer-Encoding :Content-Type:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To:Message-ID:Date: Subject:Cc:To:From:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=Gpyz4kCtjPclw356bWBW7VaRcschxVwZ8fNihK516U0=; b=XKi7nsOduM7p3yxrvV8s21fJF 6Bc4BeBbEtBHkhjWks5YOjRBDqtGGg/z7xmTpK3de5wAa2lU51+tioRcBTcyIRqfSHcC7E0j6oOrC 0x26ovcXR4Bmyba3dP5/WMgTAxuHJbgcV5cJycNE2XnnFswznphLOVN2pa3Wt4lYe6CERBgYSEfzn Outt/bM1yF1mRl5KHNZ/RxMYnyWbHgZ2i2jYCHGVrJxzIE14bQWhReCsktI/TFtw6cxLqYbfouXVi Wfv6e+03e3wdOfAs/dUmI8h3KE8chOS0Vj8ALCszrzGG9b8qPKM9q8ffVaHcmmN2XGwdkvdtqdiiq uZ/p8kWUQ==; Received: from localhost ([::1] helo=desiato.infradead.org) by desiato.infradead.org with esmtp (Exim 4.94 #2 (Red Hat Linux)) id 1ld9aL-00BcsZ-WA; Sun, 02 May 2021 10:44:26 +0000 Received: from bombadil.infradead.org ([2607:7c80:54:e::133]) by desiato.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ld9aH-00Bcs7-Vw; Sun, 02 May 2021 10:44:22 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20210309; h=Content-Type: Content-Transfer-Encoding:MIME-Version:References:In-Reply-To:Message-ID:Date :Subject:Cc:To:From:Sender:Reply-To:Content-ID:Content-Description; bh=L4ERBxfzdpvfIhDyrCU4zJnW2APy/X/ejQibiYtVvoo=; b=GIxmELw31vPAspVM2RvC4FCjiY DAOXdrzxif2rT0938eaYvNtxaR+EBh5FXZo1qOQr5th1koAEFRWQC+za09gxuVEsde4Ilixthpjf/ gFqNatCwhD4x+S15uwVi1xdaE29jCmNgGkDkg5nCTzHIvDfnkqyIkqTvaz1g4ct51Sb5Z7A0IaGfH bf8ozq6i8i+r0Sd2GntfSya3zNqTHUzIuM00rJqHdJy7MrNFIz94B1ruz9CenZpBVYmX/aOHa89bP 4z9iHwlJrMFfOeaQilEMJ0p1I8nx5MsjzkcBe1cMpNlyPZdQ1Odmp+c5M/ks0s0yaTZ3yIQLKws4z r7E1N79A==; Received: from gloria.sntech.de ([185.11.138.130]) by bombadil.infradead.org with esmtps (Exim 4.94 #2 (Red Hat Linux)) id 1ld9aC-002Tbo-Vc; Sun, 02 May 2021 10:44:19 +0000 Received: from p508fd4bc.dip0.t-ipconnect.de ([80.143.212.188] helo=phil.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1ld9Zy-0006PS-Qi; Sun, 02 May 2021 12:44:02 +0200 From: Heiko Stuebner To: Johan Jonker Cc: cl@rock-chips.com, jay.xu@rock-chips.com, david.wu@rock-chips.com, zhangqing@rock-chips.com, huangtao@rock-chips.com, shawn.lin@rock-chips.com, robh+dt@kernel.org, devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v1 1/2] dt-bindings: soc: rockchip: convert grf.txt to YAML Date: Sun, 02 May 2021 12:44:01 +0200 Message-ID: <1691445.VLH7GnMWUR@phil> In-Reply-To: <45d7aa00-1879-cc6e-df9b-fe1ed83a4531@gmail.com> References: <20210501203520.5465-1-jbx6244@gmail.com> <45d7aa00-1879-cc6e-df9b-fe1ed83a4531@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20210502_034417_382881_54F20074 X-CRM114-Status: GOOD ( 31.64 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hi Johan, Am Sonntag, 2. Mai 2021, 12:13:12 CEST schrieb Johan Jonker: > Hi Rob, Heiko, > > This patch relies on rockchip,power-controller.yaml, but a look in > MAINTAINERS show that no one seems responsible. > Who should apply? power-domains are part of the "soc"-drivers, so that will be me. Though I'm waiting on the next -rc1 (next sunday) to get a clean start. Heiko > === > > This patch makes use of phy-rockchip-inno-usb2.yaml > > Given response in: > > dt-bindings: phy: convert phy-rockchip-inno-usb2 bindings to yaml > https://lore.kernel.org/linux-rockchip/20200319171305.GA19150@bogus/ > > '#phy-cells' was added to the example. > > A proposal to add that to usb2-phy nodes was never accepted, > so dtbs_check continuous to generate notifications. > > ARM: dts: rockchip: add #phy-cells to all usb2-phy nodes > https://lore.kernel.org/linux-rockchip/20200401073725.6063-1-jbx6244@gmail.com/ > > === > > A issue was filed, but nothing fixed. > > phys with subnodes and #phy-cells requirement #22 > https://github.com/devicetree-org/dt-schema/issues/22 > > === > > Please advise. > > Johan > > On 5/1/21 10:35 PM, Johan Jonker wrote: > > Current dts files with 'grf' nodes are manually verified. > > In order to automate this process grf.txt has to be > > converted to YAML. > > > > Most compatibility strings are in use with "simple-mfd" added. > > > > Add description already in use: > > "rockchip,rv1108-pmugrf", "syscon" > > > > Add new descriptions for: > > "rockchip,rk3568-grf", "syscon", "simple-mfd" > > "rockchip,rk3568-pmugrf", "syscon", "simple-mfd" > > > > Signed-off-by: Johan Jonker > > --- > > .../devicetree/bindings/soc/rockchip/grf.txt | 61 ----- > > .../devicetree/bindings/soc/rockchip/grf.yaml | 277 +++++++++++++++++++++ > > 2 files changed, 277 insertions(+), 61 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/soc/rockchip/grf.txt > > create mode 100644 Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.txt b/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > deleted file mode 100644 > > index f96511aa3..000000000 > > --- a/Documentation/devicetree/bindings/soc/rockchip/grf.txt > > +++ /dev/null > > @@ -1,61 +0,0 @@ > > -* Rockchip General Register Files (GRF) > > - > > -The general register file will be used to do static set by software, which > > -is composed of many registers for system control. > > - > > -From RK3368 SoCs, the GRF is divided into two sections, > > -- GRF, used for general non-secure system, > > -- SGRF, used for general secure system, > > -- PMUGRF, used for always on system > > - > > -On RK3328 SoCs, the GRF adds a section for USB2PHYGRF, > > - > > -ON RK3308 SoC, the GRF is divided into four sections: > > -- GRF, used for general non-secure system, > > -- SGRF, used for general secure system, > > -- DETECTGRF, used for audio codec system, > > -- COREGRF, used for pvtm, > > - > > -Required Properties: > > - > > -- compatible: GRF should be one of the following: > > - - "rockchip,px30-grf", "syscon": for px30 > > - - "rockchip,rk3036-grf", "syscon": for rk3036 > > - - "rockchip,rk3066-grf", "syscon": for rk3066 > > - - "rockchip,rk3188-grf", "syscon": for rk3188 > > - - "rockchip,rk3228-grf", "syscon": for rk3228 > > - - "rockchip,rk3288-grf", "syscon": for rk3288 > > - - "rockchip,rk3308-grf", "syscon": for rk3308 > > - - "rockchip,rk3328-grf", "syscon": for rk3328 > > - - "rockchip,rk3368-grf", "syscon": for rk3368 > > - - "rockchip,rk3399-grf", "syscon": for rk3399 > > - - "rockchip,rv1108-grf", "syscon": for rv1108 > > -- compatible: DETECTGRF should be one of the following: > > - - "rockchip,rk3308-detect-grf", "syscon": for rk3308 > > -- compatilbe: COREGRF should be one of the following: > > - - "rockchip,rk3308-core-grf", "syscon": for rk3308 > > -- compatible: PMUGRF should be one of the following: > > - - "rockchip,px30-pmugrf", "syscon": for px30 > > - - "rockchip,rk3368-pmugrf", "syscon": for rk3368 > > - - "rockchip,rk3399-pmugrf", "syscon": for rk3399 > > -- compatible: SGRF should be one of the following: > > - - "rockchip,rk3288-sgrf", "syscon": for rk3288 > > -- compatible: USB2PHYGRF should be one of the following: > > - - "rockchip,px30-usb2phy-grf", "syscon": for px30 > > - - "rockchip,rk3328-usb2phy-grf", "syscon": for rk3328 > > -- compatible: USBGRF should be one of the following: > > - - "rockchip,rv1108-usbgrf", "syscon": for rv1108 > > -- reg: physical base address of the controller and length of memory mapped > > - region. > > - > > -Example: GRF and PMUGRF of RK3399 SoCs > > - > > - pmugrf: syscon@ff320000 { > > - compatible = "rockchip,rk3399-pmugrf", "syscon"; > > - reg = <0x0 0xff320000 0x0 0x1000>; > > - }; > > - > > - grf: syscon@ff770000 { > > - compatible = "rockchip,rk3399-grf", "syscon"; > > - reg = <0x0 0xff770000 0x0 0x10000>; > > - }; > > diff --git a/Documentation/devicetree/bindings/soc/rockchip/grf.yaml b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > new file mode 100644 > > index 000000000..3f66328a3 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/soc/rockchip/grf.yaml > > @@ -0,0 +1,277 @@ > > +# SPDX-License-Identifier: GPL-2.0 > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/soc/rockchip/grf.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Rockchip General Register Files (GRF) > > + > > +maintainers: > > + - Heiko Stuebner > > + > > +select: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - rockchip,px30-grf > > + - rockchip,px30-pmugrf > > + - rockchip,px30-usb2phy-grf > > + - rockchip,rk3036-grf > > + - rockchip,rk3066-grf > > + - rockchip,rk3188-grf > > + - rockchip,rk3228-grf > > + - rockchip,rk3288-grf > > + - rockchip,rk3288-sgrf > > + - rockchip,rk3308-core-grf > > + - rockchip,rk3308-detect-grf > > + - rockchip,rk3308-grf > > + - rockchip,rk3328-grf > > + - rockchip,rk3328-usb2phy-grf > > + - rockchip,rk3368-grf > > + - rockchip,rk3368-pmugrf > > + - rockchip,rk3399-grf > > + - rockchip,rk3399-pmugrf > > + - rockchip,rk3568-grf > > + - rockchip,rk3568-pmugrf > > + - rockchip,rv1108-grf > > + - rockchip,rv1108-pmugrf > > + - rockchip,rv1108-usbgrf > > + > > + required: > > + - compatible > > + > > +properties: > > + compatible: > > + oneOf: > > + - items: > > + - enum: > > + - rockchip,rk3066-grf > > + - rockchip,rk3188-grf > > + - rockchip,rk3288-sgrf > > + - rockchip,rv1108-pmugrf > > + - rockchip,rv1108-usbgrf > > + - const: syscon > > + - items: > > + - enum: > > + - rockchip,px30-grf > > + - rockchip,px30-pmugrf > > + - rockchip,px30-usb2phy-grf > > + - rockchip,rk3036-grf > > + - rockchip,rk3228-grf > > + - rockchip,rk3288-grf > > + - rockchip,rk3308-core-grf > > + - rockchip,rk3308-detect-grf > > + - rockchip,rk3308-grf > > + - rockchip,rk3328-grf > > + - rockchip,rk3328-usb2phy-grf > > + - rockchip,rk3368-grf > > + - rockchip,rk3368-pmugrf > > + - rockchip,rk3399-grf > > + - rockchip,rk3399-pmugrf > > + - rockchip,rk3568-grf > > + - rockchip,rk3568-pmugrf > > + - rockchip,rv1108-grf > > + - const: syscon > > + - const: simple-mfd > > + > > + reg: > > + maxItems: 1 > > + > > +required: > > + - compatible > > + - reg > > + > > +additionalProperties: true > > + > > +allOf: > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: rockchip,px30-grf > > + > > + then: > > + properties: > > + lvds: > > + description: > > + Documentation/devicetree/bindings/display/rockchip/rockchip-lvds.txt > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: rockchip,rk3288-grf > > + > > + then: > > + properties: > > + edp-phy: > > + description: > > + Documentation/devicetree/bindings/phy/rockchip-dp-phy.txt > > + > > + usbphy: > > + description: > > + Documentation/devicetree/bindings/phy/rockchip-usb-phy.txt > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: rockchip,rk3328-grf > > + > > + then: > > + properties: > > + grf-gpio: > > + description: > > + Documentation/devicetree/bindings/gpio/rockchip,rk3328-grf-gpio.txt > > + > > + power-controller: > > + type: object > > + > > + $ref: "/schemas/power/rockchip,power-controller.yaml#" > > + > > + unevaluatedProperties: false > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + const: rockchip,rk3399-grf > > + > > + then: > > + properties: > > + mipi-dphy-rx0: > > + type: object > > + > > + $ref: "/schemas/phy/rockchip-mipi-dphy-rx0.yaml#" > > + > > + unevaluatedProperties: false > > + > > + pcie-phy: > > + description: > > + Documentation/devicetree/bindings/phy/rockchip-pcie-phy.txt > > + > > + patternProperties: > > + "phy@[0-9a-f]+$": > > + description: > > + Documentation/devicetree/bindings/phy/rockchip-emmc-phy.txt > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - rockchip,px30-pmugrf > > + - rockchip,rk3036-grf > > + - rockchip,rk3308-grf > > + - rockchip,rk3368-pmugrf > > + > > + then: > > + properties: > > + reboot-mode: > > + type: object > > + > > + $ref: "/schemas/power/reset/syscon-reboot-mode.yaml#" > > + > > + unevaluatedProperties: false > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - rockchip,px30-usb2phy-grf > > + - rockchip,rk3228-grf > > + - rockchip,rk3328-usb2phy-grf > > + - rockchip,rk3399-grf > > + - rockchip,rv1108-grf > > + > > + then: > > + properties: > > + "#address-cells": > > + const: 1 > > + > > + "#size-cells": > > + const: 1 > > + > > + required: > > + - "#address-cells" > > + - "#size-cells" > > + > > + patternProperties: > > + "usb2-phy@[0-9a-f]+$": > > + type: object > > + > > + $ref: "/schemas/phy/phy-rockchip-inno-usb2.yaml#" > > + > > + unevaluatedProperties: false > > + > > + - if: > > + properties: > > + compatible: > > + contains: > > + enum: > > + - rockchip,px30-pmugrf > > + - rockchip,px30-grf > > + - rockchip,rk3228-grf > > + - rockchip,rk3288-grf > > + - rockchip,rk3328-grf > > + - rockchip,rk3368-pmugrf > > + - rockchip,rk3368-grf > > + - rockchip,rk3399-pmugrf > > + - rockchip,rk3399-grf > > + > > + then: > > + properties: > > + io-domains: > > + description: > > + Documentation/devicetree/bindings/power/rockchip-io-domain.txt > > + > > + unevaluatedProperties: false > > + > > +examples: > > + - | > > + #include > > + #include > > + #include > > + grf: syscon@ff770000 { > > + compatible = "rockchip,rk3399-grf", "syscon", "simple-mfd"; > > + reg = <0xff770000 0x10000>; > > + #address-cells = <1>; > > + #size-cells = <1>; > > + > > + mipi_dphy_rx0: mipi-dphy-rx0 { > > + compatible = "rockchip,rk3399-mipi-dphy-rx0"; > > + clocks = <&cru SCLK_MIPIDPHY_REF>, > > + <&cru SCLK_DPHY_RX0_CFG>, > > + <&cru PCLK_VIO_GRF>; > > + clock-names = "dphy-ref", "dphy-cfg", "grf"; > > + power-domains = <&power RK3399_PD_VIO>; > > + #phy-cells = <0>; > > + }; > > + > > + u2phy0: usb2-phy@e450 { > > + compatible = "rockchip,rk3399-usb2phy"; > > + reg = <0xe450 0x10>; > > + clocks = <&cru SCLK_USB2PHY0_REF>; > > + clock-names = "phyclk"; > > + #clock-cells = <0>; > > + clock-output-names = "clk_usbphy0_480m"; > > + #phy-cells = <0>; > > + > > + u2phy0_host: host-port { > > + #phy-cells = <0>; > > + interrupts = ; > > + interrupt-names = "linestate"; > > + }; > > + > > + u2phy0_otg: otg-port { > > + #phy-cells = <0>; > > + interrupts = , > > + , > > + ; > > + interrupt-names = "otg-bvalid", "otg-id", > > + "linestate"; > > + }; > > + }; > > + }; > > > _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel