public inbox for linux-arm-kernel@lists.infradead.org
 help / color / mirror / Atom feed
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ahci: compile out msi/msix infrastructure
Date: Sat, 05 Dec 2015 23:25:48 +0100	[thread overview]
Message-ID: <1693285.M8jQWtVTWx@wuerfel> (raw)
In-Reply-To: <1540836.svMP4lTcYC@wuerfel>

On Saturday 05 December 2015 23:22:49 Arnd Bergmann wrote:
> On Friday 04 December 2015 11:58:30 Dan Williams wrote:
> > +#ifdef CONFIG_PCI_MSI
> > +static inline int ahci_irq_vector(struct ahci_host_priv *hpriv, int port)
> > +{
> > +       if (hpriv->flags & AHCI_HFLAG_MULTI_MSIX)
> > +               return hpriv->msix[i].vector;
> > +       else
> > +               return hpriv->irq + i;
> > +}
> > 
> 
> My randconfig tests now noticed that 'i' is undeclared here. I suppose it
> should be 'port' instead of 'i'?
> 

and one more:

In file included from /git/arm-soc/drivers/ata/ahci_platform.c:25:0:
/git/arm-soc/drivers/ata/ahci.h: In function 'ahci_irq_vector':
/git/arm-soc/drivers/ata/ahci.h:368:3: error: invalid use of undefined type 'struct msix_entry'
   return hpriv->msix[port].vector;
   ^
/git/arm-soc/drivers/ata/ahci.h:368:21: error: dereferencing pointer to incomplete type 'struct msix_entry'
   return hpriv->msix[port].vector;


diff --git a/drivers/ata/ahci.h b/drivers/ata/ahci.h
index c450b8a914eb..dfbd033706bb 100644
--- a/drivers/ata/ahci.h
+++ b/drivers/ata/ahci.h
@@ -37,6 +37,7 @@
 
 #include <linux/clk.h>
 #include <linux/libata.h>
+#include <linux/pci.h>
 #include <linux/phy/phy.h>
 #include <linux/regulator/consumer.h>
 

  reply	other threads:[~2015-12-05 22:25 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-04 19:58 [PATCH] ahci: compile out msi/msix infrastructure Dan Williams
2015-12-04 21:46 ` Arnd Bergmann
2015-12-05 22:22 ` Arnd Bergmann
2015-12-05 22:25   ` Arnd Bergmann [this message]
2015-12-06  0:05     ` Dan Williams

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1693285.M8jQWtVTWx@wuerfel \
    --to=arnd@arndb.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox