From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 75F96C4360C for ; Thu, 10 Oct 2019 07:07:56 +0000 (UTC) Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 466B72190F for ; Thu, 10 Oct 2019 07:07:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=lists.infradead.org header.i=@lists.infradead.org header.b="cDjgjw0u"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="G1HPELi2"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=mailbox.org header.i=@mailbox.org header.b="umPFSm/5" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 466B72190F Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=mailbox.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20170209; h=Sender: Content-Transfer-Encoding:Content-Type:Cc:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:References:In-Reply-To: Message-ID:Date:Subject:To:From:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=mzGA+0Y34Xtm6lfVEDEZqsUbj7rwIPiQzf/wHf6Nm58=; b=cDjgjw0uHrrtpd 3idYCFn2pXJiDKIs/X5c9m0SS3BiPCqnMdLcVZKeDHccSmT3woj3fHMAIZ57uaAaQoo0Ow2Z3vIzc 6gKQfhrIOZOTReWKfJDUJ7JwyYHYn95DcW5VwqxLH5O3KPCXexCR4jNzH76UKtVn7bv0zl+Ppa0Li qEQ6nQ3xunR5Ch10rEmLA+/whpv+iewJnhgkUjQ3ePZiLyFZcLqycJKtRNyU90kWu8NTzf3J2JWkd 4o0vQj8Ex8zShbmq++kmXyf1Nn70rQLdsRECCKliPg0gNf5XC6Ml/DD2vrHpYioy2h9J7h9MEfKvg detHRVPR9BCYGUtXuPTA==; Received: from localhost ([127.0.0.1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISY9-00081C-Jq; Thu, 10 Oct 2019 07:07:49 +0000 Received: from mx2a.mailbox.org ([2001:67c:2050:104:0:2:25:2]) by bombadil.infradead.org with esmtps (Exim 4.92.2 #3 (Red Hat Linux)) id 1iISY4-00080O-G7; Thu, 10 Oct 2019 07:07:48 +0000 Received: from smtp2.mailbox.org (smtp2.mailbox.org [80.241.60.241]) (using TLSv1.2 with cipher ECDHE-RSA-CHACHA20-POLY1305 (256/256 bits)) (No client certificate requested) by mx2a.mailbox.org (Postfix) with ESMTPS id E9C2BA39BF; Thu, 10 Oct 2019 09:07:38 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=mailbox.org; h= content-type:content-type:content-transfer-encoding:mime-version :references:in-reply-to:message-id:date:date:subject:subject :from:from:received; s=mail20150812; t=1570691255; bh=qtVeTLRbBe 26U1OQjCON8/pEtKrsW3vc60rQbDWzF+E=; b=G1HPELi2LZJv6oCg4v18nkAytH W+jy+/CJEqHg3ekHNNSnKjPyLu2Dc30ugQEWd5Nelj9bs5o0kAX/ty/YA6pvazg7 l/VKwb1Td7qZqBK/NjG6l73mgrg99k3SOrsS7LxTjc8bi4Fv970ANd7xM14dML2I pwNifh9J4JqWZFCkxRWOaKAW0AuOxTimXCGMGlpLUa2emh6XGP1ByGaCGHZQrlpq ARrB6xTrAUwiFYTztjmoL/3jW3wirlSsBzRTMxrYNxE4MdqKPH4QMtjpMyTA8rIL xxS9UmUWaUbfcwAplNQxHCFuTUlu3o6JrbVHiQdiiN7yPvHsB+quSn6gxL7A== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=mailbox.org; s=mail20150812; t=1570691256; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Zhn3q5nsgiRVkwwWOxv7smEUbI7j7vJ/K26dTBn8bx0=; b=umPFSm/5o458SA7f8HtkFII4KW14fZeelrGoO/mMNzF89yL2Ukys/O5lgR5y7IS9qWlVO1 AvWAVUTNeN4uzAJuUGTAFZEGLDs4QN/vbLqnvkfzYtIvj59GIjYYbtCLAyxMZb15EjQSIS 5A/HO0wOkWSrQEjv6RbDl55ZwzROVVstUKffvLcOu/oYDHVkquQ1LEo/QwUPjcon+ZWVNz QHWWS3C4aYv/hd/WRnWh4cuTjv5HarAUvzbqaI1azKoP9BfS9ZpRYb0nPoGRw3ErRbqU0B bBTIugpfWBk0LhiclBLZLnQr8NpB3JMOb1ZhzjZOq7qmDWM1EyEhczG54+0GiQ== X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id KEmneR8j36iB; Thu, 10 Oct 2019 09:07:35 +0200 (CEST) From: Alexander Stein To: Navid Emamdoost Subject: Re: [PATCH] clk: bcm2835: Fix memory leak in bcm2835_register_pll Date: Thu, 10 Oct 2019 09:07:31 +0200 Message-ID: <1693637.czecojBbq0@ws-140106> In-Reply-To: <20191010013101.5364-1-navid.emamdoost@gmail.com> References: <20191010013101.5364-1-navid.emamdoost@gmail.com> MIME-Version: 1.0 X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20191010_000745_555806_D7299861 X-CRM114-Status: GOOD ( 18.28 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-arm-kernel@lists.infradead.org, Florian Fainelli , Scott Branden , Matthias Brugger , Stephen Boyd , Ray Jui , Michael Turquette , kjlu@umn.edu, linux-kernel@vger.kernel.org, Eric Anholt , emamd001@umn.edu, bcm-kernel-feedback-list@broadcom.com, Stefan Wahren , smccaman@umn.edu, Nicolas Saenz Julienne , linux-clk@vger.kernel.org, Max Filippov , linux-rpi-kernel@lists.infradead.org Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+infradead-linux-arm-kernel=archiver.kernel.org@lists.infradead.org Hello, On Thursday, October 10, 2019, 3:30:58 AM CEST Navid Emamdoost wrote: > In the implementation of bcm2835_register_pll(), the allocated memory > for pll should be released if devm_clk_hw_register() fails. > > Fixes: b19f009d4510 ("clk: bcm2835: Migrate to clk_hw based registration and OF APIs") > Signed-off-by: Navid Emamdoost > --- > drivers/clk/bcm/clk-bcm2835.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/clk/bcm/clk-bcm2835.c b/drivers/clk/bcm/clk-bcm2835.c > index 802e488fd3c3..99549642110a 100644 > --- a/drivers/clk/bcm/clk-bcm2835.c > +++ b/drivers/clk/bcm/clk-bcm2835.c > @@ -1320,8 +1320,10 @@ static struct clk_hw *bcm2835_register_pll(struct bcm2835_cprman *cprman, > pll->hw.init = &init; > > ret = devm_clk_hw_register(cprman->dev, &pll->hw); > - if (ret) > + if (ret) { > + kfree(pll); > return NULL; > + } > return &pll->hw; > } Eh, is pll freed at all, even in successful case? I failed to find a corresponding kfree(). The pointer itself is lost once the function returns. The solution would rather be to use devm_kzalloc instead of kzalloc, like the other clocks in e.g. bcm2835_register_pll() Best regards, Alexander _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel