From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 22743C4332F for ; Fri, 10 Nov 2023 20:38:50 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FPvDGIJcV7eyZqVDNTTSJG97gbavYFP0R9x+aRza+OU=; b=sPYBCXU2ZIj/AU LKYFa1Pm1bVodkV40MFQNA8jdD6HuhHgTFcI2x9JaJRtWVjFsiw9NC977k34XQdKaverq4T/e+e8V bKbsTqWS5uIUQBMXg2s0QLPyCvNAsRlFrAwbSkwDrpmBv7Pj0XL8SfnFcqSMrifjSOxRWRhbjPzRn cJc+5IqJL3iW+hs2rCZurD3ZS+XpY+MDLX6+e3QTr79+J9lEda3Z4Mnc/9nR46BjGnymnxgZeo3HD AGMC11OxggzaYYfd/Mi881JseBLWzVkiaOXRgyuIlZ/X8opsdAn36Z7xhPLAtq5F0Mye/HDLO96Vo k7CYw3eYw/az6mj0f0Jw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1YGi-009Oas-01; Fri, 10 Nov 2023 20:38:20 +0000 Received: from mail-oa1-f48.google.com ([209.85.160.48]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1YGe-009OaW-2D for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 20:38:17 +0000 Received: by mail-oa1-f48.google.com with SMTP id 586e51a60fabf-1f0820b7657so1279974fac.2 for ; Fri, 10 Nov 2023 12:38:15 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648694; x=1700253494; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nDEOGTCwLGe8/AbnY8N0ixov4mA0V6wpnOxoAqQPSK4=; b=j9jVBCQj1tQhfKl7YzQIzotHoDT9SCzfcYzFxXQiR1GlPAV9wU7vgkKLOkWD400TZI oB5Odc2kDZVDjW3mw+tnSLH6LYN0tQIywM7GjQ0//1BZt9S/NYLM/+n+Qzu0kC0koNih Fjig8giveyZknKBvCOdzznrokc07dEThL8AaaEEI0vdkStN4LthpZSAlpkV5t2ydwRZ7 lsYlGdk8sTSEFXD+nOBCTEs95m/WcIQbiyaLRefLIcwqMeXu9JV/9d8+v/K3oMZyxfK7 LYcKdraTpYvIas6c13dg2e7b8SRWB+FGvLW3Xb1HvLfkVY8UW0k8G9WN/P+V6rTofhTg W1mQ== X-Gm-Message-State: AOJu0YxUT8VBiQ8WKZhXlXUK53OZPaUywFnGfxgCCyR0+PpiY1DpEU0W v5HnHE6xUqScYGaM/dt7Jg== X-Google-Smtp-Source: AGHT+IFVVQE4BI8cOz3AIQYw2pXVqurA/tQ+STytYpdzYk+6P+Wjdqy5vAj94WGd/H3Kxm+R2FQFzQ== X-Received: by 2002:a05:6870:d1c2:b0:1ea:14eb:b741 with SMTP id b2-20020a056870d1c200b001ea14ebb741mr343191oac.54.1699648694529; Fri, 10 Nov 2023 12:38:14 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id y4-20020a056870a34400b001e9ce1b5e8fsm59655oak.15.2023.11.10.12.38.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:38:13 -0800 (PST) Received: (nullmailer pid 390527 invoked by uid 1000); Fri, 10 Nov 2023 20:38:11 -0000 Date: Fri, 10 Nov 2023 14:38:11 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: David Airlie , Andi Shyti , Lars-Peter Clausen , Alexandre Belloni , linux-iio@vger.kernel.org, Linus Walleij , Maxime Ripard , devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org, Tomasz Figa , Greg Kroah-Hartman , Rob Herring , Maarten Lankhorst , Thierry Reding , alsa-devel@alsa-project.org, Ulf Hansson , linux-rtc@vger.kernel.org, Sam Protsenko , Krzysztof Kozlowski , Jaehoon Chung , Lee Jones , Jiri Slaby , linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org, Conor Dooley , Liam Girdwood , linux-mmc@vger.kernel.org, Jonathan Cameron , linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org, linux-gpio@vger.kernel.org, Mark Brown , linux-i2c@vger.kernel.org, Thomas Zimmermann , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Sylwester Nawrocki , Alessandro Zummo , linux-serial@vger.kernel.org, Daniel Vetter , Alim Akhtar Subject: Re: [PATCH 02/17] dt-bindings: i2c: exynos5: add specific compatibles for existing SoC Message-ID: <169964869116.390473.6961652258456026108.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-3-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108104343.24192-3-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_123816_751503_EC4509EE X-CRM114-Status: GOOD ( 18.39 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 08 Nov 2023 11:43:28 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > Documentation/devicetree/bindings/i2c/i2c-exynos5.yaml | 10 +++++++++- > .../devicetree/bindings/soc/samsung/exynos-usi.yaml | 2 +- > 2 files changed, 10 insertions(+), 2 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel