From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id B0071C41535 for ; Fri, 10 Nov 2023 20:40:06 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=D+jsmtY3304PGlpM37F9vg+T3NFsVglptElEqArnvsE=; b=MTdLbM1iSIr7h3 DsJJe/OcNKoUBEVrCB8Q+5kZY17/vaFFG2D/nnw1HfFwP2iQGxOvco/uQ45Ok9cZrwE8uENPiQrCa rQ/l4+6Ys/wb94R3X+Sbu52RWkhaqRkNIVtV+JB8HdWQ8szCxM75Jl6hJZHuFdyzM1B0A3zpF7kZe buzqzgY/n06g+bXuWjpxqOW9UXFqsZ2E2YE6IthK3E4kp5zK2W80LlBFzzgG/dU6ZBZTdPz1Qsq2y qYXj4mBHmJz7WyxcoqJ421IQA+8LrQS+FwibHrh2gY2Fdy5huQGCONFyaP0Phqtn5/a4Kerc2bP7w khTHD80SmbQlL7vSTK7Q==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1YI4-009Onu-31; Fri, 10 Nov 2023 20:39:44 +0000 Received: from mail-ot1-f44.google.com ([209.85.210.44]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1YI1-009Omq-32 for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 20:39:43 +0000 Received: by mail-ot1-f44.google.com with SMTP id 46e09a7af769-6ce29d1db6eso1710097a34.1 for ; Fri, 10 Nov 2023 12:39:40 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648780; x=1700253580; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=q2mpCZw6APjzuy5DVtlkGaasSgeytmGTQ3T7Ai89NIc=; b=FNhcjSTaKIduv9tfbcfy/UjV0+QDqju/GxwBB0aU+N6i4DBnFX6lz8OAQ7mHnHsseH 11NB9YcpL9AS9RsWGmWw2rUkOKbrN/ksgbae/UvSmF2lohsux7Idn5ilKjNky7q8DATY FrhHj2cgiw8R7hhzjBpPZVFwH4bWoZn1ZFgYNCIq0AKAjDwQGn5b0xPbzi2Czuf1TQDf 7U7WMNrlTuPCASXZWkOxjsL3C8Lv8AtzEP+Dr6Uu2kB74kzwGOFMdbwcAOw8SVnKdUNr RH09BcZMVl65TW1Im8N75zd6kaiqULhvjDwpo05ANrTfoIMDJtieZzko5KN1aiqemybS Lt/w== X-Gm-Message-State: AOJu0YxwvUPlIwgVTrAMh7FOKTnsL0NH5uSt+hD0pl8rELv6LoGPD35s b4l5akgyY3Wk+82+/4CNEw== X-Google-Smtp-Source: AGHT+IFDEevgxfWBbNoBxZy5wpEh6g0d1RAursubSv3B8D6mEOOuHNqGY4vD4lMK2cqLkNv2mYVlyQ== X-Received: by 2002:a9d:73d0:0:b0:6d6:5175:50c9 with SMTP id m16-20020a9d73d0000000b006d6517550c9mr157442otk.6.1699648780318; Fri, 10 Nov 2023 12:39:40 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id i15-20020a056830450f00b006ce2b90d0cesm51017otv.24.2023.11.10.12.39.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:39:39 -0800 (PST) Received: (nullmailer pid 392734 invoked by uid 1000); Fri, 10 Nov 2023 20:39:37 -0000 Date: Fri, 10 Nov 2023 14:39:37 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: dri-devel@lists.freedesktop.org, Alessandro Zummo , Sam Protsenko , Ulf Hansson , Alim Akhtar , Rob Herring , Alexandre Belloni , linux-serial@vger.kernel.org, Lee Jones , Conor Dooley , Sylwester Nawrocki , Jonathan Cameron , Andi Shyti , Thomas Zimmermann , Liam Girdwood , linux-i2c@vger.kernel.org, linux-rtc@vger.kernel.org, Maarten Lankhorst , linux-samsung-soc@vger.kernel.org, linux-mmc@vger.kernel.org, Greg Kroah-Hartman , Lars-Peter Clausen , linux-gpio@vger.kernel.org, Daniel Vetter , Jaehoon Chung , Thierry Reding , devicetree@vger.kernel.org, Maxime Ripard , Jiri Slaby , Tomasz Figa , alsa-devel@alsa-project.org, Mark Brown , linux-iio@vger.kernel.org, Krzysztof Kozlowski , linux-sound@vger.kernel.org, linux-pwm@vger.kernel.org, Linus Walleij , linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , David Airlie , linux-kernel@vger.kernel.org Subject: Re: [PATCH 04/17] dt-bindings: mmc: samsung,exynos-dw-mshc: add specific compatibles for existing SoC Message-ID: <169964877627.392672.14874068087701843483.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-5-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108104343.24192-5-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_123941_983137_5A5EF89D X-CRM114-Status: GOOD ( 18.33 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 08 Nov 2023 11:43:30 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > While re-indenting the first enum, put also axis,artpec8-dw-mshc in > alphabetical order. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../bindings/mmc/samsung,exynos-dw-mshc.yaml | 25 ++++++++++++------- > 1 file changed, 16 insertions(+), 9 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel