From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id A5EE2C4332F for ; Fri, 10 Nov 2023 20:40:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=FKsyb350f0omKPEY/iiiaiSdHv6LXt1Js6WBSGachOc=; b=DK2xT32aWCdvwU FLkwOpZnF0zGNccXeGFFRPeApPcmhvGNk6TxdWBJ7yRYjEmUEIyUrjXehzLG8sZ91v9awy8yEqHbE CZqSb12D01/9HE+6FxwatfmGvD/kJlI7V6QMIsaqil+7mDgl9w18WyFmWwycyxVQLgYLo3JhPW7Mn xc8OhcVjsvloqXXopMKGUi/93eMXogy4AZ7xX2KJFCankGEUXrXQnDX1tsAaYpbYGKuIPjbTbwIgG j99+y9lS2BgCXhZ94ZmV/Pej9XHXguOEhJ/sQn52ntlTCmHLHonrck8ff4uU0tN76dpMD/gyE/LSO Slp4GPlh4dWMEUcjR4yw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1YIQ-009Osu-0H; Fri, 10 Nov 2023 20:40:06 +0000 Received: from mail-ot1-f48.google.com ([209.85.210.48]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1YIN-009OsK-2L for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 20:40:04 +0000 Received: by mail-ot1-f48.google.com with SMTP id 46e09a7af769-6cd0a8bc6dcso1399361a34.2 for ; Fri, 10 Nov 2023 12:40:03 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648803; x=1700253603; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=gIUKFeCBp8QWWYNKFRJyz0CogaqLBpf4Mvy06PqKugo=; b=dGc9GGi/jdaXwI7NNPLJI8iuaXHd8u7IZQ3oSX9Ww6F5D0RnFZLTiuNGKm72HF0Sm+ JpYLsbQ2xtKTs/VeKIS/MWrFu9Vn2h524BbR7r+1thiyIgEVYplW1oz+IkkFSaNadOkg bvbkf9pFeOxhLpjM/1UCfD3/OGgk+W236gxj29S0Ud8jIsAfjVsDie0RIr9gqkuearNK HPAHhLip3oQciQs8Ev4Dv2QnyBXicC4S5jtbdPBUPhxWJJIa3xADtl6QzYU2kU9m8Hsi sBLBLjiNiNsu/xB7yJaFopkQw/aVHzNPBfB8F2lnGJlwZ/lXdbI0e+xK5LhntXAAa0Rf WU5A== X-Gm-Message-State: AOJu0Ywc08cEba5mvrpCCJsfYpAui4rpi0iLjrCJ8PVl24Z5+k6TqEtv 4M4kQppX/Pou350TMPnJZw== X-Google-Smtp-Source: AGHT+IHRxgqmlIcaZxA+uUtss7i4GqToCENI8qvZ/6FLZfO0lFbqJf5Tp34OcuHctKTILzporo4hUw== X-Received: by 2002:a05:6830:2644:b0:6ba:865b:ca72 with SMTP id f4-20020a056830264400b006ba865bca72mr207172otu.31.1699648803023; Fri, 10 Nov 2023 12:40:03 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id do2-20020a0568300e0200b006d64467c68asm46743otb.77.2023.11.10.12.40.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:40:02 -0800 (PST) Received: (nullmailer pid 393449 invoked by uid 1000); Fri, 10 Nov 2023 20:40:00 -0000 Date: Fri, 10 Nov 2023 14:40:00 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Rob Herring , Mark Brown , Daniel Vetter , linux-arm-kernel@lists.infradead.org, Maarten Lankhorst , Linus Walleij , linux-pwm@vger.kernel.org, linux-iio@vger.kernel.org, linux-sound@vger.kernel.org, linux-samsung-soc@vger.kernel.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Ulf Hansson , linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, Krzysztof Kozlowski , Liam Girdwood , Thomas Zimmermann , Greg Kroah-Hartman , Sam Protsenko , Alim Akhtar , Jiri Slaby , alsa-devel@alsa-project.org, Tomasz Figa , dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lars-Peter Clausen , Alexandre Belloni , linux-serial@vger.kernel.org, David Airlie , Sylwester Nawrocki , Jaehoon Chung , Jonathan Cameron , Maxime Ripard , Thierry Reding , Conor Dooley , linux-rtc@vger.kernel.org, Lee Jones , Alessandro Zummo , Andi Shyti Subject: Re: [PATCH 05/17] dt-bindings: pinctrl: samsung: add specific compatibles for existing SoC Message-ID: <169964880016.393384.2296633788360305234.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-6-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108104343.24192-6-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_124003_770666_5FB1E2C9 X-CRM114-Status: GOOD ( 18.17 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 08 Nov 2023 11:43:31 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../samsung,pinctrl-wakeup-interrupt.yaml | 24 ++++++++++++------- > .../bindings/pinctrl/samsung,pinctrl.yaml | 3 ++- > 2 files changed, 17 insertions(+), 10 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel