From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 13221C4332F for ; Fri, 10 Nov 2023 20:41:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=x7ikZceIUVIAualFVNmNG3lsZDa8eMp2NjwyB8C1Dl0=; b=dllPgslj/wdVyL 5BgDPfYg6FT5mN3GO1ELMp4UyBGt3zfdRwbRfo8lrbJ5DXz0ButdXx5y6dooGXWbIGi2P99xxqr35 5hcOj8LN6K6HIdd9qL76TfWyghoxMWf7pnJ0wlbbZDIQVwmN65YrebNpOPglucd1NuPeLvaZkBj18 X6iZ5PE8utYn+qPV/pWqnYSXSaILbXoseXTP0Dp4BfKxwK75KZZm4yJpHOLrMlgI9NeOwaJA8TINc 6McBEsNj7+xPZL0MWqafYaaU1d7c+jbrlxOWE7RhxDbfXbMqwgytoWieZ/lj7/UJfd3k3U3MFgRB1 YHd1hvn6ehK2rDTLJQRw==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1YJX-009P8a-2P; Fri, 10 Nov 2023 20:41:15 +0000 Received: from mail-oa1-f54.google.com ([209.85.160.54]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1YJW-009P7f-0E for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 20:41:15 +0000 Received: by mail-oa1-f54.google.com with SMTP id 586e51a60fabf-1efb9571b13so1413493fac.2 for ; Fri, 10 Nov 2023 12:41:12 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699648872; x=1700253672; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=sBu9jdlI8BmMP2EXqok2V/jfQ0F843VqKLKqoYajCbY=; b=QlQqH9HHR61pUtaajKDrfeGy+sVPQLvDOTGx+9zCBXxUuKQu1j4kheb5vIPUCUjH4W v6Y0C9LVeODwM+99BthsmKyRXtuLo4OICQk2cy91ZNK5Zan6MLuEEsrbRJHCnkGGFKaf lmos8tronZIpvj23pvRWU+sGgIlDdjFEnyEtbesKk4kw5Plpk1IjFgE+BhItNqrEqMSb ODwtQfyEDwqrFKp3K7KxKfd6PUs+oHhwNgI+0W0blVSG2HFLUXEVczfxohUiC6Qr5YQi wlRiHocEA4VpCR3xlDvupSBWjOTtkPTOyxLvXgjJBJCO2Uh6ZLGtZxBGzOQx85yg0ESN MBeQ== X-Gm-Message-State: AOJu0Yw7iRkDSzQu513XJZjGgNAgTTITm8fG/8zlNhjoIPM0vTYcUO3f 7jbvXB7LLXxhJR2ZOwSjlw== X-Google-Smtp-Source: AGHT+IE7LNnk5DWomU2D9t+1ZTG+6ik+KpyphzRkzXtQujj9+w3A1KWUmfC2t3Snd6+6Q7shaSdaiw== X-Received: by 2002:a05:6870:c986:b0:1d5:40df:8fb1 with SMTP id hi6-20020a056870c98600b001d540df8fb1mr335335oab.19.1699648871913; Fri, 10 Nov 2023 12:41:11 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id mo37-20020a056871322500b001cd1a628c40sm57032oac.52.2023.11.10.12.41.09 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:41:11 -0800 (PST) Received: (nullmailer pid 395219 invoked by uid 1000); Fri, 10 Nov 2023 20:41:09 -0000 Date: Fri, 10 Nov 2023 14:41:09 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Jaehoon Chung , Jonathan Cameron , linux-rtc@vger.kernel.org, Alessandro Zummo , Sam Protsenko , Ulf Hansson , linux-pwm@vger.kernel.org, Krzysztof Kozlowski , dri-devel@lists.freedesktop.org, linux-i2c@vger.kernel.org, Mark Brown , Lee Jones , Jiri Slaby , linux-serial@vger.kernel.org, alsa-devel@alsa-project.org, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, Conor Dooley , Alexandre Belloni , Greg Kroah-Hartman , David Airlie , Tomasz Figa , Alim Akhtar , linux-arm-kernel@lists.infradead.org, =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , linux-sound@vger.kernel.org, Thomas Zimmermann , linux-samsung-soc@vger.kernel.org, Rob Herring , Daniel Vetter , Andi Shyti , linux-kernel@vger.kernel.org, Maxime Ripard , Thierry Reding , linux-iio@vger.kernel.org, Maarten Lankhorst , Lars-Peter Clausen , Sylwester Nawrocki , Liam Girdwood , Linus Walleij , linux-mmc@vger.kernel.org Subject: Re: [PATCH 07/17] dt-bindings: serial: samsung: add specific compatibles for existing SoC Message-ID: <169964886893.395180.18336203725841457804.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-8-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108104343.24192-8-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_124114_111095_C8320F3F X-CRM114-Status: GOOD ( 19.72 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 08 Nov 2023 11:43:33 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Re-shuffle also the entries in compatibles, so the one-compatible-enum > is the first. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../devicetree/bindings/serial/samsung_uart.yaml | 14 +++++++++++--- > 1 file changed, 11 insertions(+), 3 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel