From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E8401C4332F for ; Fri, 10 Nov 2023 20:43:57 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:References: Message-ID:Subject:Cc:To:From:Date:Reply-To:Content-ID:Content-Description: Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID: List-Owner; bh=KeckLk/1ejbC69q20MtQbTO1VDcCDklsyVkcU8e9E5U=; b=iXVtmJ9oV3BZ/8 VeuMkLJwa/npQqZqb0lBCjnc0ks80U5KLqeSRkb+QQnc3flshAq83S0iMP1fwnxYOw63ytnWjvgdW wseU0RRyQbtjDn0xqFxxuI4QKFDx41RsOlNA5nQXXhceWSuuQUHc/u4JK/r2gCtQI4v8ykkfNVaBS 7+xWOh1HZgzIFz/i4yVtPwn7viC3d7RltsgLbqaaAWG1oK+zEaWL5+uNF1uQeDpnN/O26rY4lz6C/ SIEnItTir9GH3lPzgiS18mOjinIcF4f69nv4nrwfPOcSQHxnBphOAnXK3tqoXsPHipk2xtScj9Da1 RNQhxJVlkvFE0iJKlybQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.96 #2 (Red Hat Linux)) id 1r1YLi-009Poc-1x; Fri, 10 Nov 2023 20:43:30 +0000 Received: from mail-oi1-f170.google.com ([209.85.167.170]) by bombadil.infradead.org with esmtps (Exim 4.96 #2 (Red Hat Linux)) id 1r1YLg-009PmW-13 for linux-arm-kernel@lists.infradead.org; Fri, 10 Nov 2023 20:43:29 +0000 Received: by mail-oi1-f170.google.com with SMTP id 5614622812f47-3b2ec9a79bdso1543681b6e.3 for ; Fri, 10 Nov 2023 12:43:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699649000; x=1700253800; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=nNaUrVj08NBtZOvpIGNqsCz93eA7N7P0VcAZpJigNHA=; b=YCX3MPX2ZNmub/5Ml4663KKyuJv3wDj33LeG/Uo2yoKVNSNV1AiXiX9TztKunu5yQw Sm3UHBmv3efHtvqKm3wEG5RnNFUSv8PfoVRxBrw7fgKWE02mfD1GVBWe1ir4x1YRIjzh N+sPeCoO7SOafvSQMhej6zNXmybe2Ti8ohHqGGLly3nW5Tl/IMKOrgf/hlsAxPrmftBX mG8++YQ85cMxeTsqHjXLk9BNihLhEJXz/y/CGhi6d/YI2ZI4YytiCay3/MgQoFf2xD5Z 7PP9//qlvcakDDqE7oglTJkEPObV4HBMzj0y1BonLicinq4unfjBk1zoc31O1zT3DXsP AC1g== X-Gm-Message-State: AOJu0YygJ6Fq0H2JDoFt4fpsFd+y3fbangEv0r4QDtjeNyitUNOcZD4z SYV08ONYNxqrSzBuKShp9Q== X-Google-Smtp-Source: AGHT+IGuCIrvtFv3ALEU5ciLcJTT36N1k9uB2xQVwrMFf1+eMSPG74AQUVS8heVBUqI66wOHlKeqbA== X-Received: by 2002:a05:6871:551:b0:1dc:9714:e2b3 with SMTP id t17-20020a056871055100b001dc9714e2b3mr423099oal.7.1699649000334; Fri, 10 Nov 2023 12:43:20 -0800 (PST) Received: from herring.priv (66-90-144-107.dyn.grandenetworks.net. [66.90.144.107]) by smtp.gmail.com with ESMTPSA id l22-20020a056870d4d600b001efc94cc21bsm57823oai.58.2023.11.10.12.43.17 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 10 Nov 2023 12:43:19 -0800 (PST) Received: (nullmailer pid 398686 invoked by uid 1000); Fri, 10 Nov 2023 20:43:17 -0000 Date: Fri, 10 Nov 2023 14:43:17 -0600 From: Rob Herring To: Krzysztof Kozlowski Cc: Ulf Hansson , Jiri Slaby , Mark Brown , linux-gpio@vger.kernel.org, Maarten Lankhorst , Linus Walleij , Liam Girdwood , Jaehoon Chung , Tomasz Figa , Sam Protsenko , Rob Herring , Thomas Zimmermann , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, linux-rtc@vger.kernel.org, Alessandro Zummo , Krzysztof Kozlowski , linux-serial@vger.kernel.org, Lee Jones , Sylwester Nawrocki , Alexandre Belloni , dri-devel@lists.freedesktop.org, Thierry Reding , Greg Kroah-Hartman , linux-sound@vger.kernel.org, Andi Shyti , =?UTF-8?Q?Uwe_Kleine=2DK=C3=B6nig?= , Lars-Peter Clausen , linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org, Conor Dooley , Daniel Vetter , linux-mmc@vger.kernel.org, Maxime Ripard , alsa-devel@alsa-project.org, Alim Akhtar , David Airlie , Jonathan Cameron , linux-i2c@vger.kernel.org, linux-pwm@vger.kernel.org, linux-samsung-soc@vger.kernel.org Subject: Re: [PATCH 11/17] ASoC: dt-bindings: samsung-i2s: add specific compatibles for existing SoC Message-ID: <169964899705.398637.5382830943719270282.robh@kernel.org> References: <20231108104343.24192-1-krzysztof.kozlowski@linaro.org> <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20231108104343.24192-12-krzysztof.kozlowski@linaro.org> X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20231110_124328_361632_B9229540 X-CRM114-Status: GOOD ( 18.48 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On Wed, 08 Nov 2023 11:43:37 +0100, Krzysztof Kozlowski wrote: > Samsung Exynos SoC reuses several devices from older designs, thus > historically we kept the old (block's) compatible only. This works fine > and there is no bug here, however guidelines expressed in > Documentation/devicetree/bindings/writing-bindings.rst state that: > 1. Compatibles should be specific. > 2. We should add new compatibles in case of bugs or features. > > Add compatibles specific to each SoC in front of all old-SoC-like > compatibles. > > Signed-off-by: Krzysztof Kozlowski > > --- > > I propose to take the patch through Samsung SoC (me). See cover letter > for explanation. > --- > .../mfd/samsung,exynos5433-lpass.yaml | 2 +- > .../bindings/sound/samsung-i2s.yaml | 19 ++++++++++++------- > 2 files changed, 13 insertions(+), 8 deletions(-) > Acked-by: Rob Herring _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel