From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 55972EC1EA2 for ; Thu, 5 Feb 2026 11:31:27 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:List-Subscribe:List-Help :List-Post:List-Archive:List-Unsubscribe:List-Id:Content-Transfer-Encoding: Content-Type:In-Reply-To:From:References:CC:To:Subject:MIME-Version:Date: Message-ID:Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=7UBhJ73e051Mk+tlHUHiR4Nte6z3Ds+Lhr+zU54LiUM=; b=qzz/gu1EBXetbpQpnqBO5o/StQ Ibv+xpU2IyhO+AOPYi4XV4V+XZmAMiMfgXPeMiKvRC17JxHVFjbeF6jrJEIRmeOqRBwmLFFNuHB4n pfJuZ9BjvI5UrtTGElCypKrC8b4OpiN1M+tCZl7EpeXeCh2zF9obUIgHmhTVS/tM/F4MCz8thVz14 oGq+9MDPLWCfr4GrZS4zxl/YMykRa907UG0RgBYKgnV694YbhcexAt5OblD6zFgQELcWXrl8xCykm blCrSsw3OAy/2KKkEAB1togndOCXxsIAlREh+v/OOj/KRRAReLJC5i1bARohM55l+nfUU9ctIlyQK /+rviSyQ==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnxZw-00000009pqP-202t; Thu, 05 Feb 2026 11:31:20 +0000 Received: from canpmsgout06.his.huawei.com ([113.46.200.221]) by bombadil.infradead.org with esmtps (Exim 4.98.2 #2 (Red Hat Linux)) id 1vnxZr-00000009ppQ-0sno for linux-arm-kernel@lists.infradead.org; Thu, 05 Feb 2026 11:31:18 +0000 dkim-signature: v=1; a=rsa-sha256; d=huawei.com; s=dkim; c=relaxed/relaxed; q=dns/txt; h=From; bh=7UBhJ73e051Mk+tlHUHiR4Nte6z3Ds+Lhr+zU54LiUM=; b=tPyWKxoSE7FRfS8E9zhQ2Yj/Tk/01V46A/BzF1stBfsx5Tk6UoFIP7Q3SeQmSNVDD/KrsVc69 EQ2kzM3bwCTfjuo2tE092uXRZvVZC968OjuEy0r5D5GzeYSZecuLRrwi9etqxUn/XUcrLoGfqjJ biRWE6u6CmUndSkiVk0quiI= Received: from mail.maildlp.com (unknown [172.19.162.223]) by canpmsgout06.his.huawei.com (SkyGuard) with ESMTPS id 4f6FKb1N66zRhQp; Thu, 5 Feb 2026 19:26:27 +0800 (CST) Received: from dggemv712-chm.china.huawei.com (unknown [10.1.198.32]) by mail.maildlp.com (Postfix) with ESMTPS id 76B6D40561; Thu, 5 Feb 2026 19:31:01 +0800 (CST) Received: from kwepemn100008.china.huawei.com (7.202.194.111) by dggemv712-chm.china.huawei.com (10.1.198.32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.11; Thu, 5 Feb 2026 19:31:01 +0800 Received: from [10.67.120.139] (10.67.120.139) by kwepemn100008.china.huawei.com (7.202.194.111) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.2.1544.36; Thu, 5 Feb 2026 19:31:00 +0800 Message-ID: <16b06f6f-e251-4fb6-9c82-e9a366351a02@huawei.com> Date: Thu, 5 Feb 2026 19:30:59 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 1/3] soc cache: L3 cache driver for HiSilicon SoC To: Krzysztof Kozlowski CC: Arnd Bergmann , Alexandre Belloni , Drew Fustini , "Jonathan Cameron" , Linus Walleij , Will Deacon , , , , , , , Zhou Wang , Wei Xu References: <20260203161843.649417-1-wangyushan12@huawei.com> <20260203161843.649417-2-wangyushan12@huawei.com> <1d7abd11-2064-4437-8ad7-7cfe1b2e75c0@huawei.com> <82c73122-4d0e-45f5-b1b4-3cf743353fd6@kernel.org> Content-Language: en-US From: wangyushan In-Reply-To: <82c73122-4d0e-45f5-b1b4-3cf743353fd6@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.67.120.139] X-ClientProxiedBy: kwepems200001.china.huawei.com (7.221.188.67) To kwepemn100008.china.huawei.com (7.202.194.111) X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20260205_033116_272559_1533E810 X-CRM114-Status: GOOD ( 17.19 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org On 2/5/2026 7:23 PM, Krzysztof Kozlowski wrote: > On 05/02/2026 12:19, wangyushan wrote: >> >> On 2/5/2026 5:37 PM, Krzysztof Kozlowski wrote: >>> On 03/02/2026 18:19, Arnd Bergmann wrote: >>>> On Tue, Feb 3, 2026, at 17:18, Yushan Wang wrote: >>>>> The driver will create a file of `/dev/hisi_l3c` on init, mmap >>>>> operations to it will allocate a memory region that is guaranteed to be >>>>> placed in L3 cache. >>>>> >>>>> The driver also provides unmap() to deallocated the locked memory. >>>>> >>>>> The driver also provides an ioctl interface for user to get cache lock >>>>> information, such as lock restrictions and locked sizes. >>>>> >>>>> Signed-off-by: Yushan Wang >>>> >>>> Hi Yushan, >>>> >>>> Thanks for your submission. Since we are in the last week of >>>> the merge window, this is not going to be linux-7.0 material, >>>> but I'll have a quick look for now. >>> >>> >>> To be clear - this is a v3 but with removed previous history... >>> >>> Previous version: >>> https://lore.kernel.org/all/20251217102357.1730573-2-wangyushan12@huawei.com/ >>> >>> Or even v4? >>> >>> https://lore.kernel.org/all/20250122065803.3363926-2-wangyushan12@huawei.com/ >>> >>> Yushan, please start versioning your patches correctly. Use b4 or git >>> format-patch -vx >> >> Hi Krzysztof, >> >> Sorry about the confusing versions, the complete history is as below: >> >> Link to v1: https://lore.kernel.org/all/20250107132907.3521574-1-wangyushan12@huawei.com >> >> Link to v2: https://lore.kernel.org/all/20250122065803.3363926-1-wangyushan12@huawei.com/ >> >> Link to RFC v1: https://lore.kernel.org/all/20251125080542.3721829-1-wangyushan12@huawei.com/ >> >> Link to RFC v2: https://lore.kernel.org/all/20251217102357.1730573-1-wangyushan12@huawei.com/ >> >> Link to v1 again (this message): https://lore.kernel.org/all/20260203161843.649417-1-wangyushan12@huawei.com/ >> >>> >>> Otherwise, please explain us how can we compare it with `b4 diff` with >>> previous version? >>> >>> Sending something AGAIN as v1 ignoring entire previous submission is >>> clear no go. Like you are trying till it succeeds. Negative review? >>> Let's try from v1 this time... >>> >>> This is not correct and it should not be my task to find your previous >>> discussions and decipher this v1. >> >> I did spin 2 versions to mainline as the actual v1, the thread was quiet. >> Then I made a major refactor to it and sent it as RFC, the thread went >> quiet again but some compile check issues popped up. I spinned 2 >> versions of RFC for the compile issues and removed RFC in this version >> since no strong objection showed up. >> >> Apologize that I broke the rules and any inconvenience caused by it. >> As there's little discussion in previous patches, is it OK that we start >> here as v1? > > No, it is not okay. Your patchset continues and entire previous feedback > and history is important. Otherwise why would I review this if I can as > well ignore it and wait for next year you sending another v1? Sorry, I will correct the version numbers in next versions, with whole history and explanations about the mess. Sincerely apologies, I won't hide the versions again. Yushan